You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/02 11:49:39 UTC

[GitHub] [incubator-kyuubi] yanghua opened a new issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

yanghua opened a new issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar issues.
   
   
   ### Describe the proposal
   
   The detailed proposal is [here](https://github.com/apache/incubator-kyuubi/discussions/1132).
   
   ### Task list
   
   TBD
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] link3280 commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
link3280 commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1004939252


   @yanghua I noticed that `ExecuteStatement` of Flink engine now supports QueryOperation only. May I add a subtask and create a PR to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957398492


   great work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] pan3793 commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
pan3793 commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1068955514


   Thanks to all contributors who participated, I'm going to close this ticket, and please go ahead in #2100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957392006


   I can’t wait to see this happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957392006


   I can’t wait to see this happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] pan3793 closed issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
pan3793 closed issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yanghua commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002516878


   > > @yanghua @yaooqinn , any other subtasks? In above task list, the tasks are completed.
   > 
   > @yanghua could you add more uncompleted tasks to the list, like metaapis, operation logs etc
   
   fine, there are still many operations that did not implement @SteNicholas . Will file more subtask issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] pan3793 commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
pan3793 commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002447473


   > In above task list, the tasks are completed.
   
   Not yet. The current implementation should be considered as a PoC version, and we do find some disadvantages of this approach, the next step is to investigate Flink `application` mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002539060


   @yanghua @yaooqinn @pan3793 , thanks for your reply. IMO, the current implementation doesn't affect the interface definition. Therefore, I could start to add the operations based on the current implementation. Right? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yanghua commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1014199242


   @SteNicholas Ping me if you create new subtasks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957392006


   I can’t wait to see this happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957398492


   great work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-957398492


   great work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002473230


   > @yanghua @yaooqinn , any other subtasks? In above task list, the tasks are completed.
   
   @yanghua could you add more uncompleted tasks to the list, like metaapis, operation logs etc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yanghua commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002562591


   > @yanghua Thanks for your great work! The proposal seems to be sort of lagged behind. It would be great if we can update it as well. I'll be happy to take some tasks if possible.
   
   You are right. The design doc does not match the implementation. Will update it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yanghua commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1005097101


   > ExecuteStatement
   
   Absolutely yes, welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002444161


   @yanghua @yaooqinn , any other subtasks? In above task list, the tasks are completed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yanghua commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002539573


   > @yanghua @yaooqinn @pan3793 , thanks for your reply. IMO, the current implementation doesn't affect the interface definition. Therefore, I could start to add the operations based on the current implementation. Right?
   
   yes, brother


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] link3280 commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
link3280 commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1002547825


   @yanghua Thanks for your great work! The proposal seems to be sort of lagged behind. It would be great if we can update it as well. I'll be happy to take some tasks if possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1322: [Umbrella][KPIP-2] Support FlinkSQL Engine

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1322:
URL: https://github.com/apache/incubator-kyuubi/issues/1322#issuecomment-1064704318


   retargeting improvement PR to v1.6 and collection to another ticket https://github.com/apache/incubator-kyuubi/issues/2100 to track


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org