[GitHub] [iceberg] rdblue commented on a diff in pull request #5771: Core: Deprecate functions in DeleteWriters

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5771:
URL: https://github.com/apache/iceberg/pull/5771#discussion_r984033327


##########
core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java:
##########
@@ -167,7 +167,9 @@ private void flushDeletes() {
         List<PosRow<T>> positions = posDeletes.get(wrapper.set(path));
         positions.sort(Comparator.comparingLong(PosRow::pos));
 
-        positions.forEach(posRow -> closeableWriter.delete(path, posRow.pos(), posRow.row()));
+        PositionDelete<T> posDelete = PositionDelete.create();
+        positions.forEach(
+            posRow -> closeableWriter.write(posDelete.set(path, posRow.pos(), posRow.row())));

Review Comment:
   @nastra, this changes the behavior to create a new `PositionDelete` for every delete rather than reusing the same one. Can you follow up with a fix to restore the old behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org