[jira] [Commented] (MJAVADOC-431) allow javadoc jar to contain Maven descriptor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644951#comment-14644951 ] 

ASF GitHub Bot commented on MJAVADOC-431:
-----------------------------------------

GitHub user peterlynch opened a pull request:

    https://github.com/apache/maven-plugins/pull/57

    MJAVADOC-431 allow maven descriptor to javadoc jar

    Note: maven-archiver dependency version was upgraded to take advantage of MavenProject.clone(), which avoids having the new unit test from creating a maven-archiver directory in the basedir because the MavenProject() constructor used in 2.5 does not copy the build element.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sonatype/maven-plugins MJAVADOC-431-maven-descriptor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 8bcf42405d1171da9a7fb370c1af0ae8178f8986
Author: Peter Lynch <pl...@sonatype.com>
Date:   2015-07-28T19:55:51Z

    MJAVADOC-431 allow maven descriptor to javadoc jar
    
    Note: maven-archiver dependency version was upgraded to take advantage of MavenProject.clone(), which avoids having the new unit test from creating a maven-archiver directory in the basedir because the MavenProject() constructor used in 2.5 does not copy the build element.

----


> allow javadoc jar to contain Maven descriptor
> ---------------------------------------------
>
>                 Key: MJAVADOC-431
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-431
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 2.10.3
>            Reporter: Peter lynch
>
> The javadoc:jar mojo explicitly prevents the Maven descriptor from being added to the produced javadoc.jar file.
> https://github.com/apache/maven-plugins/blob/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/JavadocJar.java#L299-299
> I could not find an explanation or technical reason why this is done.
> Adding the maven descriptor to the javadoc jar can help expose valuable information about the build that produced it and should be at the discretion of the build process.
> Expected:
> - allow the archiver used to create the javadoc jar to respect the plexus archiver configuration if it is configured to include the Maven descriptor.
> - preserve the default behaviour of not including the Maven descriptor, for (unknown) backwards compatibility reasons only



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)