You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "nathluu (via GitHub)" <gi...@apache.org> on 2023/04/26 13:51:31 UTC
[GitHub] [nifi] nathluu opened a new pull request, #7197: NIFI-11485 Add nifi toolkit to registry image
nathluu opened a new pull request, #7197:
URL: https://github.com/apache/nifi/pull/7197
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11485](https://issues.apache.org/jira/browse/NIFI-11485)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ferencerdei commented on pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "ferencerdei (via GitHub)" <gi...@apache.org>.
ferencerdei commented on PR #7197:
URL: https://github.com/apache/nifi/pull/7197#issuecomment-1536097224
The ticket description mentioned that you need the NiFi toolkit to encrypt the nifi-registry properties. In my opinion, you should be able to do this with an init container in Kubernetes. With your approach, you'd bundle a different application into nifi-registry which we shouldn't do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181144935
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
This change is to build a registry container image all from the source code, if there is a change in nifi registry code it will also be update the image with that change. By that way you should refer Dockerfile at [nifi-docker/dockermaven/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockermaven/Dockerfile#L43) but not [nifi/nifi-docker/dockerhub/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181144935
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
This change is to build a registry container image all from the source code, if there is a change in nifi toolkit code the image will also be updated with that change. By that way you should refer Dockerfile at [nifi-docker/dockermaven/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockermaven/Dockerfile#L43) but not [nifi/nifi-docker/dockerhub/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58) which is used to build container image from apache official published binaries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181144935
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
This change is to build a registry container image all from the source code, if there is a change in nifi toolkit code it will also be update the image with that change. By that way you should refer Dockerfile at [nifi-docker/dockermaven/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockermaven/Dockerfile#L43) but not [nifi/nifi-docker/dockerhub/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7197: NIFI-11485 Add nifi toolkit to registry image
URL: https://github.com/apache/nifi/pull/7197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181144935
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
This change is to build a registry container image all from the source code, if there is a change in nifi toolkit code the image will also be updated with that change. By that way you should refer Dockerfile at [nifi-docker/**dockermaven**/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockermaven/Dockerfile#L43) but not [nifi/nifi-docker/**dockerhub**/Dockerfile](https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58) which is used to build container image from apache official published binaries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on PR #7197:
URL: https://github.com/apache/nifi/pull/7197#issuecomment-1546795445
Hi @ferencerdei,
nifi-toolkit is a utility tool released alongside every NiFi and NiFi registry release so I think it totally can be integrated into the NiFi Registry container image just as NiFi container image. The important reason is that the encryption of nifi-registry.properties file cannot happen at the pod startup time as it needs the nifi-registry.properties and bootstrap.conf files to exist beforehand. Please refer to these helm charts for details how a nifi and nifi registry pod is started
https://github.com/cetic/helm-nifi/blob/master/templates/statefulset.yaml
https://github.com/dysnix/charts/blob/main/dysnix/nifi-registry/templates/statefulset.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181136943
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
I think it would better to use the approach used in the main docker image where the NiFi binary is downloaded rather than pulled from the nifi-assembly package.
https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nathluu commented on a diff in pull request #7197: NIFI-11485 Add nifi toolkit to registry image
Posted by "nathluu (via GitHub)" <gi...@apache.org>.
nathluu commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181158900
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to nifi-registry-docker for image build">
Review Comment:
I also updated the code to include changes to [nifi-registry/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile](https://github.com/apache/nifi/blob/main/nifi-registry/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile) which is used to publish registry official image to hub.docker.com. Please help to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org