[GitHub] [fineract] galovics commented on a diff in pull request #3182: FINERACT-1905-Charges-Accrual-entries-on-created-date

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on code in PR #3182:
URL: https://github.com/apache/fineract/pull/3182#discussion_r1194160675


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -501,4 +502,19 @@ public String retrieveReportExportS3FolderName() {
         final GlobalConfigurationPropertyData property = getGlobalConfigurationPropertyData(REPORT_EXPORT_S3_FOLDER_NAME);
         return property.getStringValue();
     }
+
+    @Override
+    public String getAccrualDateConfigForCharge() {
+        String defaultValue = "due-date";
+        final GlobalConfigurationPropertyData property = getGlobalConfigurationPropertyData(CHARGE_ACCRUAL_DATE_CRITERIA);
+        if (property.isEnabled()) {

Review Comment:
   I don't think we need the enabled check here (at least judging from the other global configs). It's only used for boolean values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org