You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2016/01/14 23:28:58 UTC

[GitHub] flink pull request: [Refactor] [DataSet] Refactor key selector tra...

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1509

    [Refactor] [DataSet] Refactor key selector translation in DataSet API.

    This PR refactors the translation of `SelectorFunctionKey`s in the DataSet API. 
    
    It removes a lot of duplicate code to create key extracting mappers and key removal mappers and reformats overlong lines.
    It also cleans up most compiler warnings in the touched classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink keySelectors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1509
    
----
commit a7f512a6e7b60278b7b7b893efefaeb5d543a03b
Author: Fabian Hueske <fh...@apache.org>
Date:   2016-01-12T23:22:39Z

    [Refactor] [DataSet] Refactor key selector translation in DataSet API.
    
    Clean up several compiler warnings.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [Refactor] [DataSet] Refactor key selector tra...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1509#issuecomment-172786687
  
    Will merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [Refactor] [DataSet] Refactor key selector tra...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1509


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [Refactor] [DataSet] Refactor key selector tra...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1509#issuecomment-172501737
  
    Will merge this PR tomorrow, unless somebody objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---