You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/06 03:36:57 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request, #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
AngersZhuuuu opened a new pull request, #36462:
URL: https://github.com/apache/spark/pull/36462
### What changes were proposed in this pull request?
There are three ways to define metrics properties:
1. Default metrics properties
2. metrics.properties file under $SPARK_CONF_DIR
3. spark.metrics.conf to include a metrics properties file
4. spark.metrics.conf.xx.xx
Many new users always confused when test with metrics system, i think we can add final metrics properties in the environment tab, to let user can directly know which metrics are working.
<img width="1757" alt="截屏2022-05-06 上午11 23 04" src="https://user-images.githubusercontent.com/46485123/167062876-c0c98a69-13c7-4a25-bb31-74f1ada88153.png">
<img width="1786" alt="截屏2022-05-06 上午11 33 00" src="https://user-images.githubusercontent.com/46485123/167062893-f297eeda-b08f-4c9d-a2a2-a74add97493f.png">
### Why are the changes needed?
Make user clear about which metrics properties are working
### Does this PR introduce _any_ user-facing change?
user can see working metrics properties in UI environment tag
### How was this patch tested?
MT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
URL: https://github.com/apache/spark/pull/36462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36462:
URL: https://github.com/apache/spark/pull/36462#issuecomment-1120416911
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #36462:
URL: https://github.com/apache/spark/pull/36462#issuecomment-1119232244
ping @srowen @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36462:
URL: https://github.com/apache/spark/pull/36462#issuecomment-1119570468
It seems reasonable, though I hesitate to clutter the UI further.
How frequently would people need to check this, and how would they currently check these settings? is it that hard that it needs to be in the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #36462:
URL: https://github.com/apache/spark/pull/36462#issuecomment-1119664833
> It seems reasonable, though I hesitate to clutter the UI further. How frequently would people need to check this, and how would they currently check these settings? is it that hard that it needs to be in the UI?
When users want to develop and configure their own metrics, it may sometimes conflict with the metrics set by the admin. Not displaying these information sometimes makes troubleshooting troublesome. Viewing metrics conf usually occurs when users try to configure metrics conf and when troubleshooting.
Also this table is collapsed as default, won't clutter the UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36462: [SPARK-39110][WEBUI] Add metrics properties to environment tab
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36462:
URL: https://github.com/apache/spark/pull/36462#issuecomment-1120214607
OK seems alright, just rerun the tests maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org