You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/05/07 21:35:49 UTC
[GitHub] [trafficserver] ezelkow1 opened a new pull request #6746: Add an optional ramcache setting to volume.config to disable it
ezelkow1 opened a new pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746
This adds an additional option of `ramcache=true/false` to the volume.config.
The default is true, so enabled, to leave current functionality as is and for
the general use case. If set to false then this will stop the cache from initializing
a ramcache for that specific volume and avoid the ramcache all together. This may
be desirable for people running with volumes composed of ram disks to avoid double
ram caching and reclaim memory+time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 edited a comment on pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#issuecomment-631049065
> Looks good except a bit better naming to avoid future confusion.
Renamed all the ramcache booleans to ramcache_enabled @SolidWallOfCode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#issuecomment-631696332
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#issuecomment-631049065
> Looks good except a bit better naming to avoid future confusion.
Renamed all the ramcache booleans to ramcache_enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#discussion_r427547406
##########
File path: iocore/cache/CacheHosting.cc
##########
@@ -656,6 +656,7 @@ ConfigVolumes::BuildListFromString(char *config_file_path, char *file_buf)
CacheType scheme = CACHE_NONE_TYPE;
int size = 0;
int in_percent = 0;
+ bool ramcache = true;
Review comment:
I'd really prefer a slightly different name, to better distinguish this from "ram_cache", i.e. member that is an actual data structure and not a flag. I use the suffix "\_p" for "predicate" in such circumstances, although a prefix of "f_" is used in various places. Or "ramcache_enabled". Then you have things like
```
if (gvol[i]->cache_vol->ramcache_p) {
```
or
```
if (gvol[i]->cache_vol->ramcache_enabled) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#issuecomment-625591093
apparently vscode might remove the word 'be' when auto-prettying? that or I have some strange consistency in typos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 merged pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
ezelkow1 merged pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on a change in pull request #6746: Add an optional ramcache setting to volume.config to disable it
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on a change in pull request #6746:
URL: https://github.com/apache/trafficserver/pull/6746#discussion_r427563430
##########
File path: iocore/cache/CacheHosting.cc
##########
@@ -656,6 +656,7 @@ ConfigVolumes::BuildListFromString(char *config_file_path, char *file_buf)
CacheType scheme = CACHE_NONE_TYPE;
int size = 0;
int in_percent = 0;
+ bool ramcache = true;
Review comment:
Agreed, renamed all those to ramcache_enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org