[GitHub] [spark] huaxingao commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

[GitBox <gi...@apache.org>]

huaxingao commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams
URL: https://github.com/apache/spark/pull/26838#issuecomment-564863152
 
 
   @dongjoon-hyun @srowen @viirya Thanks for the review. 
   
   Since ```MultilayerPerceptronParams``` has ```layers```, after ```MultilayerPerceptronClassificationModel``` extends ```MultilayerPerceptronParams```, I have to rename ```layers```.  It's not good to rename ```layers``` in  ```MultilayerPerceptronParams``` because  the getter/setter are public APIs.
   
   ```MultilayerPerceptronClassificationModel``` is the only one that doesn't have the training params. All the other XXXModel extend the corresponding XXXParams. In addition, as what is said in the description of the jira https://issues.apache.org/jira/browse/SPARK-30144, user wants to have a way to track what parameters are best during a crossvalidation, so I think it makes sense to expose  ```MultilayerPerceptronParams``` to ```MultilayerPerceptronClassificationModel```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org