You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/02 01:22:22 UTC

[GitHub] [beam] rosetn commented on a change in pull request #11790: [BEAM-9926] Programming guide - Fix typos and add clearer Python text

rosetn commented on a change in pull request #11790:
URL: https://github.com/apache/beam/pull/11790#discussion_r433569849



##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -527,7 +530,7 @@ The graph of this pipeline looks like the following:
 *Figure 1: A linear pipeline with three sequential transforms.*
 
 However, note that a transform *does not consume or otherwise alter* the input
-collection--remember that a `PCollection` is immutable by definition. This means
+collection - remember that a `PCollection` is immutable by definition. This means

Review comment:
       Em dash with no spaces between words is the correct usage here: —

##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -1842,6 +1847,9 @@ transform's intermediate data changes type multiple times.
 {{< github_sample "/apache/beam/blob/master/sdks/python/apache_beam/examples/snippets/snippets.py" pipeline_monitoring_composite >}}
 {{< /highlight >}}
 
+Note that because `Count` is itself a composite transform,

Review comment:
       I'd either format this as a note (see other notes on this page) or remove "Note that"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org