You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Deepak Jaiswal <dj...@hortonworks.com> on 2018/01/03 20:25:29 UTC
Re: Review Request 64819: HIVE-18335
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64819/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 8:25 p.m.)
Review request for hive and Matt McCline.
Changes
-------
Added try catch for the errors.
Bugs: HIVE-18335
https://issues.apache.org/jira/browse/HIVE-18335
Repository: hive-git
Description
-------
VectorMapJoinFastBytesHashTable.allocateBucketArray() needs to check bounds before allocating array.
Added a unit test.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java 89087e1450
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java f610653640
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastBytesHashMap.java 905180431f
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastLongHashMap.java 315a54dde5
Diff: https://reviews.apache.org/r/64819/diff/3/
Changes: https://reviews.apache.org/r/64819/diff/2-3/
Testing
-------
Thanks,
Deepak Jaiswal
Re: Review Request 64819: HIVE-18335
Posted by Deepak Jaiswal <dj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64819/
-----------------------------------------------------------
(Updated Jan. 4, 2018, 6:36 a.m.)
Review request for hive and Matt McCline.
Changes
-------
Implemented the review suggestion.
Bugs: HIVE-18335
https://issues.apache.org/jira/browse/HIVE-18335
Repository: hive-git
Description
-------
VectorMapJoinFastBytesHashTable.allocateBucketArray() needs to check bounds before allocating array.
Added a unit test.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java 89087e1450
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java f610653640
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastBytesHashMap.java 905180431f
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastLongHashMap.java 315a54dde5
Diff: https://reviews.apache.org/r/64819/diff/4/
Changes: https://reviews.apache.org/r/64819/diff/3-4/
Testing
-------
Thanks,
Deepak Jaiswal
Re: Review Request 64819: HIVE-18335
Posted by Matt McCline <mm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64819/#review194716
-----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastBytesHashMap.java
Lines 308 (patched)
<https://reviews.apache.org/r/64819/#comment273646>
For complete checking, you could set a boolean before the try, set it int he catch block, and assert it afterwards...
- Matt McCline
On Jan. 3, 2018, 8:25 p.m., Deepak Jaiswal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64819/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2018, 8:25 p.m.)
>
>
> Review request for hive and Matt McCline.
>
>
> Bugs: HIVE-18335
> https://issues.apache.org/jira/browse/HIVE-18335
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> VectorMapJoinFastBytesHashTable.allocateBucketArray() needs to check bounds before allocating array.
>
> Added a unit test.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java 89087e1450
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java f610653640
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastBytesHashMap.java 905180431f
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastLongHashMap.java 315a54dde5
>
>
> Diff: https://reviews.apache.org/r/64819/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Jaiswal
>
>