[GitHub] [maven] rfscholte commented on a change in pull request #605: [MNG-7217] Update Commons CLI to 1.5.0

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #605:
URL: https://github.com/apache/maven/pull/605#discussion_r749294347



##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
##########
@@ -41,10 +41,13 @@ public void setup()
     public void spacedOptions()
         throws Exception
     {
-        CommandLine cmdLine = cliManager.parse( "-X -Dx=1 -D y=2 test".split( " " ) );
+        CommandLine cmdLine = cliManager.parse( "-X -Dx=1 -D y=2 -Dz test".split( " " ) );

Review comment:
       My opinion is that we shouldn't try to match a Maven User Property with the Java System Property, they both have their own characteristics. 
   You already defined the set of differences, so I would prefer to see this fixed in commons-cli (and it would probably make it possible to keep `--define`)
   With Maven the space has always been optional after any flag, I prefer to stay consistent for all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org