You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2017/06/29 22:40:34 UTC

logging-log4j2 git commit: Add @SuppressWarnings.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master 70677348c -> 73d17a99e


Add @SuppressWarnings.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/73d17a99
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/73d17a99
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/73d17a99

Branch: refs/heads/master
Commit: 73d17a99e78f211003965e8013ca97919185e500
Parents: 7067734
Author: Gary Gregory <gg...@apache.org>
Authored: Thu Jun 29 15:40:30 2017 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Thu Jun 29 15:40:30 2017 -0700

----------------------------------------------------------------------
 .../java/org/apache/logging/log4j/core/net/TcpSocketManager.java   | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/73d17a99/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
index 8374ff9..da78eee 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
@@ -202,6 +202,7 @@ public class TcpSocketManager extends AbstractSocketManager {
                 connectTimeoutMillis, reconnectDelayMillis, immediateFail, layout, bufferSize, socketOptions), FACTORY);
     }
 
+    @SuppressWarnings("sync-override") // synchronization on "this" is done within the method 
     @Override
     protected void write(final byte[] bytes, final int offset, final int length, final boolean immediateFlush) {
         if (socket == null) {
@@ -215,6 +216,7 @@ public class TcpSocketManager extends AbstractSocketManager {
         }
         synchronized (this) {
             try {
+                @SuppressWarnings("resource") // outputStream is managed by this class 
                 final OutputStream outputStream = getOutputStream();
                 outputStream.write(bytes, offset, length);
                 if (immediateFlush) {