You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/09 10:05:52 UTC
[jira] [Commented] (HIVE-2562) HIVE-2247 Changed the Thrift API
causing compatibility issues.
[ https://issues.apache.org/jira/browse/HIVE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146869#comment-13146869 ]
jiraposter@reviews.apache.org commented on HIVE-2562:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------
(Updated 2011-11-09 09:04:42.416457)
Review request for hive, Siying Dong and Kevin Wilfong.
Changes
-------
I thought this patch is going to fix the bug in HIVE-2247, so I should put HIVE-2247 in the bugs field...It seems it is not like what I think.
Summary (updated)
-------
keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null
Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
This addresses bug HIVE-2562.
https://issues.apache.org/jira/browse/HIVE-2562
Diffs
-----
trunk/metastore/if/hive_metastore.thrift 1199598
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598
trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598
Diff: https://reviews.apache.org/r/2783/diff
Testing
-------
Thanks,
Weiyan
> HIVE-2247 Changed the Thrift API causing compatibility issues.
> --------------------------------------------------------------
>
> Key: HIVE-2562
> URL: https://issues.apache.org/jira/browse/HIVE-2562
> Project: Hive
> Issue Type: Bug
> Reporter: Kevin Wilfong
> Assignee: Weiyan Wang
> Attachments: HIVE-2562.patch
>
>
> HIVE-2247 Added a parameter to alter_partition in the Metastore Thrift API which has been causing compatibility issues with some scripts. We would like to change this to have two methods, one called alter_partition which takes the old parameters, and one called something else (I'll leave the naming up to you) which has the new parameters. The implementation of the old method should just call the new method with null for the new parameter.
> This will fix the compatibility issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira