You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/12/19 23:23:50 UTC

[GitHub] incubator-brooklyn pull request: Fix cassandra on aws

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1117

    Fix cassandra on aws

    And some other minor improvements as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/cassandra-on-aws

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1117
    
----
commit 70ed0e1e965f284dc84fbe3c1b107071791bdde6
Author: Aled Sage <al...@gmail.com>
Date:   2015-12-19T19:50:41Z

    Use Sanitiser.sanitize when logging

commit 590bf741d3c4472542e5713e706ae4bdd2192ddd
Author: Aled Sage <al...@gmail.com>
Date:   2015-12-19T19:51:15Z

    MachineEntity.exec: better NPE if no driver

commit 09f1cdf90c590d0c473d2759dbbb255b37f52788
Author: Aled Sage <al...@gmail.com>
Date:   2015-12-19T20:00:04Z

    Fix jclouds machine subnetHostname
    
    - Fix JcloudsSshMachineLocation.getHostname(): delegate to
      jcloudLocation.getPublicHostname()
    - Fix JcloudsSshMachineLocation.getSubnetHostname(): delegate to
      jcloudsLocatoin.getPrivateHostname()
    - Persist JcloudsSshMachineLocation.privateHostname
    - Adds SshMachineLocation.tryGetPrivateKeyData()
      (extracted from SshMachineLocation.findKeyPair())
    
    Without this fix, single-node Cassandra fails:
    * In AWS it got the public IP for the seed (which could not be reached
      from the VM itself).
    * In vcloud-director it got the VM’s hostname (which is a random badly
      confirmed name that is not reachable from the VM itself)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix cassandra on aws

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix cassandra on aws

Posted by iyovcheva <gi...@git.apache.org>.

Github user iyovcheva commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1117#issuecomment-166151800
  
    Looks good, small comment only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix cassandra on aws

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1117#issuecomment-166278836
  
    good spot @iyovcheva .  i'll fix that and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---