[GitHub] [arrow-datafusion] Rachelint commented on a diff in pull request #3056: feat: support double quoted literal strings for dialects(such as mysql,bigquery)

[GitBox <gi...@apache.org>]

Rachelint commented on code in PR #3056:
URL: https://github.com/apache/arrow-datafusion/pull/3056#discussion_r939666227


##########
datafusion/sql/src/planner.rs:
##########
@@ -4849,6 +4864,24 @@ mod tests {
         quick_test(sql, expected);
     }
 
+    #[test]
+    fn test_double_quoted_literal_string() {
+        // Assert double quoted literal string is parsed correctly like single quoted one in specific dialect.
+        let dialect = &MySqlDialect {};

Review Comment:
   > Thanks for adding this test. Could you also add one showing that behavior hasn't changed when using the default dialect?
   
   Ok, I add such test soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org