[GitHub] storm pull request: STORM-1187 Support windowing based on tuple ts

[rfarivar <gi...@git.apache.org>]

Github user rfarivar commented on a diff in the pull request:

    https://github.com/apache/storm/pull/900#discussion_r46704537
  
    --- Diff: storm-core/src/jvm/backtype/storm/windowing/TimeEvictionPolicy.java ---
    @@ -21,21 +21,30 @@
      * Eviction policy that evicts events based on time duration.
      */
     public class TimeEvictionPolicy<T> implements EvictionPolicy<T> {
    -    private final long duration;
    +    private final int windowLength;
    +    protected Long currentTs;
    --- End diff --
    
    What does currentTs represent? May I suggest renaming to something more representative?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---