You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mmorel-35 (via GitHub)" <gi...@apache.org> on 2025/08/17 21:29:43 UTC
[PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
mmorel-35 opened a new pull request, #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114
#### Description
This pull request updates Bazel build configuration to use newer versions of dependencies and improves the way external repositories are loaded. The main changes include upgrading `grpc`, `protobuf`, and `rules_proto`, updating repository loading logic to avoid redundant downloads, and adjusting build files to use the updated dependency structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "wbpcode (via GitHub)" <gi...@apache.org>.
wbpcode commented on code in PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114#discussion_r2345909577
##########
MODULE.bazel:
##########
@@ -0,0 +1,9 @@
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "0.0.0-dev",
Review Comment:
Is the version reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "wbpcode (via GitHub)" <gi...@apache.org>.
wbpcode commented on PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114#issuecomment-3288441515
> Notice, I applied buildifer on bazel files
I saw it. That's fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "mmorel-35 (via GitHub)" <gi...@apache.org>.
mmorel-35 commented on code in PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114#discussion_r2346200415
##########
MODULE.bazel:
##########
@@ -0,0 +1,9 @@
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "0.0.0-dev",
Review Comment:
That's the usual when not yet defined.
I changed it to 10.2.1-dev
After the module is integrated, it needs a workflow to publish to bcr : https://github.com/bazel-contrib/publish-to-bcr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114#issuecomment-3194945585
@wbpcode This should be mostly around C++ SDK build. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "mmorel-35 (via GitHub)" <gi...@apache.org>.
mmorel-35 commented on PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114#issuecomment-3287903797
Notice, I applied buildifer on bazell files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update Bazel configuration and dependencies [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #114:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org