You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:39:41 UTC

[GitHub] [shenyu] yunlongn commented on a diff in pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable

yunlongn commented on code in PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#discussion_r990949519


##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-instance/src/main/java/org/apache/shenyu/springboot/starter/instance/ShenyuInstanceConfiguration.java:
##########
@@ -39,4 +41,19 @@ public class ShenyuInstanceConfiguration {
     public InstanceRegisterListener instanceRegisterListener(final ShenyuConfig config) {
         return new InstanceRegisterListener(config.getInstance());
     }
+
+    /**
+     * ShenYu Instance Register Repository.
+     * expose to shenYu-sdk.
+     *
+     * @param config the config
+     * @return ShenYu Instance Register Repository
+     */
+    @Bean
+    @ConditionalOnProperty(name = "shenyu.instance.clientEnable", havingValue = "true")

Review Comment:
   InstanceRegisterListener will register the service to the registry, shenyu-sdk does not need this operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org