You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kr...@apache.org on 2015/11/19 08:02:11 UTC

svn commit: r1715113 - /maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java

Author: krosenvold
Date: Thu Nov 19 07:02:11 2015
New Revision: 1715113

URL: http://svn.apache.org/viewvc?rev=1715113&view=rev
Log:
Fixed testcase file handle leak

Modified:
    maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java

Modified: maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java?rev=1715113&r1=1715112&r2=1715113&view=diff
==============================================================================
--- maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java (original)
+++ maven/plugins/trunk/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ComponentsXmlResourceTransformerTest.java Thu Nov 19 07:02:11 2015
@@ -60,11 +60,13 @@ public class ComponentsXmlResourceTransf
         transformer.processResource( "components-1.xml", resourceAsStream1,
                                      Collections.<Relocator> emptyList() );
         resourceAsStream1.close();
+        final InputStream resourceAsStream2 = getClass().getResourceAsStream( "/components-expected.xml" );
         Diff diff = XMLUnit.compareXML(
-            IOUtil.toString( getClass().getResourceAsStream( "/components-expected.xml" ), "UTF-8" ),
+            IOUtil.toString( resourceAsStream2, "UTF-8" ),
             IOUtil.toString( transformer.getTransformedResource(), "UTF-8" ) );
         //assertEquals( IOUtil.toString( getClass().getResourceAsStream( "/components-expected.xml" ), "UTF-8" ),
         //              IOUtil.toString( transformer.getTransformedResource(), "UTF-8" ).replaceAll("\r\n", "\n") );
+        resourceAsStream2.close();
         XMLAssert.assertXMLIdentical( diff, true );
     }
 }
\ No newline at end of file