You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/12/07 07:55:28 UTC
[GitHub] [drill] pjfanning opened a new pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
pjfanning opened a new pull request #2396:
URL: https://github.com/apache/drill/pull/2396
# [DRILL-8069](https://issues.apache.org/jira/browse/DRILL-8069): remove use of excel sheet getLastRowNum
## Description
It is not guaranteed that getLastRowNum will return the right data - it depends on dimension data that excel saves in the sheet XML but it seems increasingly common for this to be omitted
## Documentation
None
## Testing
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2396:
URL: https://github.com/apache/drill/pull/2396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] pjfanning commented on pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #2396:
URL: https://github.com/apache/drill/pull/2396#issuecomment-988141665
@cgivre it passed for me locally and also now in the automated build - I plan to make another edit though, I just want to upgrade excel-streaming-reader version because of a bug that was found (https://github.com/pjfanning/excel-streaming-reader/issues/80 - I have a release that disables this new feature by default, a feature that drill doesn't need)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #2396:
URL: https://github.com/apache/drill/pull/2396#discussion_r764507669
##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -154,7 +154,7 @@ public String getFieldName() {
private int totalColumnCount;
private boolean firstLine;
private FileSplit split;
- private int recordCount;
+ private int recordCount = 0;
Review comment:
I don't think this is actually necessary since an undefined `int` will be `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] pjfanning commented on pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #2396:
URL: https://github.com/apache/drill/pull/2396#issuecomment-987951563
@cgivre I was having trouble getting the drill build to work on my laptop but the latest changes are tested locally. Could you try this change with your test file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2396: DRILL-8069: remove use of excel sheet getLastRowNum
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2396:
URL: https://github.com/apache/drill/pull/2396#issuecomment-987998199
@pjfanning Thanks for your quick response on this! Did the unit tests succeed on your local machine? I'll try to build today or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org