You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/06/15 02:09:33 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #6027: [Feature] Export data supports parquet format
xinghuayu007 opened a new pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027
## Proposed changes
Currently, Doris only supports export data with CSV format. This PR extends the feature to support parquet format.
Usage:
for export to local file:
`export table table2 to "file:///root/doris/" properties ("format"="parquet", "schema"="required, int64, date; required, int32, siteid; required, int32, citycode; required, byte_array, username; required, int64, pv;", "parquet.version"="v2");`
If `format` is `parquet`, then `schema` is required
for export to remote file:
`export table table2 to "hdfs://host/test_sql_prc_2019_02_19/" PROPERTIES ("schema"="required,int32,siteid;required,byte_array,varchar_test", "schema"="required, int64, date; required, int32, siteid; required, int32, citycode; required, byte_array, username; required, int64, pv;", "parquet.version"="v2") with broker hdfs_broker ("hadoop.security.authentication" = "kerberos", "kerberos_principal" = "account", "kerberos_keytab_content" = "base64");`
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #6027: [Feature] Export data supports parquet format
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r666985653
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##########
@@ -95,6 +95,7 @@
public static final String KEY_IN_PARAM_LINE_DELIMITER = "line_delimiter";
public static final String KEY_IN_PARAM_PARTITIONS = "partitions";
public static final String KEY_IN_PARAM_FORMAT_TYPE = "format";
+ public static final String KEY_IN_PARAM_FILE_PROPERTIES = "file_properties";
Review comment:
deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #6027: [Feature] Export data supports parquet format
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r666986659
##########
File path: gensrc/thrift/DataSinks.thrift
##########
@@ -114,7 +114,10 @@ struct TExportSink {
4: required string line_delimiter
// properties need to access broker.
5: optional list<Types.TNetworkAddress> broker_addresses
- 6: optional map<string, string> properties;
+ 6: optional map<string, string> properties
+ 7: optional list<list<string>> schema
+ 8: optional map<string, string> file_properties
Review comment:
file_properties is used to represent parquet file properties, like version, compression and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6027: [Feature] Export data supports parquet format
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r659895133
##########
File path: gensrc/thrift/DataSinks.thrift
##########
@@ -114,7 +114,10 @@ struct TExportSink {
4: required string line_delimiter
// properties need to access broker.
5: optional list<Types.TNetworkAddress> broker_addresses
- 6: optional map<string, string> properties;
+ 6: optional map<string, string> properties
+ 7: optional list<list<string>> schema
+ 8: optional map<string, string> file_properties
Review comment:
`file_properties` not used?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##########
@@ -95,6 +95,7 @@
public static final String KEY_IN_PARAM_LINE_DELIMITER = "line_delimiter";
public static final String KEY_IN_PARAM_PARTITIONS = "partitions";
public static final String KEY_IN_PARAM_FORMAT_TYPE = "format";
+ public static final String KEY_IN_PARAM_FILE_PROPERTIES = "file_properties";
Review comment:
Seems useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6027: [Feature] Export data supports parquet format
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r659895133
##########
File path: gensrc/thrift/DataSinks.thrift
##########
@@ -114,7 +114,10 @@ struct TExportSink {
4: required string line_delimiter
// properties need to access broker.
5: optional list<Types.TNetworkAddress> broker_addresses
- 6: optional map<string, string> properties;
+ 6: optional map<string, string> properties
+ 7: optional list<list<string>> schema
+ 8: optional map<string, string> file_properties
Review comment:
`file_properties` not used?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##########
@@ -95,6 +95,7 @@
public static final String KEY_IN_PARAM_LINE_DELIMITER = "line_delimiter";
public static final String KEY_IN_PARAM_PARTITIONS = "partitions";
public static final String KEY_IN_PARAM_FORMAT_TYPE = "format";
+ public static final String KEY_IN_PARAM_FILE_PROPERTIES = "file_properties";
Review comment:
Seems useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org