[jira] Commented: (OFBIZ-2618) double forward slashes in ecommerce emails

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751894#action_12751894 ] 

Jacques Le Roux commented on OFBIZ-2618:
----------------------------------------

HI Bj,

I can't commit your patch as is. At least 2 reasons
# Please don't add the following lines in the header
{code}
### Eclipse Workspace Patch 1.0
#P ofbiz_09_04
{code}
For this in the create patch wizard choose your project and not the workspace
# Don't cut your lines since this generate conflicts when paching (in Eclipse at least), example
{code}
+                <property-map resource="EcommerceUiLabels" map-name="uiLabelMap"
+                    global="true"/>
{code}
should be 
{code}
+                <property-map resource="EcommerceUiLabels" map-name="uiLabelMap" global="true"/>
{code}

Thanks


> double forward slashes in ecommerce emails
> ------------------------------------------
>
>                 Key: OFBIZ-2618
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2618
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: Ofbiz_2618_ecommerceEmail.patch
>
>
> in the widets 
>                 <set field="baseEcommerceSecureUrl"
>                     value="${baseSecureUrl}/ecommerce/control/"/>
> has a trailing forward slash
> then the added url has a leading forward slash
> /orderstatus?orderId=
> so you get
> /ecommerce/control//orderstatus?orderId=
> removed the trailing forward slash

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.