You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2007/09/18 16:56:56 UTC
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
nice !
-Matthias
On 9/17/07, slessard@apache.org <sl...@apache.org> wrote:
> Author: slessard
> Date: Mon Sep 17 13:16:35 2007
> New Revision: 576576
>
> URL: http://svn.apache.org/viewvc?rev=576576&view=rev
> Log:
> TRINIDAD-717 Added facets "ready" and "busy" to statusIndicator component.
>
> Added:
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimal-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIE-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIERtl-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalInacc-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalPPC-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalSaf-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalScrRdr-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/testScripts/statusIndicator-facet.xml
> Modified:
> myfaces/trinidad/trunk/trinidad/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/CoreStatusIndicator.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StatusIndicatorRenderer.java
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimal-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIE-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIERtl-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalInacc-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalPPC-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalSaf-golden.xml
> myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalScrRdr-golden.xml
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/CoreStatusIndicator.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/CoreStatusIndicator.xml?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/CoreStatusIndicator.xml (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/CoreStatusIndicator.xml Mon Sep 17 13:16:35 2007
> @@ -1,58 +1,71 @@
> -<?xml version="1.0" encoding="utf-8"?>
> -<!--
> - Licensed to the Apache Software Foundation (ASF) under one
> - or more contributor license agreements. See the NOTICE file
> - distributed with this work for additional information
> - regarding copyright ownership. The ASF licenses this file
> - to you under the Apache License, Version 2.0 (the
> - "License"); you may not use this file except in compliance
> - with the License. You may obtain a copy of the License at
> -
> - http://www.apache.org/licenses/LICENSE-2.0
> -
> - Unless required by applicable law or agreed to in writing,
> - software distributed under the License is distributed on an
> - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> - KIND, either express or implied. See the License for the
> - specific language governing permissions and limitations
> - under the License.
> -
> --->
> -<faces-config version="1.2" xmlns="http://java.sun.com/xml/ns/javaee"
> - xmlns:tr="http://myfaces.apache.org/trinidad"
> - xmlns:xi="http://www.w3.org/2001/XInclude"
> - xmlns:mfp="http://myfaces.apache.org/maven-faces-plugin"
> - xmlns:xhtml="http://www.w3.org/1999/xhtml">
> - <component>
> - <description><![CDATA[The statusIndicator component shows whether the page is busy processing or is ready.]]></description>
> - <icon>
> - <small-icon>/org/apache/myfaces/trinidad/metadata/icons/statusIndicator.png</small-icon>
> - </icon>
> - <component-type>org.apache.myfaces.trinidad.CoreStatusIndicator</component-type>
> - <component-class>org.apache.myfaces.trinidad.component.core.output.CoreStatusIndicator</component-class>
> -
> - <xi:include href="includes/CommonAttrs.xml" xpointer="/faces-config/component/*"/>
> - <xi:include href="includes/CoreJSEvents.xml" xpointer="/faces-config/component/*"/>
> -
> -
> - <component-extension>
> - <mfp:component-supertype>org.apache.myfaces.trinidad.Object</mfp:component-supertype>
> - <mfp:renderer-type>org.apache.myfaces.trinidad.StatusIndicator</mfp:renderer-type>
> - <mfp:tag-name>tr:statusIndicator</mfp:tag-name>
> - <mfp:tag-class>org.apache.myfaces.trinidadinternal.taglib.core.output.CoreStatusIndicatorTag</mfp:tag-class>
> - <mfp:long-description><![CDATA[<html:p>
> - The The statusIndicator component shows whether the page is
> -busy processing or is ready.
> - </html:p>]]>
> - </mfp:long-description>
> - <mfp:example>
> - <mfp:source-code><tr:statusIndicator/></mfp:source-code>
> - </mfp:example>
> - <mfp:author>Adam Winer</mfp:author>
> - <mfp:component-metadata>
> - <mfp:accepts-child-components>false</mfp:accepts-child-components>
> - <mfp:group>${md:getTranslatedString("PALETTE_OUTPUT")}</mfp:group>
> - </mfp:component-metadata>
> - </component-extension>
> - </component>
> -</faces-config>
> +<?xml version="1.0" encoding="utf-8"?>
> +<!--
> + Licensed to the Apache Software Foundation (ASF) under one
> + or more contributor license agreements. See the NOTICE file
> + distributed with this work for additional information
> + regarding copyright ownership. The ASF licenses this file
> + to you under the Apache License, Version 2.0 (the
> + "License"); you may not use this file except in compliance
> + with the License. You may obtain a copy of the License at
> +
> + http://www.apache.org/licenses/LICENSE-2.0
> +
> + Unless required by applicable law or agreed to in writing,
> + software distributed under the License is distributed on an
> + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + KIND, either express or implied. See the License for the
> + specific language governing permissions and limitations
> + under the License.
> +
> +-->
> +<faces-config version="1.2" xmlns="http://java.sun.com/xml/ns/javaee"
> + xmlns:tr="http://myfaces.apache.org/trinidad"
> + xmlns:xi="http://www.w3.org/2001/XInclude"
> + xmlns:mfp="http://myfaces.apache.org/maven-faces-plugin"
> + xmlns:xhtml="http://www.w3.org/1999/xhtml">
> + <component>
> + <description><![CDATA[The statusIndicator component shows whether the page is busy processing or is ready.]]></description>
> + <icon>
> + <small-icon>/org/apache/myfaces/trinidad/metadata/icons/statusIndicator.png</small-icon>
> + </icon>
> + <component-type>org.apache.myfaces.trinidad.CoreStatusIndicator</component-type>
> + <component-class>org.apache.myfaces.trinidad.component.core.output.CoreStatusIndicator</component-class>
> +
> + <facet>
> + <description><![CDATA[Content to be rendered when the page is ready.]]></description>
> + <facet-name>ready</facet-name>
> + </facet>
> + <facet>
> + <description><![CDATA[Content to be rendered when the page is busy processing.]]></description>
> + <facet-name>busy</facet-name>
> + </facet>
> +
> + <xi:include href="includes/CommonAttrs.xml" xpointer="/faces-config/component/*"/>
> + <xi:include href="includes/CoreJSEvents.xml" xpointer="/faces-config/component/*"/>
> +
> +
> + <component-extension>
> + <mfp:component-supertype>org.apache.myfaces.trinidad.Object</mfp:component-supertype>
> + <mfp:renderer-type>org.apache.myfaces.trinidad.StatusIndicator</mfp:renderer-type>
> + <mfp:tag-name>tr:statusIndicator</mfp:tag-name>
> + <mfp:tag-class>org.apache.myfaces.trinidadinternal.taglib.core.output.CoreStatusIndicatorTag</mfp:tag-class>
> + <mfp:long-description><![CDATA[<html:p>
> + The The statusIndicator component shows whether the page is
> +busy processing or is ready.
> + </html:p>]]>
> + </mfp:long-description>
> + <mfp:example>
> + <mfp:source-code>
> + <tr:statusIndicator>
> + <tr:outputText value="Loading, please wait...">
> + </tr:statusIndicator>
> + </mfp:source-code>
> + </mfp:example>
> + <mfp:author>Adam Winer</mfp:author>
> + <mfp:component-metadata>
> + <mfp:accepts-child-components>false</mfp:accepts-child-components>
> + <mfp:group>${md:getTranslatedString("PALETTE_OUTPUT")}</mfp:group>
> + </mfp:component-metadata>
> + </component-extension>
> + </component>
> +</faces-config>
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java Mon Sep 17 13:16:35 2007
> @@ -1236,6 +1236,10 @@
> // //
> public static final String AF_STATUS_INDICATOR_STYLE =
> "af|statusIndicator";
> + public static final String AF_STATUS_INDICATOR_BUSY_STYLE =
> + "af|statusIndicator::busy";
> + public static final String AF_STATUS_INDICATOR_READY_STYLE =
> + "af|statusIndicator::ready";
>
> // ================================ Icons ================================ //
> public static final String AF_STATUS_INDICATOR_BUSY_ICON =
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StatusIndicatorRenderer.java
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StatusIndicatorRenderer.java?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StatusIndicatorRenderer.java (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/StatusIndicatorRenderer.java Mon Sep 17 13:16:35 2007
> @@ -19,7 +19,7 @@
> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
>
> import java.io.IOException;
> -
> +import java.util.Collections;
> import java.util.Map;
>
> import javax.faces.component.UIComponent;
> @@ -27,11 +27,7 @@
> import javax.faces.context.ResponseWriter;
>
> import org.apache.myfaces.trinidad.bean.FacesBean;
> -import org.apache.myfaces.trinidad.bean.PropertyKey;
> import org.apache.myfaces.trinidad.component.core.output.CoreStatusIndicator;
> -import org.apache.myfaces.trinidad.logging.TrinidadLogger;
> -import org.apache.myfaces.trinidad.util.ArrayMap;
> -
> import org.apache.myfaces.trinidad.context.RenderingContext;
> import org.apache.myfaces.trinidad.skin.Icon;
>
> @@ -44,77 +40,104 @@
>
> @Override
> protected void encodeBegin(
> - FacesContext context,
> - RenderingContext rc,
> - UIComponent comp,
> - FacesBean bean) throws IOException
> + FacesContext context,
> + RenderingContext rc,
> + UIComponent comp,
> + FacesBean bean) throws IOException
> {
> - Icon busyIcon = rc.getIcon(SkinSelectors.AF_STATUS_INDICATOR_BUSY_ICON);
> - Icon readyIcon = rc.getIcon(SkinSelectors.AF_STATUS_INDICATOR_READY_ICON);
> -
> - if (busyIcon == null || readyIcon == null)
> - {
> - _LOG.warning("STATUS_INDICATOR_MISSING_ICONS");
> - return;
> - }
> -
> ResponseWriter rw = context.getResponseWriter();
>
> - rw.startElement("span", comp);
> + String clientId = getClientId(context, comp);
> +
> + rw.startElement(XhtmlConstants.SPAN_ELEMENT, comp);
> renderId(context, comp);
> renderAllAttributes(context, rc, bean);
> - String clientId = getClientId(context, comp);
> -
> - Map<String, Object> attrs = new ArrayMap<String, Object>(3);
> -
> - attrs.put(Icon.ID_KEY, clientId + "::ready");
> - attrs.put(Icon.SHORT_DESC_KEY,
> - rc.getTranslatedString("af_statusIndicator.READY"));
> - readyIcon.renderIcon(context, rc, attrs);
> -
> - attrs.put(Icon.INLINE_STYLE_KEY, "display:none");
> - attrs.put(Icon.ID_KEY, clientId + "::busy");
> - attrs.put(Icon.SHORT_DESC_KEY,
> - rc.getTranslatedString("af_statusIndicator.BUSY"));
> - busyIcon.renderIcon(context, rc, attrs);
> -
> + rw.startElement(XhtmlConstants.SPAN_ELEMENT, null);
> + rw.writeAttribute(XhtmlConstants.ID_ATTRIBUTE, clientId + "::ready", null);
> + renderReadyContent(context, rc, comp, bean);
> + rw.endElement(XhtmlConstants.SPAN_ELEMENT);
>
> - rw.startElement("script", null);
> + rw.startElement(XhtmlConstants.SPAN_ELEMENT, null);
> + rw.writeAttribute(XhtmlConstants.ID_ATTRIBUTE, clientId + "::busy", null);
> + rw.writeAttribute(XhtmlConstants.STYLE_ATTRIBUTE, "display:none", null);
> + renderBusyContent(context, rc, comp, bean);
> + rw.endElement(XhtmlConstants.SPAN_ELEMENT);
> +
> + rw.startElement(XhtmlConstants.SCRIPT_ELEMENT, null);
> renderScriptTypeAttribute(context, rc);
> + rw.writeText("TrStatusIndicator._register(\"" + clientId + "\");", null);
> + rw.endElement(XhtmlConstants.SCRIPT_ELEMENT);
>
> - rw.writeText("TrStatusIndicator._register(\"", null);
> - rw.writeText(clientId, null);
> - rw.writeText("\");", null);
> -
> - rw.endElement("script");
> -
> - rw.endElement("span");
> + rw.endElement(XhtmlConstants.SPAN_ELEMENT);
> }
>
> + @Override
> protected String getDefaultStyleClass(FacesBean bean)
> {
> return SkinSelectors.AF_STATUS_INDICATOR_STYLE;
> }
> -
> - private Map<String, Object> _getNodeAttributeMap(
> - FacesContext context,
> - UIComponent comp,
> - FacesBean bean,
> - boolean embed)
> +
> + protected void renderBusyContent(
> + FacesContext context,
> + RenderingContext rc,
> + UIComponent comp,
> + FacesBean bean) throws IOException
> {
> - Map<String, Object> attrs = null;
> - attrs = new ArrayMap<String, Object>(1);
> -
> - attrs.put(Icon.STYLE_CLASS_KEY, getStyleClass(bean));
> - attrs.put(Icon.ID_KEY, getClientId(context, comp));
> -
> - return attrs;
> + renderDefaultContent(context,
> + rc,
> + comp,
> + SkinSelectors.AF_STATUS_INDICATOR_BUSY_ICON,
> + "af_statusIndicator.BUSY",
> + "busy",
> + SkinSelectors.AF_STATUS_INDICATOR_BUSY_STYLE);
> }
> +
> + protected void renderReadyContent(
> + FacesContext context,
> + RenderingContext rc,
> + UIComponent comp,
> + FacesBean bean) throws IOException
> + {
> + renderDefaultContent(context,
> + rc,
> + comp,
> + SkinSelectors.AF_STATUS_INDICATOR_READY_ICON,
> + "af_statusIndicator.READY",
> + "ready",
> + SkinSelectors.AF_STATUS_INDICATOR_READY_STYLE);
> + }
> +
> + private void renderDefaultContent(
> + FacesContext context,
> + RenderingContext rc,
> + UIComponent comp,
> + String iconName,
> + String iconDesc,
> + String facetName,
> + String facetStyleClass) throws IOException
> + {
>
> - private PropertyKey _nameKey;
> -
> - private static String _ICON_NAME_PREFIX = "AF";
> - private static String _ICON_NAME_SUFFIX = "Icon";
> + ResponseWriter rw = context.getResponseWriter();
>
> - private static final TrinidadLogger _LOG = TrinidadLogger.createTrinidadLogger(StatusIndicatorRenderer.class);
> + // Render the icon
> + Icon icon = rc.getIcon(iconName);
> + if (icon != null && !icon.isNull())
> + {
> + Map<String, String> attrs =
> + Collections.singletonMap(Icon.SHORT_DESC_KEY,
> + rc.getTranslatedString(iconDesc));
> +
> + icon.renderIcon(context, rc, attrs);
> + }
> +
> + // Render the facet
> + UIComponent facet = getFacet(comp, facetName);
> + if (facet != null)
> + {
> + rw.startElement(XhtmlConstants.SPAN_ELEMENT, null);
> + renderStyleClass(context, rc, facetStyleClass);
> + encodeChild(context, facet);
> + rw.endElement(XhtmlConstants.SPAN_ELEMENT);
> + }
> + }
> }
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss Mon Sep 17 13:16:35 2007
> @@ -3066,6 +3066,10 @@
>
> <style selector="af|statusIndicator"/>
>
> + <style selector="af|statusIndicator::busy"/>
> +
> + <style selector="af|statusIndicator::ready"/>
> +
> <!--
> Private ContentFooter Styles: Not sure whether any of these
> styles need to be exposed, but if so, they need to be renamed
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimal-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimal-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimal-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimal-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,54 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIE-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIE-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIE-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIE-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,52 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIERtl-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIERtl-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIERtl-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalIERtl-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,52 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalInacc-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalInacc-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalInacc-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalInacc-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,51 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalPPC-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalPPC-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalPPC-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalPPC-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,54 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalSaf-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalSaf-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalSaf-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalSaf-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,54 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Added: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalScrRdr-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalScrRdr-golden.xml?rev=576576&view=auto
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalScrRdr-golden.xml (added)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-facet-minimalScrRdr-golden.xml Mon Sep 17 13:16:35 2007
> @@ -0,0 +1,54 @@
> +<results>
> + <span
> + class="af_statusIndicator"
> + id="mainId"
> + >
> +
> + <span
> + id="mainId::ready"
> + >
> +
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_ready"
> + >
> + The page is ready
> + </span>
> + </span>
> + <span
> + id="mainId::busy"
> + style="display:none"
> + >
> +
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + <span
> + class="af_statusIndicator_busy"
> + >
> + The page is busy
> + </span>
> + </span>
> + <script
> + type="text/javascript"
> + >
> + TrStatusIndicator._register("mainId");
> + </script>
> + </span>
> +</results>
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimal-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimal-golden.xml?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimal-golden.xml (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimal-golden.xml Mon Sep 17 13:16:35 2007
> @@ -4,29 +4,37 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -40,29 +48,37 @@
> id="test-id"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="test-id::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="test-id::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -77,29 +93,37 @@
> style="test-inlineStyle"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -115,29 +139,37 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -152,29 +184,37 @@
> title="test-shortDesc"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -188,29 +228,37 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -225,29 +273,37 @@
> onclick="test-onclick"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -262,29 +318,37 @@
> ondblclick="test-ondblclick"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -299,29 +363,37 @@
> onkeydown="test-onkeydown"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -336,29 +408,37 @@
> onkeypress="test-onkeypress"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -373,29 +453,37 @@
> onkeyup="test-onkeyup"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -410,29 +498,37 @@
> onmousedown="test-onmousedown"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -447,29 +543,37 @@
> onmousemove="test-onmousemove"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -484,29 +588,37 @@
> onmouseout="test-onmouseout"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -521,29 +633,37 @@
> onmouseover="test-onmouseover"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -558,29 +678,37 @@
> onmouseup="test-onmouseup"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - title="Page is ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + title="Page is ready"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - title="Page is busy processing"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + title="Page is busy processing"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
>
> Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIE-golden.xml
> URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIE-golden.xml?rev=576576&r1=576575&r2=576576&view=diff
> ==============================================================================
> --- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIE-golden.xml (original)
> +++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/statusIndicator-minimalIE-golden.xml Mon Sep 17 13:16:35 2007
> @@ -4,27 +4,35 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -38,27 +46,35 @@
> id="test-id"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="test-id::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="test-id::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -73,27 +89,35 @@
> style="test-inlineStyle"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -109,27 +133,35 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -144,27 +176,35 @@
> title="test-shortDesc"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -178,27 +218,35 @@
> id="mainId"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -213,27 +261,35 @@
> onclick="test-onclick"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -248,27 +304,35 @@
> ondblclick="test-ondblclick"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -283,27 +347,35 @@
> onkeydown="test-onkeydown"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -318,27 +390,35 @@
> onkeypress="test-onkeypress"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -353,27 +433,35 @@
> onkeyup="test-onkeyup"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -388,27 +476,35 @@
> onmousedown="test-onmousedown"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -423,27 +519,35 @@
> onmousemove="test-onmousemove"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -458,27 +562,35 @@
> onmouseout="test-onmouseout"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -493,27 +605,35 @@
> onmouseover="test-onmouseover"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
> @@ -528,27 +648,35 @@
> onmouseup="test-onmouseup"
> >
>
> - <img
> - alt="Page is ready"
> - border="0"
> - height="16"
> + <span
> id="mainId::ready"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> >
>
> - </img>
> - <img
> - alt="Page is busy processing"
> - border="0"
> - height="16"
> + <img
> + alt="Page is ready"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/siready.gif"
> + >
> +
> + </img>
> + </span>
> + <span
> id="mainId::busy"
> style="display:none"
> - width="16"
> - src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> >
>
> - </img>
> + <img
> + alt="Page is busy processing"
> + border="0"
> + height="16"
> + width="16"
> + src="uri-attr:encoded-resource-url:/test-context-path/adf/images/sibusy.gif"
> + >
> +
> + </img>
> + </span>
> <script
> type="text/javascript"
> >
>
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
On the vote for set a facet = no icons, someone could easily:
<tr:statusIndicator>
<f:facet name="busy"><tr:outputText value="busy"/></f:facet>
<f:facet name="read"><tr:icon name="..." /></f:facet>
</tr:statusIndicator>
This way they can sill use the icon. Just requires more typing
On 9/19/07, Adam Winer <aw...@gmail.com> wrote:
> On 9/19/07, Perkins, Nate-P63196 <Na...@gdc4s.com> wrote:
> > Yes, but why pollute the page unnecessarily with an empty outputText?
>
> Indeed. (I'd probably use a tr:group, but same deal).
>
> The flip side is wondering how much of a pain it'd be to
> implement "I want to change the ready icon, but not the busy icon"
> if we go with "set either facet, both icons are gone". Either design
> makes someone's life hard... which do we think is more common?
>
> > If I approach the subject from a maintainability perspective, I think
> > its more intuitive for the documentation to state why the icon is gone
> > then to have to figure out why some developer stuck an empty outputText
> > into a facet.
>
> Anyone hacking in either case does have the option of
> including a comment in the page, ya know!
>
> -- Adam
>
> >
> > I've been watching this thread, so I hope you don't mind my 2 cents....
> >
> >
> > Nate Perkins
> > General Dynamics C4 Systems
> >
> > >This email message is for the sole use of the intended recipient(s) and
> > may contain GDC4S
> > > confidential or privileged information. Any unauthorized review, use,
> > disclosure or distribution
> > > is prohibited. If you are not an intended recipient, please contact
> > the sender by reply email and
> > > destroy all copies of the original message.
> > >
> >
> > -----Original Message-----
> > From: Adam Winer [mailto:awiner@gmail.com]
> > Sent: Wednesday, September 19, 2007 9:24 AM
> > To: MyFaces Development
> > Subject: Re: svn commit: r576576 [1/3] - in
> > /myfaces/trinidad/trunk/trinidad:
> > trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components
> > /trinidad/core/
> > trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderki
> > t/core/xhtml/ trinida
> >
> > OK, five seconds more consideration, and now I'm torn.
> > It's easy enough to write:
> >
> > <tr:statusIndicator>
> > <f:facet name="busy">Loading...</f:facet>
> > <f:facet name="ready"><tr:outputText/></f:facet>
> > </tr:statusIndicator>
> >
> > ... which would have the same effect. So I could really
> > go either way.
> >
> > -- Adam
> >
> > On 9/19/07, Adam Winer <aw...@gmail.com> wrote:
> > > I see what you're saying... I think I'd be OK then with a rule
> > > where specifying either facet gets rid of both icons. Especially
> > > with a bit of doc explaining why it does that (exactly the example
> > > you give).
> > >
> > > -- Adam
> > >
> > >
> > >
> > > On 9/19/07, Simon Lessard <si...@gmail.com> wrote:
> > > > Hello Adam,
> > > >
> > > > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > > > I think it should be as simple as for each of "busy" and
> > > > > "ready", render the facet if it's present, the icon if it's not.
> > > >
> > > > The only issue with that behavior is most common usage. I think the
> > most
> > > > common usage with facets is going to be a "busy" facet and no
> > "ready" (to
> > > > mimic GMail behavior for example). Personally, that's the way I
> > would use
> > > > it. If that's really the most common case, then it should be "as
> > soon as a
> > > > facet is specified, rendered or not, no icon will be rendered". But,
> > if we
> > > > think the most common case is going to be with both facets, then I
> > agree
> > > > with your suggestion.
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Hmm not as simple as I though. Before pushing a patch let decide
> > on the
> > > > > > behavior for every use case:
> > > > > >
> > > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > Only one facet is specified and rendered --> Don't render any
> > icon or
> > > > > > render the icon of the missing facet?
> > > > > > Only one facet is specified but not rendered --> ?
> > > > > > No facet is specified --> Render both icons
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > that sounds like the best solution.
> > > > > > > >
> > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > > IMO, if we have a facet, we don't render the icon. No
> > need
> > > > > > > > > for an attribute at all.
> > > > > > > > >
> > > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > > can render two statusIndicators.
> > > > > > > > >
> > > > > > > > > -- Adam
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> > wrote:
> > > > > > > > > > Hi,
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> > wrote:
> > > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> > I'll do
> > > > > > that right
> > > > > > > > > > > away.
> > > > > > > > > > >
> > > > > > > > > > > I would also like to add a new attribute to skip the
> > icon
> > > > > > rendering. If it
> > > > > > > > > > > hasn't been of backward compatibility, I would have
> > simply
> > > > removed
> > > > > > them
> > > > > > > > > >
> > > > > > > > > > I added a demo usage of the facet's, I was thinking,
> > that it
> > > > > > shouldn't
> > > > > > > > > > render the "default" icon,
> > > > > > > > > > glad you pointed it out now.
> > > > > > > > > >
> > > > > > > > > > > since it's easily doable with a combination of facet
> > and
> > > > tr:icon,
> > > > > > but since
> > > > > > > > > > > we had a release with the statusIndicator already,
> > that's out
> > > > of
> > > > > > question.
> > > > > > > > > > > So, what I need now is a decent attribute name. What
> > do you
> > > > think
> > > > > > of
> > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > >
> > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> > added
> > > > where
> > > > > > facets.
> > > > > > > > > >
> > > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > > specified,
> > > > > > we
> > > > > > > > > > don't render the "default" icon.
> > > > > > > > > >
> > > > > > > > > > -Matthias
> > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > ~ Simon
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
On 9/19/07, Perkins, Nate-P63196 <Na...@gdc4s.com> wrote:
> Yes, but why pollute the page unnecessarily with an empty outputText?
Indeed. (I'd probably use a tr:group, but same deal).
The flip side is wondering how much of a pain it'd be to
implement "I want to change the ready icon, but not the busy icon"
if we go with "set either facet, both icons are gone". Either design
makes someone's life hard... which do we think is more common?
> If I approach the subject from a maintainability perspective, I think
> its more intuitive for the documentation to state why the icon is gone
> then to have to figure out why some developer stuck an empty outputText
> into a facet.
Anyone hacking in either case does have the option of
including a comment in the page, ya know!
-- Adam
>
> I've been watching this thread, so I hope you don't mind my 2 cents....
>
>
> Nate Perkins
> General Dynamics C4 Systems
>
> >This email message is for the sole use of the intended recipient(s) and
> may contain GDC4S
> > confidential or privileged information. Any unauthorized review, use,
> disclosure or distribution
> > is prohibited. If you are not an intended recipient, please contact
> the sender by reply email and
> > destroy all copies of the original message.
> >
>
> -----Original Message-----
> From: Adam Winer [mailto:awiner@gmail.com]
> Sent: Wednesday, September 19, 2007 9:24 AM
> To: MyFaces Development
> Subject: Re: svn commit: r576576 [1/3] - in
> /myfaces/trinidad/trunk/trinidad:
> trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components
> /trinidad/core/
> trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderki
> t/core/xhtml/ trinida
>
> OK, five seconds more consideration, and now I'm torn.
> It's easy enough to write:
>
> <tr:statusIndicator>
> <f:facet name="busy">Loading...</f:facet>
> <f:facet name="ready"><tr:outputText/></f:facet>
> </tr:statusIndicator>
>
> ... which would have the same effect. So I could really
> go either way.
>
> -- Adam
>
> On 9/19/07, Adam Winer <aw...@gmail.com> wrote:
> > I see what you're saying... I think I'd be OK then with a rule
> > where specifying either facet gets rid of both icons. Especially
> > with a bit of doc explaining why it does that (exactly the example
> > you give).
> >
> > -- Adam
> >
> >
> >
> > On 9/19/07, Simon Lessard <si...@gmail.com> wrote:
> > > Hello Adam,
> > >
> > > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > > I think it should be as simple as for each of "busy" and
> > > > "ready", render the facet if it's present, the icon if it's not.
> > >
> > > The only issue with that behavior is most common usage. I think the
> most
> > > common usage with facets is going to be a "busy" facet and no
> "ready" (to
> > > mimic GMail behavior for example). Personally, that's the way I
> would use
> > > it. If that's really the most common case, then it should be "as
> soon as a
> > > facet is specified, rendered or not, no icon will be rendered". But,
> if we
> > > think the most common case is going to be with both facets, then I
> agree
> > > with your suggestion.
> > >
> > > ~ Simon
> > >
> > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Hmm not as simple as I though. Before pushing a patch let decide
> on the
> > > > > behavior for every use case:
> > > > >
> > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > Both facets are specified but only one is rendered --> ?
> > > > > Both facets are specified but neither are rendered --> ?
> > > > > Only one facet is specified and rendered --> Don't render any
> icon or
> > > > > render the icon of the missing facet?
> > > > > Only one facet is specified but not rendered --> ?
> > > > > No facet is specified --> Render both icons
> > > > >
> > > > > ~ Simon
> > > > >
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > that sounds like the best solution.
> > > > > > >
> > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > IMO, if we have a facet, we don't render the icon. No
> need
> > > > > > > > for an attribute at all.
> > > > > > > >
> > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > can render two statusIndicators.
> > > > > > > >
> > > > > > > > -- Adam
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> wrote:
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> wrote:
> > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> I'll do
> > > > > that right
> > > > > > > > > > away.
> > > > > > > > > >
> > > > > > > > > > I would also like to add a new attribute to skip the
> icon
> > > > > rendering. If it
> > > > > > > > > > hasn't been of backward compatibility, I would have
> simply
> > > removed
> > > > > them
> > > > > > > > >
> > > > > > > > > I added a demo usage of the facet's, I was thinking,
> that it
> > > > > shouldn't
> > > > > > > > > render the "default" icon,
> > > > > > > > > glad you pointed it out now.
> > > > > > > > >
> > > > > > > > > > since it's easily doable with a combination of facet
> and
> > > tr:icon,
> > > > > but since
> > > > > > > > > > we had a release with the statusIndicator already,
> that's out
> > > of
> > > > > question.
> > > > > > > > > > So, what I need now is a decent attribute name. What
> do you
> > > think
> > > > > of
> > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > >
> > > > > > > > > I tend to like renderFacetsOnly, because that what you
> added
> > > where
> > > > > facets.
> > > > > > > > >
> > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > specified,
> > > > > we
> > > > > > > > > don't render the "default" icon.
> > > > > > > > >
> > > > > > > > > -Matthias
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > ~ Simon
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
>
RE: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by "Perkins, Nate-P63196" <Na...@gdc4s.com>.
Yes, but why pollute the page unnecessarily with an empty outputText?
If I approach the subject from a maintainability perspective, I think
its more intuitive for the documentation to state why the icon is gone
then to have to figure out why some developer stuck an empty outputText
into a facet.
I've been watching this thread, so I hope you don't mind my 2 cents....
Nate Perkins
General Dynamics C4 Systems
>This email message is for the sole use of the intended recipient(s) and
may contain GDC4S
> confidential or privileged information. Any unauthorized review, use,
disclosure or distribution
> is prohibited. If you are not an intended recipient, please contact
the sender by reply email and
> destroy all copies of the original message.
>
-----Original Message-----
From: Adam Winer [mailto:awiner@gmail.com]
Sent: Wednesday, September 19, 2007 9:24 AM
To: MyFaces Development
Subject: Re: svn commit: r576576 [1/3] - in
/myfaces/trinidad/trunk/trinidad:
trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components
/trinidad/core/
trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderki
t/core/xhtml/ trinida
OK, five seconds more consideration, and now I'm torn.
It's easy enough to write:
<tr:statusIndicator>
<f:facet name="busy">Loading...</f:facet>
<f:facet name="ready"><tr:outputText/></f:facet>
</tr:statusIndicator>
... which would have the same effect. So I could really
go either way.
-- Adam
On 9/19/07, Adam Winer <aw...@gmail.com> wrote:
> I see what you're saying... I think I'd be OK then with a rule
> where specifying either facet gets rid of both icons. Especially
> with a bit of doc explaining why it does that (exactly the example
> you give).
>
> -- Adam
>
>
>
> On 9/19/07, Simon Lessard <si...@gmail.com> wrote:
> > Hello Adam,
> >
> > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > I think it should be as simple as for each of "busy" and
> > > "ready", render the facet if it's present, the icon if it's not.
> >
> > The only issue with that behavior is most common usage. I think the
most
> > common usage with facets is going to be a "busy" facet and no
"ready" (to
> > mimic GMail behavior for example). Personally, that's the way I
would use
> > it. If that's really the most common case, then it should be "as
soon as a
> > facet is specified, rendered or not, no icon will be rendered". But,
if we
> > think the most common case is going to be with both facets, then I
agree
> > with your suggestion.
> >
> > ~ Simon
> >
> >
> > > -- Adam
> > >
> > >
> > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Hmm not as simple as I though. Before pushing a patch let decide
on the
> > > > behavior for every use case:
> > > >
> > > > Both facets are specified and rendered --> Don't render any icon
> > > > Both facets are specified but only one is rendered --> ?
> > > > Both facets are specified but neither are rendered --> ?
> > > > Only one facet is specified and rendered --> Don't render any
icon or
> > > > render the icon of the missing facet?
> > > > Only one facet is specified but not rendered --> ?
> > > > No facet is specified --> Render both icons
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > >
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > that sounds like the best solution.
> > > > > >
> > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > IMO, if we have a facet, we don't render the icon. No
need
> > > > > > > for an attribute at all.
> > > > > > >
> > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > can render two statusIndicators.
> > > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
wrote:
> > > > > > > > > Speaking of which, I forgot to add skin documentation.
I'll do
> > > > that right
> > > > > > > > > away.
> > > > > > > > >
> > > > > > > > > I would also like to add a new attribute to skip the
icon
> > > > rendering. If it
> > > > > > > > > hasn't been of backward compatibility, I would have
simply
> > removed
> > > > them
> > > > > > > >
> > > > > > > > I added a demo usage of the facet's, I was thinking,
that it
> > > > shouldn't
> > > > > > > > render the "default" icon,
> > > > > > > > glad you pointed it out now.
> > > > > > > >
> > > > > > > > > since it's easily doable with a combination of facet
and
> > tr:icon,
> > > > but since
> > > > > > > > > we had a release with the statusIndicator already,
that's out
> > of
> > > > question.
> > > > > > > > > So, what I need now is a decent attribute name. What
do you
> > think
> > > > of
> > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > >
> > > > > > > > I tend to like renderFacetsOnly, because that what you
added
> > where
> > > > facets.
> > > > > > > >
> > > > > > > > Perhaps, we can change that soon, that when facet's are
> > specified,
> > > > we
> > > > > > > > don't render the "default" icon.
> > > > > > > >
> > > > > > > > -Matthias
> > > > > > > >
> > > > > > > > >
> > > > > > > > > ~ Simon
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
OK, five seconds more consideration, and now I'm torn.
It's easy enough to write:
<tr:statusIndicator>
<f:facet name="busy">Loading...</f:facet>
<f:facet name="ready"><tr:outputText/></f:facet>
</tr:statusIndicator>
... which would have the same effect. So I could really
go either way.
-- Adam
On 9/19/07, Adam Winer <aw...@gmail.com> wrote:
> I see what you're saying... I think I'd be OK then with a rule
> where specifying either facet gets rid of both icons. Especially
> with a bit of doc explaining why it does that (exactly the example
> you give).
>
> -- Adam
>
>
>
> On 9/19/07, Simon Lessard <si...@gmail.com> wrote:
> > Hello Adam,
> >
> > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > I think it should be as simple as for each of "busy" and
> > > "ready", render the facet if it's present, the icon if it's not.
> >
> > The only issue with that behavior is most common usage. I think the most
> > common usage with facets is going to be a "busy" facet and no "ready" (to
> > mimic GMail behavior for example). Personally, that's the way I would use
> > it. If that's really the most common case, then it should be "as soon as a
> > facet is specified, rendered or not, no icon will be rendered". But, if we
> > think the most common case is going to be with both facets, then I agree
> > with your suggestion.
> >
> > ~ Simon
> >
> >
> > > -- Adam
> > >
> > >
> > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Hmm not as simple as I though. Before pushing a patch let decide on the
> > > > behavior for every use case:
> > > >
> > > > Both facets are specified and rendered --> Don't render any icon
> > > > Both facets are specified but only one is rendered --> ?
> > > > Both facets are specified but neither are rendered --> ?
> > > > Only one facet is specified and rendered --> Don't render any icon or
> > > > render the icon of the missing facet?
> > > > Only one facet is specified but not rendered --> ?
> > > > No facet is specified --> Render both icons
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > >
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > that sounds like the best solution.
> > > > > >
> > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > for an attribute at all.
> > > > > > >
> > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > can render two statusIndicators.
> > > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com > wrote:
> > > > > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> > > > that right
> > > > > > > > > away.
> > > > > > > > >
> > > > > > > > > I would also like to add a new attribute to skip the icon
> > > > rendering. If it
> > > > > > > > > hasn't been of backward compatibility, I would have simply
> > removed
> > > > them
> > > > > > > >
> > > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > > shouldn't
> > > > > > > > render the "default" icon,
> > > > > > > > glad you pointed it out now.
> > > > > > > >
> > > > > > > > > since it's easily doable with a combination of facet and
> > tr:icon,
> > > > but since
> > > > > > > > > we had a release with the statusIndicator already, that's out
> > of
> > > > question.
> > > > > > > > > So, what I need now is a decent attribute name. What do you
> > think
> > > > of
> > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > >
> > > > > > > > I tend to like renderFacetsOnly, because that what you added
> > where
> > > > facets.
> > > > > > > >
> > > > > > > > Perhaps, we can change that soon, that when facet's are
> > specified,
> > > > we
> > > > > > > > don't render the "default" icon.
> > > > > > > >
> > > > > > > > -Matthias
> > > > > > > >
> > > > > > > > >
> > > > > > > > > ~ Simon
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
I see what you're saying... I think I'd be OK then with a rule
where specifying either facet gets rid of both icons. Especially
with a bit of doc explaining why it does that (exactly the example
you give).
-- Adam
On 9/19/07, Simon Lessard <si...@gmail.com> wrote:
> Hello Adam,
>
> On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > I think it should be as simple as for each of "busy" and
> > "ready", render the facet if it's present, the icon if it's not.
>
> The only issue with that behavior is most common usage. I think the most
> common usage with facets is going to be a "busy" facet and no "ready" (to
> mimic GMail behavior for example). Personally, that's the way I would use
> it. If that's really the most common case, then it should be "as soon as a
> facet is specified, rendered or not, no icon will be rendered". But, if we
> think the most common case is going to be with both facets, then I agree
> with your suggestion.
>
> ~ Simon
>
>
> > -- Adam
> >
> >
> > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > Hmm not as simple as I though. Before pushing a patch let decide on the
> > > behavior for every use case:
> > >
> > > Both facets are specified and rendered --> Don't render any icon
> > > Both facets are specified but only one is rendered --> ?
> > > Both facets are specified but neither are rendered --> ?
> > > Only one facet is specified and rendered --> Don't render any icon or
> > > render the icon of the missing facet?
> > > Only one facet is specified but not rendered --> ?
> > > No facet is specified --> Render both icons
> > >
> > > ~ Simon
> > >
> > >
> > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > >
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > that sounds like the best solution.
> > > > >
> > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > for an attribute at all.
> > > > > >
> > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > can render two statusIndicators.
> > > > > >
> > > > > > -- Adam
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com > wrote:
> > > > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> > > that right
> > > > > > > > away.
> > > > > > > >
> > > > > > > > I would also like to add a new attribute to skip the icon
> > > rendering. If it
> > > > > > > > hasn't been of backward compatibility, I would have simply
> removed
> > > them
> > > > > > >
> > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > shouldn't
> > > > > > > render the "default" icon,
> > > > > > > glad you pointed it out now.
> > > > > > >
> > > > > > > > since it's easily doable with a combination of facet and
> tr:icon,
> > > but since
> > > > > > > > we had a release with the statusIndicator already, that's out
> of
> > > question.
> > > > > > > > So, what I need now is a decent attribute name. What do you
> think
> > > of
> > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > >
> > > > > > > I tend to like renderFacetsOnly, because that what you added
> where
> > > facets.
> > > > > > >
> > > > > > > Perhaps, we can change that soon, that when facet's are
> specified,
> > > we
> > > > > > > don't render the "default" icon.
> > > > > > >
> > > > > > > -Matthias
> > > > > > >
> > > > > > > >
> > > > > > > > ~ Simon
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> > >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Great! That's exactly what I was looking for :)
Thanks.
On 9/21/07, Jeanne Waldman <je...@oracle.com> wrote:
>
> Oh, sorry. Didn't notice the icon. You are right. You can't do it in xss
> or css right now. There's a JIRA issue requesting -tr-rule-ref for icons.
> To do this in the Skin java file you would use the ReferenceIcon.
>
> e.g.,
> // tr:panelHeader header icons point to reference icon so they can
> // be easily shared with tr:messages's icons
> SkinSelectors.AF_PANEL_HEADER_ERROR_ICON_NAME,
> new ReferenceIcon(SkinSelectors.HEADER_ERROR_ICON_ALIAS_NAME),
>
> Does that answer your question?
>
> Simon Lessard wrote:
>
> Hello Jeanne,
>
> I'm going to try, but I thought it would be different for icon, because
> all icon aliases are defined in XhtmlSkin and not in base-desktop.xss.
>
> On 9/21/07, Jeanne Waldman <je...@oracle.com> wrote:
> >
> > In XSS they are 'named' styles:
> > for example:
> > <style name="AFStartTextAlign">
> > <property name="text-align">left</property>
> > </style>
> >
> > if .AFStartTextAlign:alias
> > in css.
> >
> > Look in base-desktop.xss for other examples, and how you include this in
> > other styles.
> >
> > - Jenane
> >
> > Simon Lessard wrote:
> >
> > Hello all and principally Jeanne,
> >
> > Is there a way to use icon aliases with XSS and/or XhtmlSkin? I wanted
> > to create the following two aliases to enable easy use of tr:icon:
> >
> > - .AFBusyIcon:alias
> > - .AFReadyIcon:alias
> >
> > And have the following two selectors reference them:
> >
> > - af|statusIndicator::busy-icon
> > - af|statusIndicator::ready-icon
> >
> > Is that even possible or must I define both and point on the same
> > source. The latter would be quite bad since users overriding the aliases
> > will probably want to impact both.
> >
> >
> > Regards,
> >
> > ~ Simon
> >
> >
> > On 9/21/07, Simon Lessard <simon.lessard.3@gmail.com > wrote:
> > >
> > > Ok I think I'll go with facet or icon since it seems to be the most
> > > accepted scenario. I'm going to comment the component accordingly.
> > >
> > >
> > > On 9/20/07, Adam Winer <aw...@gmail.com> wrote:
> > > >
> > > > I'm happier if we don't add any attributes... We definitely
> > > > want default behavior where, if nothing is specified,
> > > > the icons get shown.
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/20/07, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > > >
> > > > > The other api I like is one you mentioned was not backwards
> > > > compatible, and
> > > > > that is to have them put the icon in the facet if they want an
> > > > icon.
> > > > >
> > > > > I agree that the below API is busy, but to me it is clear. No
> > > > guessing what
> > > > > the logic is.
> > > > >
> > > > >
> > > > > Simon Lessard wrote:
> > > > > Hello Jeanne,
> > > > >
> > > > > Something alike was proposed at first, but again the most common
> > > > usage
> > > > > kicks in. Such attributes imply, for GMail like behavior:
> > > > >
> > > > > <tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
> > > > > <f:facet name="busy">
> > > > > <tr:outputText value="Loading..."/>
> > > > > </f:facet>
> > > > > </tr:statusIndicator>
> > > > >
> > > > > It's a bit longer, but it's easily livable with I guess.
> > > > >
> > > > >
> > > > > On 9/20/07, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > > > >
> > > > > > How about hideReadyIcon = "true/false"
> > > > > > hideBusyIcon = "true/false".
> > > > > >
> > > > > > It's explicit and the user doesn't have to guess at the logic we
> > > > are using
> > > > > -- or read the doc.
> > > > > >
> > > > > > - Jeanne
> > > > > >
> > > > > >
> > > > > > Simon Lessard wrote:
> > > > > > Hello Adam,
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > I think it should be as simple as for each of "busy" and
> > > > > > > "ready", render the facet if it's present, the icon if it's
> > > > not.
> > > > > >
> > > > > >
> > > > > > The only issue with that behavior is most common usage. I think
> > > > the most
> > > > > common usage with facets is going to be a "busy" facet and no
> > > > "ready" (to
> > > > > mimic GMail behavior for example). Personally, that's the way I
> > > > would use
> > > > > it. If that's really the most common case, then it should be "as
> > > > soon as a
> > > > > facet is specified, rendered or not, no icon will be rendered".
> > > > But, if we
> > > > > think the most common case is going to be with both facets, then I
> > > > agree
> > > > > with your suggestion.
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > Hmm not as simple as I though. Before pushing a patch let
> > > > decide on
> > > > > the
> > > > > > > > behavior for every use case:
> > > > > > > >
> > > > > > > > Both facets are specified and rendered --> Don't render any
> > > > icon
> > > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > > Only one facet is specified and rendered --> Don't render
> > > > any icon or
> > > > > > > > render the icon of the missing facet?
> > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > No facet is specified --> Render both icons
> > > > > > > >
> > > > > > > > ~ Simon
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > > > wrote:
> > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> > > > wrote:
> > > > > > > > > > that sounds like the best solution.
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > > > > IMO, if we have a facet, we don't render the icon. No
> > > > need
> > > > > > > > > > > for an attribute at all.
> > > > > > > > > > >
> > > > > > > > > > > Anyone that desperately needs both the facet and the
> > > > icon
> > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > >
> > > > > > > > > > > -- Adam
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> > > > wrote:
> > > > > > > > > > > > Hi,
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Simon Lessard <
> > > > simon.lessard.3@gmail.com > wrote:
> > > > > > > > > > > > > Speaking of which, I forgot to add skin
> > > > documentation. I'll
> > > > > do
> > > > > > > > that right
> > > > > > > > > > > > > away.
> > > > > > > > > > > > >
> > > > > > > > > > > > > I would also like to add a new attribute to skip
> > > > the icon
> > > > > > > > rendering. If it
> > > > > > > > > > > > > hasn't been of backward compatibility, I would
> > > > have simply
> > > > > removed
> > > > > > > > them
> > > > > > > > > > > >
> > > > > > > > > > > > I added a demo usage of the facet's, I was thinking,
> > > > that it
> > > > > > > > shouldn't
> > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > >
> > > > > > > > > > > > > since it's easily doable with a combination of
> > > > facet and
> > > > > tr:icon,
> > > > > > > > but since
> > > > > > > > > > > > > we had a release with the statusIndicator already,
> > > > that's
> > > > > out of
> > > > > > > > question.
> > > > > > > > > > > > > So, what I need now is a decent attribute name.
> > > > What do you
> > > > > think
> > > > > > > > of
> > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > >
> > > > > > > > > > > > I tend to like renderFacetsOnly, because that what
> > > > you added
> > > > > where
> > > > > > > > facets.
> > > > > > > > > > > >
> > > > > > > > > > > > Perhaps, we can change that soon, that when facet's
> > > > are
> > > > > specified,
> > > > > > > > we
> > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > >
> > > > > > > > > > > > -Matthias
> > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hello Jeanne,
I'm going to try, but I thought it would be different for icon, because all
icon aliases are defined in XhtmlSkin and not in base-desktop.xss.
On 9/21/07, Jeanne Waldman <je...@oracle.com> wrote:
>
> In XSS they are 'named' styles:
> for example:
> <style name="AFStartTextAlign">
> <property name="text-align">left</property>
> </style>
>
> if .AFStartTextAlign:alias
> in css.
>
> Look in base-desktop.xss for other examples, and how you include this in
> other styles.
>
> - Jenane
>
> Simon Lessard wrote:
>
> Hello all and principally Jeanne,
>
> Is there a way to use icon aliases with XSS and/or XhtmlSkin? I wanted to
> create the following two aliases to enable easy use of tr:icon:
>
> - .AFBusyIcon:alias
> - .AFReadyIcon:alias
>
> And have the following two selectors reference them:
>
> - af|statusIndicator::busy-icon
> - af|statusIndicator::ready-icon
>
> Is that even possible or must I define both and point on the same source.
> The latter would be quite bad since users overriding the aliases will
> probably want to impact both.
>
>
> Regards,
>
> ~ Simon
>
>
> On 9/21/07, Simon Lessard <si...@gmail.com> wrote:
> >
> > Ok I think I'll go with facet or icon since it seems to be the most
> > accepted scenario. I'm going to comment the component accordingly.
> >
> >
> > On 9/20/07, Adam Winer <aw...@gmail.com> wrote:
> > >
> > > I'm happier if we don't add any attributes... We definitely
> > > want default behavior where, if nothing is specified,
> > > the icons get shown.
> > >
> > > -- Adam
> > >
> > >
> > > On 9/20/07, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > >
> > > > The other api I like is one you mentioned was not backwards
> > > compatible, and
> > > > that is to have them put the icon in the facet if they want an icon.
> > > >
> > > > I agree that the below API is busy, but to me it is clear. No
> > > guessing what
> > > > the logic is.
> > > >
> > > >
> > > > Simon Lessard wrote:
> > > > Hello Jeanne,
> > > >
> > > > Something alike was proposed at first, but again the most common
> > > usage
> > > > kicks in. Such attributes imply, for GMail like behavior:
> > > >
> > > > <tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
> > > > <f:facet name="busy">
> > > > <tr:outputText value="Loading..."/>
> > > > </f:facet>
> > > > </tr:statusIndicator>
> > > >
> > > > It's a bit longer, but it's easily livable with I guess.
> > > >
> > > >
> > > > On 9/20/07, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > > >
> > > > > How about hideReadyIcon = "true/false"
> > > > > hideBusyIcon = "true/false".
> > > > >
> > > > > It's explicit and the user doesn't have to guess at the logic we
> > > are using
> > > > -- or read the doc.
> > > > >
> > > > > - Jeanne
> > > > >
> > > > >
> > > > > Simon Lessard wrote:
> > > > > Hello Adam,
> > > > >
> > > > >
> > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > I think it should be as simple as for each of "busy" and
> > > > > > "ready", render the facet if it's present, the icon if it's not.
> > > > >
> > > > >
> > > > > The only issue with that behavior is most common usage. I think
> > > the most
> > > > common usage with facets is going to be a "busy" facet and no
> > > "ready" (to
> > > > mimic GMail behavior for example). Personally, that's the way I
> > > would use
> > > > it. If that's really the most common case, then it should be "as
> > > soon as a
> > > > facet is specified, rendered or not, no icon will be rendered". But,
> > > if we
> > > > think the most common case is going to be with both facets, then I
> > > agree
> > > > with your suggestion.
> > > > >
> > > > > ~ Simon
> > > > >
> > > > >
> > > > > > -- Adam
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Hmm not as simple as I though. Before pushing a patch let
> > > decide on
> > > > the
> > > > > > > behavior for every use case:
> > > > > > >
> > > > > > > Both facets are specified and rendered --> Don't render any
> > > icon
> > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > Only one facet is specified and rendered --> Don't render any
> > > icon or
> > > > > > > render the icon of the missing facet?
> > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > No facet is specified --> Render both icons
> > > > > > >
> > > > > > > ~ Simon
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org > wrote:
> > > > > > > > > that sounds like the best solution.
> > > > > > > > >
> > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > > > IMO, if we have a facet, we don't render the icon. No
> > > need
> > > > > > > > > > for an attribute at all.
> > > > > > > > > >
> > > > > > > > > > Anyone that desperately needs both the facet and the
> > > icon
> > > > > > > > > > can render two statusIndicators.
> > > > > > > > > >
> > > > > > > > > > -- Adam
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> > > wrote:
> > > > > > > > > > > Hi,
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > > > > > Speaking of which, I forgot to add skin
> > > documentation. I'll
> > > > do
> > > > > > > that right
> > > > > > > > > > > > away.
> > > > > > > > > > > >
> > > > > > > > > > > > I would also like to add a new attribute to skip the
> > > icon
> > > > > > > rendering. If it
> > > > > > > > > > > > hasn't been of backward compatibility, I would have
> > > simply
> > > > removed
> > > > > > > them
> > > > > > > > > > >
> > > > > > > > > > > I added a demo usage of the facet's, I was thinking,
> > > that it
> > > > > > > shouldn't
> > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > >
> > > > > > > > > > > > since it's easily doable with a combination of facet
> > > and
> > > > tr:icon,
> > > > > > > but since
> > > > > > > > > > > > we had a release with the statusIndicator already,
> > > that's
> > > > out of
> > > > > > > question.
> > > > > > > > > > > > So, what I need now is a decent attribute name. What
> > > do you
> > > > think
> > > > > > > of
> > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > >
> > > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> > > added
> > > > where
> > > > > > > facets.
> > > > > > > > > > >
> > > > > > > > > > > Perhaps, we can change that soon, that when facet's
> > > are
> > > > specified,
> > > > > > > we
> > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > >
> > > > > > > > > > > -Matthias
> > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > ~ Simon
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hello all and principally Jeanne,
Is there a way to use icon aliases with XSS and/or XhtmlSkin? I wanted to
create the following two aliases to enable easy use of tr:icon:
- .AFBusyIcon:alias
- .AFReadyIcon:alias
And have the following two selectors reference them:
- af|statusIndicator::busy-icon
- af|statusIndicator::ready-icon
Is that even possible or must I define both and point on the same source.
The latter would be quite bad since users overriding the aliases will
probably want to impact both.
Regards,
~ Simon
On 9/21/07, Simon Lessard <si...@gmail.com> wrote:
>
> Ok I think I'll go with facet or icon since it seems to be the most
> accepted scenario. I'm going to comment the component accordingly.
>
>
> On 9/20/07, Adam Winer <aw...@gmail.com> wrote:
> >
> > I'm happier if we don't add any attributes... We definitely
> > want default behavior where, if nothing is specified,
> > the icons get shown.
> >
> > -- Adam
> >
> >
> > On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
> > >
> > > The other api I like is one you mentioned was not backwards
> > compatible, and
> > > that is to have them put the icon in the facet if they want an icon.
> > >
> > > I agree that the below API is busy, but to me it is clear. No
> > guessing what
> > > the logic is.
> > >
> > >
> > > Simon Lessard wrote:
> > > Hello Jeanne,
> > >
> > > Something alike was proposed at first, but again the most common
> > usage
> > > kicks in. Such attributes imply, for GMail like behavior:
> > >
> > > <tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
> > > <f:facet name="busy">
> > > <tr:outputText value="Loading..."/>
> > > </f:facet>
> > > </tr:statusIndicator>
> > >
> > > It's a bit longer, but it's easily livable with I guess.
> > >
> > >
> > > On 9/20/07, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > >
> > > > How about hideReadyIcon = "true/false"
> > > > hideBusyIcon = "true/false".
> > > >
> > > > It's explicit and the user doesn't have to guess at the logic we are
> > using
> > > -- or read the doc.
> > > >
> > > > - Jeanne
> > > >
> > > >
> > > > Simon Lessard wrote:
> > > > Hello Adam,
> > > >
> > > >
> > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > I think it should be as simple as for each of "busy" and
> > > > > "ready", render the facet if it's present, the icon if it's not.
> > > >
> > > >
> > > > The only issue with that behavior is most common usage. I think the
> > most
> > > common usage with facets is going to be a "busy" facet and no "ready"
> > (to
> > > mimic GMail behavior for example). Personally, that's the way I would
> > use
> > > it. If that's really the most common case, then it should be "as soon
> > as a
> > > facet is specified, rendered or not, no icon will be rendered". But,
> > if we
> > > think the most common case is going to be with both facets, then I
> > agree
> > > with your suggestion.
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Hmm not as simple as I though. Before pushing a patch let decide
> > on
> > > the
> > > > > > behavior for every use case:
> > > > > >
> > > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > Only one facet is specified and rendered --> Don't render any
> > icon or
> > > > > > render the icon of the missing facet?
> > > > > > Only one facet is specified but not rendered --> ?
> > > > > > No facet is specified --> Render both icons
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > that sounds like the best solution.
> > > > > > > >
> > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > > IMO, if we have a facet, we don't render the icon. No
> > need
> > > > > > > > > for an attribute at all.
> > > > > > > > >
> > > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > > can render two statusIndicators.
> > > > > > > > >
> > > > > > > > > -- Adam
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> > wrote:
> > > > > > > > > > Hi,
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> > wrote:
> > > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> > I'll
> > > do
> > > > > > that right
> > > > > > > > > > > away.
> > > > > > > > > > >
> > > > > > > > > > > I would also like to add a new attribute to skip the
> > icon
> > > > > > rendering. If it
> > > > > > > > > > > hasn't been of backward compatibility, I would have
> > simply
> > > removed
> > > > > > them
> > > > > > > > > >
> > > > > > > > > > I added a demo usage of the facet's, I was thinking,
> > that it
> > > > > > shouldn't
> > > > > > > > > > render the "default" icon,
> > > > > > > > > > glad you pointed it out now.
> > > > > > > > > >
> > > > > > > > > > > since it's easily doable with a combination of facet
> > and
> > > tr:icon,
> > > > > > but since
> > > > > > > > > > > we had a release with the statusIndicator already,
> > that's
> > > out of
> > > > > > question.
> > > > > > > > > > > So, what I need now is a decent attribute name. What
> > do you
> > > think
> > > > > > of
> > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > >
> > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> > added
> > > where
> > > > > > facets.
> > > > > > > > > >
> > > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > specified,
> > > > > > we
> > > > > > > > > > don't render the "default" icon.
> > > > > > > > > >
> > > > > > > > > > -Matthias
> > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > ~ Simon
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Ok I think I'll go with facet or icon since it seems to be the most accepted
scenario. I'm going to comment the component accordingly.
On 9/20/07, Adam Winer <aw...@gmail.com> wrote:
>
> I'm happier if we don't add any attributes... We definitely
> want default behavior where, if nothing is specified,
> the icons get shown.
>
> -- Adam
>
>
> On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
> >
> > The other api I like is one you mentioned was not backwards compatible,
> and
> > that is to have them put the icon in the facet if they want an icon.
> >
> > I agree that the below API is busy, but to me it is clear. No guessing
> what
> > the logic is.
> >
> >
> > Simon Lessard wrote:
> > Hello Jeanne,
> >
> > Something alike was proposed at first, but again the most common usage
> > kicks in. Such attributes imply, for GMail like behavior:
> >
> > <tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
> > <f:facet name="busy">
> > <tr:outputText value="Loading..."/>
> > </f:facet>
> > </tr:statusIndicator>
> >
> > It's a bit longer, but it's easily livable with I guess.
> >
> >
> > On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
> > >
> > > How about hideReadyIcon = "true/false"
> > > hideBusyIcon = "true/false".
> > >
> > > It's explicit and the user doesn't have to guess at the logic we are
> using
> > -- or read the doc.
> > >
> > > - Jeanne
> > >
> > >
> > > Simon Lessard wrote:
> > > Hello Adam,
> > >
> > >
> > > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > > I think it should be as simple as for each of "busy" and
> > > > "ready", render the facet if it's present, the icon if it's not.
> > >
> > >
> > > The only issue with that behavior is most common usage. I think the
> most
> > common usage with facets is going to be a "busy" facet and no "ready"
> (to
> > mimic GMail behavior for example). Personally, that's the way I would
> use
> > it. If that's really the most common case, then it should be "as soon as
> a
> > facet is specified, rendered or not, no icon will be rendered". But, if
> we
> > think the most common case is going to be with both facets, then I agree
> > with your suggestion.
> > >
> > > ~ Simon
> > >
> > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Hmm not as simple as I though. Before pushing a patch let decide
> on
> > the
> > > > > behavior for every use case:
> > > > >
> > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > Both facets are specified but only one is rendered --> ?
> > > > > Both facets are specified but neither are rendered --> ?
> > > > > Only one facet is specified and rendered --> Don't render any
> icon or
> > > > > render the icon of the missing facet?
> > > > > Only one facet is specified but not rendered --> ?
> > > > > No facet is specified --> Render both icons
> > > > >
> > > > > ~ Simon
> > > > >
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > that sounds like the best solution.
> > > > > > >
> > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > > for an attribute at all.
> > > > > > > >
> > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > can render two statusIndicators.
> > > > > > > >
> > > > > > > > -- Adam
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> wrote:
> > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> I'll
> > do
> > > > > that right
> > > > > > > > > > away.
> > > > > > > > > >
> > > > > > > > > > I would also like to add a new attribute to skip the
> icon
> > > > > rendering. If it
> > > > > > > > > > hasn't been of backward compatibility, I would have
> simply
> > removed
> > > > > them
> > > > > > > > >
> > > > > > > > > I added a demo usage of the facet's, I was thinking, that
> it
> > > > > shouldn't
> > > > > > > > > render the "default" icon,
> > > > > > > > > glad you pointed it out now.
> > > > > > > > >
> > > > > > > > > > since it's easily doable with a combination of facet and
> > tr:icon,
> > > > > but since
> > > > > > > > > > we had a release with the statusIndicator already,
> that's
> > out of
> > > > > question.
> > > > > > > > > > So, what I need now is a decent attribute name. What do
> you
> > think
> > > > > of
> > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > >
> > > > > > > > > I tend to like renderFacetsOnly, because that what you
> added
> > where
> > > > > facets.
> > > > > > > > >
> > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > specified,
> > > > > we
> > > > > > > > > don't render the "default" icon.
> > > > > > > > >
> > > > > > > > > -Matthias
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > ~ Simon
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
I'm happier if we don't add any attributes... We definitely
want default behavior where, if nothing is specified,
the icons get shown.
-- Adam
On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
>
> The other api I like is one you mentioned was not backwards compatible, and
> that is to have them put the icon in the facet if they want an icon.
>
> I agree that the below API is busy, but to me it is clear. No guessing what
> the logic is.
>
>
> Simon Lessard wrote:
> Hello Jeanne,
>
> Something alike was proposed at first, but again the most common usage
> kicks in. Such attributes imply, for GMail like behavior:
>
> <tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
> <f:facet name="busy">
> <tr:outputText value="Loading..."/>
> </f:facet>
> </tr:statusIndicator>
>
> It's a bit longer, but it's easily livable with I guess.
>
>
> On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
> >
> > How about hideReadyIcon = "true/false"
> > hideBusyIcon = "true/false".
> >
> > It's explicit and the user doesn't have to guess at the logic we are using
> -- or read the doc.
> >
> > - Jeanne
> >
> >
> > Simon Lessard wrote:
> > Hello Adam,
> >
> >
> > On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > > I think it should be as simple as for each of "busy" and
> > > "ready", render the facet if it's present, the icon if it's not.
> >
> >
> > The only issue with that behavior is most common usage. I think the most
> common usage with facets is going to be a "busy" facet and no "ready" (to
> mimic GMail behavior for example). Personally, that's the way I would use
> it. If that's really the most common case, then it should be "as soon as a
> facet is specified, rendered or not, no icon will be rendered". But, if we
> think the most common case is going to be with both facets, then I agree
> with your suggestion.
> >
> > ~ Simon
> >
> >
> > > -- Adam
> > >
> > >
> > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Hmm not as simple as I though. Before pushing a patch let decide on
> the
> > > > behavior for every use case:
> > > >
> > > > Both facets are specified and rendered --> Don't render any icon
> > > > Both facets are specified but only one is rendered --> ?
> > > > Both facets are specified but neither are rendered --> ?
> > > > Only one facet is specified and rendered --> Don't render any icon or
> > > > render the icon of the missing facet?
> > > > Only one facet is specified but not rendered --> ?
> > > > No facet is specified --> Render both icons
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > >
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > that sounds like the best solution.
> > > > > >
> > > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > for an attribute at all.
> > > > > > >
> > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > can render two statusIndicators.
> > > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com > wrote:
> > > > > > > > > Speaking of which, I forgot to add skin documentation. I'll
> do
> > > > that right
> > > > > > > > > away.
> > > > > > > > >
> > > > > > > > > I would also like to add a new attribute to skip the icon
> > > > rendering. If it
> > > > > > > > > hasn't been of backward compatibility, I would have simply
> removed
> > > > them
> > > > > > > >
> > > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > > shouldn't
> > > > > > > > render the "default" icon,
> > > > > > > > glad you pointed it out now.
> > > > > > > >
> > > > > > > > > since it's easily doable with a combination of facet and
> tr:icon,
> > > > but since
> > > > > > > > > we had a release with the statusIndicator already, that's
> out of
> > > > question.
> > > > > > > > > So, what I need now is a decent attribute name. What do you
> think
> > > > of
> > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > >
> > > > > > > > I tend to like renderFacetsOnly, because that what you added
> where
> > > > facets.
> > > > > > > >
> > > > > > > > Perhaps, we can change that soon, that when facet's are
> specified,
> > > > we
> > > > > > > > don't render the "default" icon.
> > > > > > > >
> > > > > > > > -Matthias
> > > > > > > >
> > > > > > > > >
> > > > > > > > > ~ Simon
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hello Jeanne,
Something alike was proposed at first, but again the most common usage kicks
in. Such attributes imply, for GMail like behavior:
<tr:statusIndicator hideReadyIcon="true" hideBusyIcon="true">
<f:facet name="busy">
<tr:outputText value="Loading..."/>
</f:facet>
</tr:statusIndicator>
It's a bit longer, but it's easily livable with I guess.
On 9/20/07, Jeanne Waldman <je...@oracle.com> wrote:
>
> How about hideReadyIcon = "true/false"
> hideBusyIcon = "true/false".
>
> It's explicit and the user doesn't have to guess at the logic we are using
> -- or read the doc.
>
> - Jeanne
>
> Simon Lessard wrote:
>
> Hello Adam,
>
> On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> >
> > I think it should be as simple as for each of "busy" and
> > "ready", render the facet if it's present, the icon if it's not.
>
>
> The only issue with that behavior is most common usage. I think the most
> common usage with facets is going to be a "busy" facet and no "ready" (to
> mimic GMail behavior for example). Personally, that's the way I would use
> it. If that's really the most common case, then it should be "as soon as a
> facet is specified, rendered or not, no icon will be rendered". But, if we
> think the most common case is going to be with both facets, then I agree
> with your suggestion.
>
> ~ Simon
>
>
> -- Adam
> >
> >
> > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > Hmm not as simple as I though. Before pushing a patch let decide on
> > the
> > > behavior for every use case:
> > >
> > > Both facets are specified and rendered --> Don't render any icon
> > > Both facets are specified but only one is rendered --> ?
> > > Both facets are specified but neither are rendered --> ?
> > > Only one facet is specified and rendered --> Don't render any icon or
> >
> > > render the icon of the missing facet?
> > > Only one facet is specified but not rendered --> ?
> > > No facet is specified --> Render both icons
> > >
> > > ~ Simon
> > >
> > >
> > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > >
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > that sounds like the best solution.
> > > > >
> > > > > On 9/18/07, Adam Winer < awiner@gmail.com > wrote:
> > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > for an attribute at all.
> > > > > >
> > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > can render two statusIndicators.
> > > > > >
> > > > > > -- Adam
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com > wrote:
> > > > > > > > Speaking of which, I forgot to add skin documentation. I'll
> > do
> > > that right
> > > > > > > > away.
> > > > > > > >
> > > > > > > > I would also like to add a new attribute to skip the icon
> > > rendering. If it
> > > > > > > > hasn't been of backward compatibility, I would have simply
> > removed
> > > them
> > > > > > >
> > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > shouldn't
> > > > > > > render the "default" icon,
> > > > > > > glad you pointed it out now.
> > > > > > >
> > > > > > > > since it's easily doable with a combination of facet and
> > tr:icon,
> > > but since
> > > > > > > > we had a release with the statusIndicator already, that's
> > out of
> > > question.
> > > > > > > > So, what I need now is a decent attribute name. What do you
> > think
> > > of
> > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > >
> > > > > > > I tend to like renderFacetsOnly, because that what you added
> > where
> > > facets.
> > > > > > >
> > > > > > > Perhaps, we can change that soon, that when facet's are
> > specified,
> > > we
> > > > > > > don't render the "default" icon.
> > > > > > >
> > > > > > > -Matthias
> > > > > > >
> > > > > > > >
> > > > > > > > ~ Simon
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> > >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hello Adam,
On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
>
> I think it should be as simple as for each of "busy" and
> "ready", render the facet if it's present, the icon if it's not.
The only issue with that behavior is most common usage. I think the most
common usage with facets is going to be a "busy" facet and no "ready" (to
mimic GMail behavior for example). Personally, that's the way I would use
it. If that's really the most common case, then it should be "as soon as a
facet is specified, rendered or not, no icon will be rendered". But, if we
think the most common case is going to be with both facets, then I agree
with your suggestion.
~ Simon
-- Adam
>
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Hmm not as simple as I though. Before pushing a patch let decide on the
> > behavior for every use case:
> >
> > Both facets are specified and rendered --> Don't render any icon
> > Both facets are specified but only one is rendered --> ?
> > Both facets are specified but neither are rendered --> ?
> > Only one facet is specified and rendered --> Don't render any icon or
> > render the icon of the missing facet?
> > Only one facet is specified but not rendered --> ?
> > No facet is specified --> Render both icons
> >
> > ~ Simon
> >
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > Or put tr:icon in the facet. Yeah, that sound good too.
> > >
> > >
> > >
> > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > that sounds like the best solution.
> > > >
> > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > for an attribute at all.
> > > > >
> > > > > Anyone that desperately needs both the facet and the icon
> > > > > can render two statusIndicators.
> > > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> > that right
> > > > > > > away.
> > > > > > >
> > > > > > > I would also like to add a new attribute to skip the icon
> > rendering. If it
> > > > > > > hasn't been of backward compatibility, I would have simply
> removed
> > them
> > > > > >
> > > > > > I added a demo usage of the facet's, I was thinking, that it
> > shouldn't
> > > > > > render the "default" icon,
> > > > > > glad you pointed it out now.
> > > > > >
> > > > > > > since it's easily doable with a combination of facet and
> tr:icon,
> > but since
> > > > > > > we had a release with the statusIndicator already, that's out
> of
> > question.
> > > > > > > So, what I need now is a decent attribute name. What do you
> think
> > of
> > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > >
> > > > > > I tend to like renderFacetsOnly, because that what you added
> where
> > facets.
> > > > > >
> > > > > > Perhaps, we can change that soon, that when facet's are
> specified,
> > we
> > > > > > don't render the "default" icon.
> > > > > >
> > > > > > -Matthias
> > > > > >
> > > > > > >
> > > > > > > ~ Simon
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
I think it should be as simple as for each of "busy" and
"ready", render the facet if it's present, the icon if it's not.
-- Adam
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> Hmm not as simple as I though. Before pushing a patch let decide on the
> behavior for every use case:
>
> Both facets are specified and rendered --> Don't render any icon
> Both facets are specified but only one is rendered --> ?
> Both facets are specified but neither are rendered --> ?
> Only one facet is specified and rendered --> Don't render any icon or
> render the icon of the missing facet?
> Only one facet is specified but not rendered --> ?
> No facet is specified --> Render both icons
>
> ~ Simon
>
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Or put tr:icon in the facet. Yeah, that sound good too.
> >
> >
> >
> > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > that sounds like the best solution.
> > >
> > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > IMO, if we have a facet, we don't render the icon. No need
> > > > for an attribute at all.
> > > >
> > > > Anyone that desperately needs both the facet and the icon
> > > > can render two statusIndicators.
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > Hi,
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> that right
> > > > > > away.
> > > > > >
> > > > > > I would also like to add a new attribute to skip the icon
> rendering. If it
> > > > > > hasn't been of backward compatibility, I would have simply removed
> them
> > > > >
> > > > > I added a demo usage of the facet's, I was thinking, that it
> shouldn't
> > > > > render the "default" icon,
> > > > > glad you pointed it out now.
> > > > >
> > > > > > since it's easily doable with a combination of facet and tr:icon,
> but since
> > > > > > we had a release with the statusIndicator already, that's out of
> question.
> > > > > > So, what I need now is a decent attribute name. What do you think
> of
> > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > >
> > > > > I tend to like renderFacetsOnly, because that what you added where
> facets.
> > > > >
> > > > > Perhaps, we can change that soon, that when facet's are specified,
> we
> > > > > don't render the "default" icon.
> > > > >
> > > > > -Matthias
> > > > >
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
IIRC, the blocking div is some oooold content rendered by the
long-ago ADF PPR code, never even turned on in Trinidad.
If we're going to do any cursor manipulation, I agree that it shouldn't
be on statusIndicator. It might be a skinning property for
af|document.
-- Adam
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> There is already a blocking panel rendered by Trinidad. Looks like this:
>
> <div id="_pprBlockingDiv" onkeypress="return false;" onmouseup="return
> false;" onmousedown="return false;" onkeyup="return false;"
> onkeydown="return false;" style="position: absolute; left: 0pt; top:
> 0pt; width: 0pt; height: 0pt; cursor: wait;" onclick="return
> _pprConsumeClick(event);"/>
>
> Not sure if you would want a component that simply shows this or not,
> I would think a public javascript API method may be a more obvious
> choice?
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Another way would be a "blocking panel" component that you set in the
> > statusIndicator's busy facet. Blocking panel skinning could be set to
> > absolute positioning to cover the whole screen and apply transparency
> > masking. Some JavaScript could also be added to it to prevent event
> > bubbling. That would effectively block everything during PPR events.
> >
> > That being said, you still didn't give me your input on what should be
> > rendered when only one facet is specified. ;P
> >
> >
> > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > There is no reason to change the cursor unless you want the GUI to be
> > > unresponsive to clicks and key presses right? The goal of a busy
> > > cursor would be to block any user input and let them know things are
> > > busy. In that case this works:
> > >
> > > <tr:commandLink partialSubmit="true" blocking="true" />
> > >
> > > Then if that is indeed what is desired, then maybe what is best is to
> > > have all components that have "autoSubmit" support also support
> > > "blocking".
> > >
> > > Along with that, perhaps the ability for blocking should also be added
> > > to the JavaScript call "TrPage.getInstance().sendPartialFormPost"
> > >
> > > I would see this as a more flexible architecture, as it leaves the
> > > choice of whether or not to block user input up to each control
> > > instead of making the blocking a choice of the status indicator.
> > >
> > > Different approaches could be (1) always block on PPR or (2) block on
> > > certain types of PPR only or (3) block on the majority PPR but with
> > > the occasional exception (like a poll for example).
> > >
> > > Just my $.02
> > >
> > > -Andrew
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > A way to set the cursor directly would be nice. I'm sure we're going to
> > see
> > > > users wanting that. Is there a way to directly set the current cursor?
> > > > Dunno, some obscure JavaScript function...
> > > >
> > > > Also, I could use more input on the indicator behavior in case only one
> > > > facet is specified and/or rendered.
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > ...was just a thought ... :-)
> > > > >
> > > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > > BTW: this does work, but is ugly:
> > > > > >
> > > > > > BODY * {
> > > > > > cursor: pointer !important;
> > > > > > }
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Andrew Robinson <andrew.rw.robinson@gmail.com > wrote:
> > > > > > > That does not fully work, in Firefox at least (just tried it, the
> > > > > > > cursor still reverts to an I-Beam for input text boxes for
> > example)
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > It's possible to set the cursor on the body node, would have to
> > use
> > > > a skin
> > > > > > > > property rather than a style property, but I'm not sure I like
> > that.
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Andrew Robinson < andrew.rw.robinson@gmail.com>
> > wrote:
> > > > > > > > > I'm not sure a cursor will work. The cursor applies to the
> > > > front-most
> > > > > > > > > element underneath the cursor. The only way, that I am aware
> > of,
> > > > to
> > > > > > > > > get a global cursor is to float (using absolute positioning
> > and
> > > > > > > > > z-index) an HTML element (like a DIV) over the entire page.
> > This
> > > > is
> > > > > > > > > what the "blocking" functionality already does in Trinidad (I
> > > > > > > > > believe).
> > > > > > > > >
> > > > > > > > > So really, is it not the job of the programmer to ensure the
> > PPR
> > > > > > > > > request is a blocking request and not the job of the status
> > > > indicator
> > > > > > > > > to change the cursor?
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > > > Hmm I don't think this should be directly in the indicator
> > > > contract. If
> > > > > > > > it
> > > > > > > > > > is, then I think it should be a new "type" attribute on the
> > > > status
> > > > > > > > indicator
> > > > > > > > > > with the following values:
> > > > > > > > > >
> > > > > > > > > > "icon": render default icons (default value)
> > > > > > > > > > "cursor": change the cursor on document level (requires a
> > way to
> > > > > > > > specified
> > > > > > > > > > the busy and ready cursor though)
> > > > > > > > > > "facets": render busy and ready facets
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > > > > > one more,
> > > > > > > > > > >
> > > > > > > > > > > what about changing the cursor, when statusIndicator is
> > busy ?
> > > > > > > > > > >
> > > > > > > > > > > -M
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> > wrote:
> > > > > > > > > > > > I think
> > > > > > > > > > > >
> > > > > > > > > > > > no facet => icon is rendered;
> > > > > > > > > > > > otherwise, no icon is rendered.
> > > > > > > > > > > >
> > > > > > > > > > > > -M
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > > > wrote:
> > > > > > > > > > > > > Hmm not as simple as I though. Before pushing a patch
> > let
> > > > decide
> > > > > > > > on
> > > > > > > > > > the
> > > > > > > > > > > > > behavior for every use case:
> > > > > > > > > > > > >
> > > > > > > > > > > > > Both facets are specified and rendered --> Don't
> > render
> > > > any icon
> > > > > > > > > > > > > Both facets are specified but only one is rendered -->
> > ?
> > > > > > > > > > > > > Both facets are specified but neither are rendered
> > --> ?
> > > > > > > > > > > > > Only one facet is specified and rendered --> Don't
> > render
> > > > any
> > > > > > > > icon or
> > > > > > > > > > > > > render the icon of the missing facet?
> > > > > > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > > > > > >
> > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > > > wrote:
> > > > > > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good
> > too.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org
> > >
> > > > wrote:
> > > > > > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > > > > > > IMO, if we have a facet, we don't render the
> > icon.
> > > > No need
> > > > > > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > Anyone that desperately needs both the facet and
> > the
> > > > icon
> > > > > > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > -- Adam
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf
> > <matzew@apache.org >
> > > > wrote:
> > > > > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> > > > simon.lessard.3@gmail.com >
> > > > > > > > wrote:
> > > > > > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> > > > documentation.
> > > > > > > > I'll
> > > > > > > > > > do
> > > > > > > > > > > > > that right
> > > > > > > > > > > > > > > > > > away.
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > I would also like to add a new attribute to
> > skip
> > > > the
> > > > > > > > icon
> > > > > > > > > > > > > rendering. If it
> > > > > > > > > > > > > > > > > > hasn't been of backward compatibility, I
> > would
> > > > have
> > > > > > > > simply
> > > > > > > > > > removed
> > > > > > > > > > > > > them
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > I added a demo usage of the facet's, I was
> > > > thinking, that
> > > > > > > > it
> > > > > > > > > > > > > shouldn't
> > > > > > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > since it's easily doable with a combination
> > of
> > > > facet and
> > > > > > > > > > tr:icon,
> > > > > > > > > > > > > but since
> > > > > > > > > > > > > > > > > > we had a release with the statusIndicator
> > > > already,
> > > > > > > > that's
> > > > > > > > > > out of
> > > > > > > > > > > > > question.
> > > > > > > > > > > > > > > > > > So, what I need now is a decent attribute
> > name.
> > > > What do
> > > > > > > > you
> > > > > > > > > > think
> > > > > > > > > > > > > of
> > > > > > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > I tend to like renderFacetsOnly, because that
> > what
> > > > you
> > > > > > > > added
> > > > > > > > > > where
> > > > > > > > > > > > > facets.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Perhaps, we can change that soon, that when
> > > > facet's are
> > > > > > > > > > specified,
> > > > > > > > > > > > > we
> > > > > > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > > > blog:
> > > > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > blog:
> > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
That's the div shown when there's a visible dialog I think, because
everything still works during PPR events.
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
>
> There is already a blocking panel rendered by Trinidad. Looks like this:
>
> <div id="_pprBlockingDiv" onkeypress="return false;" onmouseup="return
> false;" onmousedown="return false;" onkeyup="return false;"
> onkeydown="return false;" style="position: absolute; left: 0pt; top:
> 0pt; width: 0pt; height: 0pt; cursor: wait;" onclick="return
> _pprConsumeClick(event);"/>
>
> Not sure if you would want a component that simply shows this or not,
> I would think a public javascript API method may be a more obvious
> choice?
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Another way would be a "blocking panel" component that you set in the
> > statusIndicator's busy facet. Blocking panel skinning could be set to
> > absolute positioning to cover the whole screen and apply transparency
> > masking. Some JavaScript could also be added to it to prevent event
> > bubbling. That would effectively block everything during PPR events.
> >
> > That being said, you still didn't give me your input on what should be
> > rendered when only one facet is specified. ;P
> >
> >
> > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > There is no reason to change the cursor unless you want the GUI to be
> > > unresponsive to clicks and key presses right? The goal of a busy
> > > cursor would be to block any user input and let them know things are
> > > busy. In that case this works:
> > >
> > > <tr:commandLink partialSubmit="true" blocking="true" />
> > >
> > > Then if that is indeed what is desired, then maybe what is best is to
> > > have all components that have "autoSubmit" support also support
> > > "blocking".
> > >
> > > Along with that, perhaps the ability for blocking should also be added
> > > to the JavaScript call "TrPage.getInstance().sendPartialFormPost"
> > >
> > > I would see this as a more flexible architecture, as it leaves the
> > > choice of whether or not to block user input up to each control
> > > instead of making the blocking a choice of the status indicator.
> > >
> > > Different approaches could be (1) always block on PPR or (2) block on
> > > certain types of PPR only or (3) block on the majority PPR but with
> > > the occasional exception (like a poll for example).
> > >
> > > Just my $.02
> > >
> > > -Andrew
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > A way to set the cursor directly would be nice. I'm sure we're going
> to
> > see
> > > > users wanting that. Is there a way to directly set the current
> cursor?
> > > > Dunno, some obscure JavaScript function...
> > > >
> > > > Also, I could use more input on the indicator behavior in case only
> one
> > > > facet is specified and/or rendered.
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > ...was just a thought ... :-)
> > > > >
> > > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > > BTW: this does work, but is ugly:
> > > > > >
> > > > > > BODY * {
> > > > > > cursor: pointer !important;
> > > > > > }
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Andrew Robinson <andrew.rw.robinson@gmail.com >
> wrote:
> > > > > > > That does not fully work, in Firefox at least (just tried it,
> the
> > > > > > > cursor still reverts to an I-Beam for input text boxes for
> > example)
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > It's possible to set the cursor on the body node, would have
> to
> > use
> > > > a skin
> > > > > > > > property rather than a style property, but I'm not sure I
> like
> > that.
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Andrew Robinson < andrew.rw.robinson@gmail.com>
> > wrote:
> > > > > > > > > I'm not sure a cursor will work. The cursor applies to the
> > > > front-most
> > > > > > > > > element underneath the cursor. The only way, that I am
> aware
> > of,
> > > > to
> > > > > > > > > get a global cursor is to float (using absolute
> positioning
> > and
> > > > > > > > > z-index) an HTML element (like a DIV) over the entire
> page.
> > This
> > > > is
> > > > > > > > > what the "blocking" functionality already does in Trinidad
> (I
> > > > > > > > > believe).
> > > > > > > > >
> > > > > > > > > So really, is it not the job of the programmer to ensure
> the
> > PPR
> > > > > > > > > request is a blocking request and not the job of the
> status
> > > > indicator
> > > > > > > > > to change the cursor?
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> wrote:
> > > > > > > > > > Hmm I don't think this should be directly in the
> indicator
> > > > contract. If
> > > > > > > > it
> > > > > > > > > > is, then I think it should be a new "type" attribute on
> the
> > > > status
> > > > > > > > indicator
> > > > > > > > > > with the following values:
> > > > > > > > > >
> > > > > > > > > > "icon": render default icons (default value)
> > > > > > > > > > "cursor": change the cursor on document level (requires
> a
> > way to
> > > > > > > > specified
> > > > > > > > > > the busy and ready cursor though)
> > > > > > > > > > "facets": render busy and ready facets
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org>
> wrote:
> > > > > > > > > > > one more,
> > > > > > > > > > >
> > > > > > > > > > > what about changing the cursor, when statusIndicator
> is
> > busy ?
> > > > > > > > > > >
> > > > > > > > > > > -M
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> > wrote:
> > > > > > > > > > > > I think
> > > > > > > > > > > >
> > > > > > > > > > > > no facet => icon is rendered;
> > > > > > > > > > > > otherwise, no icon is rendered.
> > > > > > > > > > > >
> > > > > > > > > > > > -M
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Simon Lessard <
> simon.lessard.3@gmail.com>
> > > > wrote:
> > > > > > > > > > > > > Hmm not as simple as I though. Before pushing a
> patch
> > let
> > > > decide
> > > > > > > > on
> > > > > > > > > > the
> > > > > > > > > > > > > behavior for every use case:
> > > > > > > > > > > > >
> > > > > > > > > > > > > Both facets are specified and rendered --> Don't
> > render
> > > > any icon
> > > > > > > > > > > > > Both facets are specified but only one is rendered
> -->
> > ?
> > > > > > > > > > > > > Both facets are specified but neither are
> rendered
> > --> ?
> > > > > > > > > > > > > Only one facet is specified and rendered -->
> Don't
> > render
> > > > any
> > > > > > > > icon or
> > > > > > > > > > > > > render the icon of the missing facet?
> > > > > > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > > > > > >
> > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> simon.lessard.3@gmail.com>
> > > > wrote:
> > > > > > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound
> good
> > too.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf <
> matzew@apache.org
> > >
> > > > wrote:
> > > > > > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com>
> wrote:
> > > > > > > > > > > > > > > > IMO, if we have a facet, we don't render the
> > icon.
> > > > No need
> > > > > > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > Anyone that desperately needs both the facet
> and
> > the
> > > > icon
> > > > > > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > -- Adam
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf
> > <matzew@apache.org >
> > > > wrote:
> > > > > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> > > > simon.lessard.3@gmail.com >
> > > > > > > > wrote:
> > > > > > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> > > > documentation.
> > > > > > > > I'll
> > > > > > > > > > do
> > > > > > > > > > > > > that right
> > > > > > > > > > > > > > > > > > away.
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > I would also like to add a new attribute
> to
> > skip
> > > > the
> > > > > > > > icon
> > > > > > > > > > > > > rendering. If it
> > > > > > > > > > > > > > > > > > hasn't been of backward compatibility, I
> > would
> > > > have
> > > > > > > > simply
> > > > > > > > > > removed
> > > > > > > > > > > > > them
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > I added a demo usage of the facet's, I was
> > > > thinking, that
> > > > > > > > it
> > > > > > > > > > > > > shouldn't
> > > > > > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > since it's easily doable with a
> combination
> > of
> > > > facet and
> > > > > > > > > > tr:icon,
> > > > > > > > > > > > > but since
> > > > > > > > > > > > > > > > > > we had a release with the
> statusIndicator
> > > > already,
> > > > > > > > that's
> > > > > > > > > > out of
> > > > > > > > > > > > > question.
> > > > > > > > > > > > > > > > > > So, what I need now is a decent
> attribute
> > name.
> > > > What do
> > > > > > > > you
> > > > > > > > > > think
> > > > > > > > > > > > > of
> > > > > > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > I tend to like renderFacetsOnly, because
> that
> > what
> > > > you
> > > > > > > > added
> > > > > > > > > > where
> > > > > > > > > > > > > facets.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Perhaps, we can change that soon, that
> when
> > > > facet's are
> > > > > > > > > > specified,
> > > > > > > > > > > > > we
> > > > > > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > > > blog:
> > > > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > blog:
> > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
There is already a blocking panel rendered by Trinidad. Looks like this:
<div id="_pprBlockingDiv" onkeypress="return false;" onmouseup="return
false;" onmousedown="return false;" onkeyup="return false;"
onkeydown="return false;" style="position: absolute; left: 0pt; top:
0pt; width: 0pt; height: 0pt; cursor: wait;" onclick="return
_pprConsumeClick(event);"/>
Not sure if you would want a component that simply shows this or not,
I would think a public javascript API method may be a more obvious
choice?
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> Another way would be a "blocking panel" component that you set in the
> statusIndicator's busy facet. Blocking panel skinning could be set to
> absolute positioning to cover the whole screen and apply transparency
> masking. Some JavaScript could also be added to it to prevent event
> bubbling. That would effectively block everything during PPR events.
>
> That being said, you still didn't give me your input on what should be
> rendered when only one facet is specified. ;P
>
>
> On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > There is no reason to change the cursor unless you want the GUI to be
> > unresponsive to clicks and key presses right? The goal of a busy
> > cursor would be to block any user input and let them know things are
> > busy. In that case this works:
> >
> > <tr:commandLink partialSubmit="true" blocking="true" />
> >
> > Then if that is indeed what is desired, then maybe what is best is to
> > have all components that have "autoSubmit" support also support
> > "blocking".
> >
> > Along with that, perhaps the ability for blocking should also be added
> > to the JavaScript call "TrPage.getInstance().sendPartialFormPost"
> >
> > I would see this as a more flexible architecture, as it leaves the
> > choice of whether or not to block user input up to each control
> > instead of making the blocking a choice of the status indicator.
> >
> > Different approaches could be (1) always block on PPR or (2) block on
> > certain types of PPR only or (3) block on the majority PPR but with
> > the occasional exception (like a poll for example).
> >
> > Just my $.02
> >
> > -Andrew
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > A way to set the cursor directly would be nice. I'm sure we're going to
> see
> > > users wanting that. Is there a way to directly set the current cursor?
> > > Dunno, some obscure JavaScript function...
> > >
> > > Also, I could use more input on the indicator behavior in case only one
> > > facet is specified and/or rendered.
> > >
> > >
> > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > ...was just a thought ... :-)
> > > >
> > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > BTW: this does work, but is ugly:
> > > > >
> > > > > BODY * {
> > > > > cursor: pointer !important;
> > > > > }
> > > > >
> > > > >
> > > > > On 9/18/07, Andrew Robinson <andrew.rw.robinson@gmail.com > wrote:
> > > > > > That does not fully work, in Firefox at least (just tried it, the
> > > > > > cursor still reverts to an I-Beam for input text boxes for
> example)
> > > > > >
> > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > It's possible to set the cursor on the body node, would have to
> use
> > > a skin
> > > > > > > property rather than a style property, but I'm not sure I like
> that.
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Andrew Robinson < andrew.rw.robinson@gmail.com>
> wrote:
> > > > > > > > I'm not sure a cursor will work. The cursor applies to the
> > > front-most
> > > > > > > > element underneath the cursor. The only way, that I am aware
> of,
> > > to
> > > > > > > > get a global cursor is to float (using absolute positioning
> and
> > > > > > > > z-index) an HTML element (like a DIV) over the entire page.
> This
> > > is
> > > > > > > > what the "blocking" functionality already does in Trinidad (I
> > > > > > > > believe).
> > > > > > > >
> > > > > > > > So really, is it not the job of the programmer to ensure the
> PPR
> > > > > > > > request is a blocking request and not the job of the status
> > > indicator
> > > > > > > > to change the cursor?
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > > Hmm I don't think this should be directly in the indicator
> > > contract. If
> > > > > > > it
> > > > > > > > > is, then I think it should be a new "type" attribute on the
> > > status
> > > > > > > indicator
> > > > > > > > > with the following values:
> > > > > > > > >
> > > > > > > > > "icon": render default icons (default value)
> > > > > > > > > "cursor": change the cursor on document level (requires a
> way to
> > > > > > > specified
> > > > > > > > > the busy and ready cursor though)
> > > > > > > > > "facets": render busy and ready facets
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > > > > one more,
> > > > > > > > > >
> > > > > > > > > > what about changing the cursor, when statusIndicator is
> busy ?
> > > > > > > > > >
> > > > > > > > > > -M
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> wrote:
> > > > > > > > > > > I think
> > > > > > > > > > >
> > > > > > > > > > > no facet => icon is rendered;
> > > > > > > > > > > otherwise, no icon is rendered.
> > > > > > > > > > >
> > > > > > > > > > > -M
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > > wrote:
> > > > > > > > > > > > Hmm not as simple as I though. Before pushing a patch
> let
> > > decide
> > > > > > > on
> > > > > > > > > the
> > > > > > > > > > > > behavior for every use case:
> > > > > > > > > > > >
> > > > > > > > > > > > Both facets are specified and rendered --> Don't
> render
> > > any icon
> > > > > > > > > > > > Both facets are specified but only one is rendered -->
> ?
> > > > > > > > > > > > Both facets are specified but neither are rendered
> --> ?
> > > > > > > > > > > > Only one facet is specified and rendered --> Don't
> render
> > > any
> > > > > > > icon or
> > > > > > > > > > > > render the icon of the missing facet?
> > > > > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > > > > >
> > > > > > > > > > > > ~ Simon
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > > wrote:
> > > > > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good
> too.
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org
> >
> > > wrote:
> > > > > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > > > > > IMO, if we have a facet, we don't render the
> icon.
> > > No need
> > > > > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Anyone that desperately needs both the facet and
> the
> > > icon
> > > > > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > -- Adam
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf
> <matzew@apache.org >
> > > wrote:
> > > > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> > > simon.lessard.3@gmail.com >
> > > > > > > wrote:
> > > > > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> > > documentation.
> > > > > > > I'll
> > > > > > > > > do
> > > > > > > > > > > > that right
> > > > > > > > > > > > > > > > > away.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > I would also like to add a new attribute to
> skip
> > > the
> > > > > > > icon
> > > > > > > > > > > > rendering. If it
> > > > > > > > > > > > > > > > > hasn't been of backward compatibility, I
> would
> > > have
> > > > > > > simply
> > > > > > > > > removed
> > > > > > > > > > > > them
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > I added a demo usage of the facet's, I was
> > > thinking, that
> > > > > > > it
> > > > > > > > > > > > shouldn't
> > > > > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > since it's easily doable with a combination
> of
> > > facet and
> > > > > > > > > tr:icon,
> > > > > > > > > > > > but since
> > > > > > > > > > > > > > > > > we had a release with the statusIndicator
> > > already,
> > > > > > > that's
> > > > > > > > > out of
> > > > > > > > > > > > question.
> > > > > > > > > > > > > > > > > So, what I need now is a decent attribute
> name.
> > > What do
> > > > > > > you
> > > > > > > > > think
> > > > > > > > > > > > of
> > > > > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > I tend to like renderFacetsOnly, because that
> what
> > > you
> > > > > > > added
> > > > > > > > > where
> > > > > > > > > > > > facets.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > Perhaps, we can change that soon, that when
> > > facet's are
> > > > > > > > > specified,
> > > > > > > > > > > > we
> > > > > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > > blog:
> > > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > --
> > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > blog:
> > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Another way would be a "blocking panel" component that you set in the
statusIndicator's busy facet. Blocking panel skinning could be set to
absolute positioning to cover the whole screen and apply transparency
masking. Some JavaScript could also be added to it to prevent event
bubbling. That would effectively block everything during PPR events.
That being said, you still didn't give me your input on what should be
rendered when only one facet is specified. ;P
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
>
> There is no reason to change the cursor unless you want the GUI to be
> unresponsive to clicks and key presses right? The goal of a busy
> cursor would be to block any user input and let them know things are
> busy. In that case this works:
>
> <tr:commandLink partialSubmit="true" blocking="true" />
>
> Then if that is indeed what is desired, then maybe what is best is to
> have all components that have "autoSubmit" support also support
> "blocking".
>
> Along with that, perhaps the ability for blocking should also be added
> to the JavaScript call "TrPage.getInstance().sendPartialFormPost"
>
> I would see this as a more flexible architecture, as it leaves the
> choice of whether or not to block user input up to each control
> instead of making the blocking a choice of the status indicator.
>
> Different approaches could be (1) always block on PPR or (2) block on
> certain types of PPR only or (3) block on the majority PPR but with
> the occasional exception (like a poll for example).
>
> Just my $.02
>
> -Andrew
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > A way to set the cursor directly would be nice. I'm sure we're going to
> see
> > users wanting that. Is there a way to directly set the current cursor?
> > Dunno, some obscure JavaScript function...
> >
> > Also, I could use more input on the indicator behavior in case only one
> > facet is specified and/or rendered.
> >
> >
> > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > ...was just a thought ... :-)
> > >
> > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > BTW: this does work, but is ugly:
> > > >
> > > > BODY * {
> > > > cursor: pointer !important;
> > > > }
> > > >
> > > >
> > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > That does not fully work, in Firefox at least (just tried it, the
> > > > > cursor still reverts to an I-Beam for input text boxes for
> example)
> > > > >
> > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > It's possible to set the cursor on the body node, would have to
> use
> > a skin
> > > > > > property rather than a style property, but I'm not sure I like
> that.
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Andrew Robinson <an...@gmail.com>
> wrote:
> > > > > > > I'm not sure a cursor will work. The cursor applies to the
> > front-most
> > > > > > > element underneath the cursor. The only way, that I am aware
> of,
> > to
> > > > > > > get a global cursor is to float (using absolute positioning
> and
> > > > > > > z-index) an HTML element (like a DIV) over the entire page.
> This
> > is
> > > > > > > what the "blocking" functionality already does in Trinidad (I
> > > > > > > believe).
> > > > > > >
> > > > > > > So really, is it not the job of the programmer to ensure the
> PPR
> > > > > > > request is a blocking request and not the job of the status
> > indicator
> > > > > > > to change the cursor?
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > Hmm I don't think this should be directly in the indicator
> > contract. If
> > > > > > it
> > > > > > > > is, then I think it should be a new "type" attribute on the
> > status
> > > > > > indicator
> > > > > > > > with the following values:
> > > > > > > >
> > > > > > > > "icon": render default icons (default value)
> > > > > > > > "cursor": change the cursor on document level (requires a
> way to
> > > > > > specified
> > > > > > > > the busy and ready cursor though)
> > > > > > > > "facets": render busy and ready facets
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > > > one more,
> > > > > > > > >
> > > > > > > > > what about changing the cursor, when statusIndicator is
> busy ?
> > > > > > > > >
> > > > > > > > > -M
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> wrote:
> > > > > > > > > > I think
> > > > > > > > > >
> > > > > > > > > > no facet => icon is rendered;
> > > > > > > > > > otherwise, no icon is rendered.
> > > > > > > > > >
> > > > > > > > > > -M
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > wrote:
> > > > > > > > > > > Hmm not as simple as I though. Before pushing a patch
> let
> > decide
> > > > > > on
> > > > > > > > the
> > > > > > > > > > > behavior for every use case:
> > > > > > > > > > >
> > > > > > > > > > > Both facets are specified and rendered --> Don't
> render
> > any icon
> > > > > > > > > > > Both facets are specified but only one is rendered -->
> ?
> > > > > > > > > > > Both facets are specified but neither are rendered
> --> ?
> > > > > > > > > > > Only one facet is specified and rendered --> Don't
> render
> > any
> > > > > > icon or
> > > > > > > > > > > render the icon of the missing facet?
> > > > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > > > >
> > > > > > > > > > > ~ Simon
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> > wrote:
> > > > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good
> too.
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> > wrote:
> > > > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > > > > IMO, if we have a facet, we don't render the
> icon.
> > No need
> > > > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Anyone that desperately needs both the facet and
> the
> > icon
> > > > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > -- Adam
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf <
> matzew@apache.org >
> > wrote:
> > > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> > simon.lessard.3@gmail.com >
> > > > > > wrote:
> > > > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> > documentation.
> > > > > > I'll
> > > > > > > > do
> > > > > > > > > > > that right
> > > > > > > > > > > > > > > > away.
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > I would also like to add a new attribute to
> skip
> > the
> > > > > > icon
> > > > > > > > > > > rendering. If it
> > > > > > > > > > > > > > > > hasn't been of backward compatibility, I
> would
> > have
> > > > > > simply
> > > > > > > > removed
> > > > > > > > > > > them
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > I added a demo usage of the facet's, I was
> > thinking, that
> > > > > > it
> > > > > > > > > > > shouldn't
> > > > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > since it's easily doable with a combination
> of
> > facet and
> > > > > > > > tr:icon,
> > > > > > > > > > > but since
> > > > > > > > > > > > > > > > we had a release with the statusIndicator
> > already,
> > > > > > that's
> > > > > > > > out of
> > > > > > > > > > > question.
> > > > > > > > > > > > > > > > So, what I need now is a decent attribute
> name.
> > What do
> > > > > > you
> > > > > > > > think
> > > > > > > > > > > of
> > > > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > I tend to like renderFacetsOnly, because that
> what
> > you
> > > > > > added
> > > > > > > > where
> > > > > > > > > > > facets.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Perhaps, we can change that soon, that when
> > facet's are
> > > > > > > > specified,
> > > > > > > > > > > we
> > > > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > > blog:
> > > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > --
> > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > >
> > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > blog:
> > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
There is no reason to change the cursor unless you want the GUI to be
unresponsive to clicks and key presses right? The goal of a busy
cursor would be to block any user input and let them know things are
busy. In that case this works:
<tr:commandLink partialSubmit="true" blocking="true" />
Then if that is indeed what is desired, then maybe what is best is to
have all components that have "autoSubmit" support also support
"blocking".
Along with that, perhaps the ability for blocking should also be added
to the JavaScript call "TrPage.getInstance().sendPartialFormPost"
I would see this as a more flexible architecture, as it leaves the
choice of whether or not to block user input up to each control
instead of making the blocking a choice of the status indicator.
Different approaches could be (1) always block on PPR or (2) block on
certain types of PPR only or (3) block on the majority PPR but with
the occasional exception (like a poll for example).
Just my $.02
-Andrew
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> A way to set the cursor directly would be nice. I'm sure we're going to see
> users wanting that. Is there a way to directly set the current cursor?
> Dunno, some obscure JavaScript function...
>
> Also, I could use more input on the indicator behavior in case only one
> facet is specified and/or rendered.
>
>
> On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > ...was just a thought ... :-)
> >
> > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > BTW: this does work, but is ugly:
> > >
> > > BODY * {
> > > cursor: pointer !important;
> > > }
> > >
> > >
> > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > That does not fully work, in Firefox at least (just tried it, the
> > > > cursor still reverts to an I-Beam for input text boxes for example)
> > > >
> > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > It's possible to set the cursor on the body node, would have to use
> a skin
> > > > > property rather than a style property, but I'm not sure I like that.
> > > > >
> > > > >
> > > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > > I'm not sure a cursor will work. The cursor applies to the
> front-most
> > > > > > element underneath the cursor. The only way, that I am aware of,
> to
> > > > > > get a global cursor is to float (using absolute positioning and
> > > > > > z-index) an HTML element (like a DIV) over the entire page. This
> is
> > > > > > what the "blocking" functionality already does in Trinidad (I
> > > > > > believe).
> > > > > >
> > > > > > So really, is it not the job of the programmer to ensure the PPR
> > > > > > request is a blocking request and not the job of the status
> indicator
> > > > > > to change the cursor?
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Hmm I don't think this should be directly in the indicator
> contract. If
> > > > > it
> > > > > > > is, then I think it should be a new "type" attribute on the
> status
> > > > > indicator
> > > > > > > with the following values:
> > > > > > >
> > > > > > > "icon": render default icons (default value)
> > > > > > > "cursor": change the cursor on document level (requires a way to
> > > > > specified
> > > > > > > the busy and ready cursor though)
> > > > > > > "facets": render busy and ready facets
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > > one more,
> > > > > > > >
> > > > > > > > what about changing the cursor, when statusIndicator is busy ?
> > > > > > > >
> > > > > > > > -M
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org > wrote:
> > > > > > > > > I think
> > > > > > > > >
> > > > > > > > > no facet => icon is rendered;
> > > > > > > > > otherwise, no icon is rendered.
> > > > > > > > >
> > > > > > > > > -M
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> wrote:
> > > > > > > > > > Hmm not as simple as I though. Before pushing a patch let
> decide
> > > > > on
> > > > > > > the
> > > > > > > > > > behavior for every use case:
> > > > > > > > > >
> > > > > > > > > > Both facets are specified and rendered --> Don't render
> any icon
> > > > > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > > > > Only one facet is specified and rendered --> Don't render
> any
> > > > > icon or
> > > > > > > > > > render the icon of the missing facet?
> > > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > > >
> > > > > > > > > > ~ Simon
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com>
> wrote:
> > > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org >
> wrote:
> > > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > > > IMO, if we have a facet, we don't render the icon.
> No need
> > > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Anyone that desperately needs both the facet and the
> icon
> > > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > > >
> > > > > > > > > > > > > -- Adam
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org >
> wrote:
> > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> simon.lessard.3@gmail.com >
> > > > > wrote:
> > > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> documentation.
> > > > > I'll
> > > > > > > do
> > > > > > > > > > that right
> > > > > > > > > > > > > > > away.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > I would also like to add a new attribute to skip
> the
> > > > > icon
> > > > > > > > > > rendering. If it
> > > > > > > > > > > > > > > hasn't been of backward compatibility, I would
> have
> > > > > simply
> > > > > > > removed
> > > > > > > > > > them
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > I added a demo usage of the facet's, I was
> thinking, that
> > > > > it
> > > > > > > > > > shouldn't
> > > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > > since it's easily doable with a combination of
> facet and
> > > > > > > tr:icon,
> > > > > > > > > > but since
> > > > > > > > > > > > > > > we had a release with the statusIndicator
> already,
> > > > > that's
> > > > > > > out of
> > > > > > > > > > question.
> > > > > > > > > > > > > > > So, what I need now is a decent attribute name.
> What do
> > > > > you
> > > > > > > think
> > > > > > > > > > of
> > > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > I tend to like renderFacetsOnly, because that what
> you
> > > > > added
> > > > > > > where
> > > > > > > > > > facets.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Perhaps, we can change that soon, that when
> facet's are
> > > > > > > specified,
> > > > > > > > > > we
> > > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > --
> > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > blog:
> > > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
A way to set the cursor directly would be nice. I'm sure we're going to see
users wanting that. Is there a way to directly set the current cursor?
Dunno, some obscure JavaScript function...
Also, I could use more input on the indicator behavior in case only one
facet is specified and/or rendered.
On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
>
> ...was just a thought ... :-)
>
> On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > BTW: this does work, but is ugly:
> >
> > BODY * {
> > cursor: pointer !important;
> > }
> >
> >
> > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > That does not fully work, in Firefox at least (just tried it, the
> > > cursor still reverts to an I-Beam for input text boxes for example)
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > It's possible to set the cursor on the body node, would have to use
> a skin
> > > > property rather than a style property, but I'm not sure I like that.
> > > >
> > > >
> > > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > > I'm not sure a cursor will work. The cursor applies to the
> front-most
> > > > > element underneath the cursor. The only way, that I am aware of,
> to
> > > > > get a global cursor is to float (using absolute positioning and
> > > > > z-index) an HTML element (like a DIV) over the entire page. This
> is
> > > > > what the "blocking" functionality already does in Trinidad (I
> > > > > believe).
> > > > >
> > > > > So really, is it not the job of the programmer to ensure the PPR
> > > > > request is a blocking request and not the job of the status
> indicator
> > > > > to change the cursor?
> > > > >
> > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > Hmm I don't think this should be directly in the indicator
> contract. If
> > > > it
> > > > > > is, then I think it should be a new "type" attribute on the
> status
> > > > indicator
> > > > > > with the following values:
> > > > > >
> > > > > > "icon": render default icons (default value)
> > > > > > "cursor": change the cursor on document level (requires a way to
> > > > specified
> > > > > > the busy and ready cursor though)
> > > > > > "facets": render busy and ready facets
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > one more,
> > > > > > >
> > > > > > > what about changing the cursor, when statusIndicator is busy ?
> > > > > > >
> > > > > > > -M
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > I think
> > > > > > > >
> > > > > > > > no facet => icon is rendered;
> > > > > > > > otherwise, no icon is rendered.
> > > > > > > >
> > > > > > > > -M
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > > Hmm not as simple as I though. Before pushing a patch let
> decide
> > > > on
> > > > > > the
> > > > > > > > > behavior for every use case:
> > > > > > > > >
> > > > > > > > > Both facets are specified and rendered --> Don't render
> any icon
> > > > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > > > Only one facet is specified and rendered --> Don't render
> any
> > > > icon or
> > > > > > > > > render the icon of the missing facet?
> > > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > > No facet is specified --> Render both icons
> > > > > > > > >
> > > > > > > > > ~ Simon
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com>
> wrote:
> > > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org>
> wrote:
> > > > > > > > > > > that sounds like the best solution.
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > > IMO, if we have a facet, we don't render the
> icon. No need
> > > > > > > > > > > > for an attribute at all.
> > > > > > > > > > > >
> > > > > > > > > > > > Anyone that desperately needs both the facet and the
> icon
> > > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > > >
> > > > > > > > > > > > -- Adam
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org >
> wrote:
> > > > > > > > > > > > > Hi,
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/18/07, Simon Lessard <
> simon.lessard.3@gmail.com >
> > > > wrote:
> > > > > > > > > > > > > > Speaking of which, I forgot to add skin
> documentation.
> > > > I'll
> > > > > > do
> > > > > > > > > that right
> > > > > > > > > > > > > > away.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > I would also like to add a new attribute to skip
> the
> > > > icon
> > > > > > > > > rendering. If it
> > > > > > > > > > > > > > hasn't been of backward compatibility, I would
> have
> > > > simply
> > > > > > removed
> > > > > > > > > them
> > > > > > > > > > > > >
> > > > > > > > > > > > > I added a demo usage of the facet's, I was
> thinking, that
> > > > it
> > > > > > > > > shouldn't
> > > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > > >
> > > > > > > > > > > > > > since it's easily doable with a combination of
> facet and
> > > > > > tr:icon,
> > > > > > > > > but since
> > > > > > > > > > > > > > we had a release with the statusIndicator
> already,
> > > > that's
> > > > > > out of
> > > > > > > > > question.
> > > > > > > > > > > > > > So, what I need now is a decent attribute name.
> What do
> > > > you
> > > > > > think
> > > > > > > > > of
> > > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > > >
> > > > > > > > > > > > > I tend to like renderFacetsOnly, because that what
> you
> > > > added
> > > > > > where
> > > > > > > > > facets.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Perhaps, we can change that soon, that when
> facet's are
> > > > > > specified,
> > > > > > > > > we
> > > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > > >
> > > > > > > > > > > > > -Matthias
> > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > --
> > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > >
> > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > blog:
> > > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > >
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Matthias Wessendorf <ma...@apache.org>.
...was just a thought ... :-)
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> BTW: this does work, but is ugly:
>
> BODY * {
> cursor: pointer !important;
> }
>
>
> On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > That does not fully work, in Firefox at least (just tried it, the
> > cursor still reverts to an I-Beam for input text boxes for example)
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > It's possible to set the cursor on the body node, would have to use a skin
> > > property rather than a style property, but I'm not sure I like that.
> > >
> > >
> > > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > > I'm not sure a cursor will work. The cursor applies to the front-most
> > > > element underneath the cursor. The only way, that I am aware of, to
> > > > get a global cursor is to float (using absolute positioning and
> > > > z-index) an HTML element (like a DIV) over the entire page. This is
> > > > what the "blocking" functionality already does in Trinidad (I
> > > > believe).
> > > >
> > > > So really, is it not the job of the programmer to ensure the PPR
> > > > request is a blocking request and not the job of the status indicator
> > > > to change the cursor?
> > > >
> > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > Hmm I don't think this should be directly in the indicator contract. If
> > > it
> > > > > is, then I think it should be a new "type" attribute on the status
> > > indicator
> > > > > with the following values:
> > > > >
> > > > > "icon": render default icons (default value)
> > > > > "cursor": change the cursor on document level (requires a way to
> > > specified
> > > > > the busy and ready cursor though)
> > > > > "facets": render busy and ready facets
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > one more,
> > > > > >
> > > > > > what about changing the cursor, when statusIndicator is busy ?
> > > > > >
> > > > > > -M
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > I think
> > > > > > >
> > > > > > > no facet => icon is rendered;
> > > > > > > otherwise, no icon is rendered.
> > > > > > >
> > > > > > > -M
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > Hmm not as simple as I though. Before pushing a patch let decide
> > > on
> > > > > the
> > > > > > > > behavior for every use case:
> > > > > > > >
> > > > > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > > Only one facet is specified and rendered --> Don't render any
> > > icon or
> > > > > > > > render the icon of the missing facet?
> > > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > > No facet is specified --> Render both icons
> > > > > > > >
> > > > > > > > ~ Simon
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > > > that sounds like the best solution.
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > > > > > for an attribute at all.
> > > > > > > > > > >
> > > > > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > > > > can render two statusIndicators.
> > > > > > > > > > >
> > > > > > > > > > > -- Adam
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > > > > > > > > > > Hi,
> > > > > > > > > > > >
> > > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> > > wrote:
> > > > > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> > > I'll
> > > > > do
> > > > > > > > that right
> > > > > > > > > > > > > away.
> > > > > > > > > > > > >
> > > > > > > > > > > > > I would also like to add a new attribute to skip the
> > > icon
> > > > > > > > rendering. If it
> > > > > > > > > > > > > hasn't been of backward compatibility, I would have
> > > simply
> > > > > removed
> > > > > > > > them
> > > > > > > > > > > >
> > > > > > > > > > > > I added a demo usage of the facet's, I was thinking, that
> > > it
> > > > > > > > shouldn't
> > > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > > >
> > > > > > > > > > > > > since it's easily doable with a combination of facet and
> > > > > tr:icon,
> > > > > > > > but since
> > > > > > > > > > > > > we had a release with the statusIndicator already,
> > > that's
> > > > > out of
> > > > > > > > question.
> > > > > > > > > > > > > So, what I need now is a decent attribute name. What do
> > > you
> > > > > think
> > > > > > > > of
> > > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > > >
> > > > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> > > added
> > > > > where
> > > > > > > > facets.
> > > > > > > > > > > >
> > > > > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > > > specified,
> > > > > > > > we
> > > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > > >
> > > > > > > > > > > > -Matthias
> > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > ~ Simon
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
BTW: this does work, but is ugly:
BODY * {
cursor: pointer !important;
}
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> That does not fully work, in Firefox at least (just tried it, the
> cursor still reverts to an I-Beam for input text boxes for example)
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > It's possible to set the cursor on the body node, would have to use a skin
> > property rather than a style property, but I'm not sure I like that.
> >
> >
> > On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > > I'm not sure a cursor will work. The cursor applies to the front-most
> > > element underneath the cursor. The only way, that I am aware of, to
> > > get a global cursor is to float (using absolute positioning and
> > > z-index) an HTML element (like a DIV) over the entire page. This is
> > > what the "blocking" functionality already does in Trinidad (I
> > > believe).
> > >
> > > So really, is it not the job of the programmer to ensure the PPR
> > > request is a blocking request and not the job of the status indicator
> > > to change the cursor?
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > Hmm I don't think this should be directly in the indicator contract. If
> > it
> > > > is, then I think it should be a new "type" attribute on the status
> > indicator
> > > > with the following values:
> > > >
> > > > "icon": render default icons (default value)
> > > > "cursor": change the cursor on document level (requires a way to
> > specified
> > > > the busy and ready cursor though)
> > > > "facets": render busy and ready facets
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > one more,
> > > > >
> > > > > what about changing the cursor, when statusIndicator is busy ?
> > > > >
> > > > > -M
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > I think
> > > > > >
> > > > > > no facet => icon is rendered;
> > > > > > otherwise, no icon is rendered.
> > > > > >
> > > > > > -M
> > > > > >
> > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > Hmm not as simple as I though. Before pushing a patch let decide
> > on
> > > > the
> > > > > > > behavior for every use case:
> > > > > > >
> > > > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > > Only one facet is specified and rendered --> Don't render any
> > icon or
> > > > > > > render the icon of the missing facet?
> > > > > > > Only one facet is specified but not rendered --> ?
> > > > > > > No facet is specified --> Render both icons
> > > > > > >
> > > > > > > ~ Simon
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > > that sounds like the best solution.
> > > > > > > > >
> > > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > > > > for an attribute at all.
> > > > > > > > > >
> > > > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > > > can render two statusIndicators.
> > > > > > > > > >
> > > > > > > > > > -- Adam
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > > > > > > > > > Hi,
> > > > > > > > > > >
> > > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> > wrote:
> > > > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> > I'll
> > > > do
> > > > > > > that right
> > > > > > > > > > > > away.
> > > > > > > > > > > >
> > > > > > > > > > > > I would also like to add a new attribute to skip the
> > icon
> > > > > > > rendering. If it
> > > > > > > > > > > > hasn't been of backward compatibility, I would have
> > simply
> > > > removed
> > > > > > > them
> > > > > > > > > > >
> > > > > > > > > > > I added a demo usage of the facet's, I was thinking, that
> > it
> > > > > > > shouldn't
> > > > > > > > > > > render the "default" icon,
> > > > > > > > > > > glad you pointed it out now.
> > > > > > > > > > >
> > > > > > > > > > > > since it's easily doable with a combination of facet and
> > > > tr:icon,
> > > > > > > but since
> > > > > > > > > > > > we had a release with the statusIndicator already,
> > that's
> > > > out of
> > > > > > > question.
> > > > > > > > > > > > So, what I need now is a decent attribute name. What do
> > you
> > > > think
> > > > > > > of
> > > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > > >
> > > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> > added
> > > > where
> > > > > > > facets.
> > > > > > > > > > >
> > > > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > > specified,
> > > > > > > we
> > > > > > > > > > > don't render the "default" icon.
> > > > > > > > > > >
> > > > > > > > > > > -Matthias
> > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > ~ Simon
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
That does not fully work, in Firefox at least (just tried it, the
cursor still reverts to an I-Beam for input text boxes for example)
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> It's possible to set the cursor on the body node, would have to use a skin
> property rather than a style property, but I'm not sure I like that.
>
>
> On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
> > I'm not sure a cursor will work. The cursor applies to the front-most
> > element underneath the cursor. The only way, that I am aware of, to
> > get a global cursor is to float (using absolute positioning and
> > z-index) an HTML element (like a DIV) over the entire page. This is
> > what the "blocking" functionality already does in Trinidad (I
> > believe).
> >
> > So really, is it not the job of the programmer to ensure the PPR
> > request is a blocking request and not the job of the status indicator
> > to change the cursor?
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > Hmm I don't think this should be directly in the indicator contract. If
> it
> > > is, then I think it should be a new "type" attribute on the status
> indicator
> > > with the following values:
> > >
> > > "icon": render default icons (default value)
> > > "cursor": change the cursor on document level (requires a way to
> specified
> > > the busy and ready cursor though)
> > > "facets": render busy and ready facets
> > >
> > >
> > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > one more,
> > > >
> > > > what about changing the cursor, when statusIndicator is busy ?
> > > >
> > > > -M
> > > >
> > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > I think
> > > > >
> > > > > no facet => icon is rendered;
> > > > > otherwise, no icon is rendered.
> > > > >
> > > > > -M
> > > > >
> > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > Hmm not as simple as I though. Before pushing a patch let decide
> on
> > > the
> > > > > > behavior for every use case:
> > > > > >
> > > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > > Both facets are specified but only one is rendered --> ?
> > > > > > Both facets are specified but neither are rendered --> ?
> > > > > > Only one facet is specified and rendered --> Don't render any
> icon or
> > > > > > render the icon of the missing facet?
> > > > > > Only one facet is specified but not rendered --> ?
> > > > > > No facet is specified --> Render both icons
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > > that sounds like the best solution.
> > > > > > > >
> > > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > > > for an attribute at all.
> > > > > > > > >
> > > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > > can render two statusIndicators.
> > > > > > > > >
> > > > > > > > > -- Adam
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > > > > > > > > Hi,
> > > > > > > > > >
> > > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> wrote:
> > > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> I'll
> > > do
> > > > > > that right
> > > > > > > > > > > away.
> > > > > > > > > > >
> > > > > > > > > > > I would also like to add a new attribute to skip the
> icon
> > > > > > rendering. If it
> > > > > > > > > > > hasn't been of backward compatibility, I would have
> simply
> > > removed
> > > > > > them
> > > > > > > > > >
> > > > > > > > > > I added a demo usage of the facet's, I was thinking, that
> it
> > > > > > shouldn't
> > > > > > > > > > render the "default" icon,
> > > > > > > > > > glad you pointed it out now.
> > > > > > > > > >
> > > > > > > > > > > since it's easily doable with a combination of facet and
> > > tr:icon,
> > > > > > but since
> > > > > > > > > > > we had a release with the statusIndicator already,
> that's
> > > out of
> > > > > > question.
> > > > > > > > > > > So, what I need now is a decent attribute name. What do
> you
> > > think
> > > > > > of
> > > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > > >
> > > > > > > > > > I tend to like renderFacetsOnly, because that what you
> added
> > > where
> > > > > > facets.
> > > > > > > > > >
> > > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > > specified,
> > > > > > we
> > > > > > > > > > don't render the "default" icon.
> > > > > > > > > >
> > > > > > > > > > -Matthias
> > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > ~ Simon
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Matthias Wessendorf
> > > > > > > > > >
> > > > > > > > > > further stuff:
> > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
It's possible to set the cursor on the body node, would have to use a skin
property rather than a style property, but I'm not sure I like that.
On 9/18/07, Andrew Robinson <an...@gmail.com> wrote:
>
> I'm not sure a cursor will work. The cursor applies to the front-most
> element underneath the cursor. The only way, that I am aware of, to
> get a global cursor is to float (using absolute positioning and
> z-index) an HTML element (like a DIV) over the entire page. This is
> what the "blocking" functionality already does in Trinidad (I
> believe).
>
> So really, is it not the job of the programmer to ensure the PPR
> request is a blocking request and not the job of the status indicator
> to change the cursor?
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Hmm I don't think this should be directly in the indicator contract. If
> it
> > is, then I think it should be a new "type" attribute on the status
> indicator
> > with the following values:
> >
> > "icon": render default icons (default value)
> > "cursor": change the cursor on document level (requires a way to
> specified
> > the busy and ready cursor though)
> > "facets": render busy and ready facets
> >
> >
> > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > one more,
> > >
> > > what about changing the cursor, when statusIndicator is busy ?
> > >
> > > -M
> > >
> > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > I think
> > > >
> > > > no facet => icon is rendered;
> > > > otherwise, no icon is rendered.
> > > >
> > > > -M
> > > >
> > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > Hmm not as simple as I though. Before pushing a patch let decide
> on
> > the
> > > > > behavior for every use case:
> > > > >
> > > > > Both facets are specified and rendered --> Don't render any icon
> > > > > Both facets are specified but only one is rendered --> ?
> > > > > Both facets are specified but neither are rendered --> ?
> > > > > Only one facet is specified and rendered --> Don't render any
> icon or
> > > > > render the icon of the missing facet?
> > > > > Only one facet is specified but not rendered --> ?
> > > > > No facet is specified --> Render both icons
> > > > >
> > > > > ~ Simon
> > > > >
> > > > >
> > > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > > that sounds like the best solution.
> > > > > > >
> > > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > > for an attribute at all.
> > > > > > > >
> > > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > > can render two statusIndicators.
> > > > > > > >
> > > > > > > > -- Adam
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com >
> wrote:
> > > > > > > > > > Speaking of which, I forgot to add skin documentation.
> I'll
> > do
> > > > > that right
> > > > > > > > > > away.
> > > > > > > > > >
> > > > > > > > > > I would also like to add a new attribute to skip the
> icon
> > > > > rendering. If it
> > > > > > > > > > hasn't been of backward compatibility, I would have
> simply
> > removed
> > > > > them
> > > > > > > > >
> > > > > > > > > I added a demo usage of the facet's, I was thinking, that
> it
> > > > > shouldn't
> > > > > > > > > render the "default" icon,
> > > > > > > > > glad you pointed it out now.
> > > > > > > > >
> > > > > > > > > > since it's easily doable with a combination of facet and
> > tr:icon,
> > > > > but since
> > > > > > > > > > we had a release with the statusIndicator already,
> that's
> > out of
> > > > > question.
> > > > > > > > > > So, what I need now is a decent attribute name. What do
> you
> > think
> > > > > of
> > > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > > >
> > > > > > > > > I tend to like renderFacetsOnly, because that what you
> added
> > where
> > > > > facets.
> > > > > > > > >
> > > > > > > > > Perhaps, we can change that soon, that when facet's are
> > specified,
> > > > > we
> > > > > > > > > don't render the "default" icon.
> > > > > > > > >
> > > > > > > > > -Matthias
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > ~ Simon
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Andrew Robinson <an...@gmail.com>.
I'm not sure a cursor will work. The cursor applies to the front-most
element underneath the cursor. The only way, that I am aware of, to
get a global cursor is to float (using absolute positioning and
z-index) an HTML element (like a DIV) over the entire page. This is
what the "blocking" functionality already does in Trinidad (I
believe).
So really, is it not the job of the programmer to ensure the PPR
request is a blocking request and not the job of the status indicator
to change the cursor?
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> Hmm I don't think this should be directly in the indicator contract. If it
> is, then I think it should be a new "type" attribute on the status indicator
> with the following values:
>
> "icon": render default icons (default value)
> "cursor": change the cursor on document level (requires a way to specified
> the busy and ready cursor though)
> "facets": render busy and ready facets
>
>
> On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > one more,
> >
> > what about changing the cursor, when statusIndicator is busy ?
> >
> > -M
> >
> > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > I think
> > >
> > > no facet => icon is rendered;
> > > otherwise, no icon is rendered.
> > >
> > > -M
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > Hmm not as simple as I though. Before pushing a patch let decide on
> the
> > > > behavior for every use case:
> > > >
> > > > Both facets are specified and rendered --> Don't render any icon
> > > > Both facets are specified but only one is rendered --> ?
> > > > Both facets are specified but neither are rendered --> ?
> > > > Only one facet is specified and rendered --> Don't render any icon or
> > > > render the icon of the missing facet?
> > > > Only one facet is specified but not rendered --> ?
> > > > No facet is specified --> Render both icons
> > > >
> > > > ~ Simon
> > > >
> > > >
> > > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > > >
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > > that sounds like the best solution.
> > > > > >
> > > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > > for an attribute at all.
> > > > > > >
> > > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > > can render two statusIndicators.
> > > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/18/07, Matthias Wessendorf <matzew@apache.org > wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com > wrote:
> > > > > > > > > Speaking of which, I forgot to add skin documentation. I'll
> do
> > > > that right
> > > > > > > > > away.
> > > > > > > > >
> > > > > > > > > I would also like to add a new attribute to skip the icon
> > > > rendering. If it
> > > > > > > > > hasn't been of backward compatibility, I would have simply
> removed
> > > > them
> > > > > > > >
> > > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > > shouldn't
> > > > > > > > render the "default" icon,
> > > > > > > > glad you pointed it out now.
> > > > > > > >
> > > > > > > > > since it's easily doable with a combination of facet and
> tr:icon,
> > > > but since
> > > > > > > > > we had a release with the statusIndicator already, that's
> out of
> > > > question.
> > > > > > > > > So, what I need now is a decent attribute name. What do you
> think
> > > > of
> > > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > > >
> > > > > > > > I tend to like renderFacetsOnly, because that what you added
> where
> > > > facets.
> > > > > > > >
> > > > > > > > Perhaps, we can change that soon, that when facet's are
> specified,
> > > > we
> > > > > > > > don't render the "default" icon.
> > > > > > > >
> > > > > > > > -Matthias
> > > > > > > >
> > > > > > > > >
> > > > > > > > > ~ Simon
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hmm I don't think this should be directly in the indicator contract. If it
is, then I think it should be a new "type" attribute on the status indicator
with the following values:
"icon": render default icons (default value)
"cursor": change the cursor on document level (requires a way to specified
the busy and ready cursor though)
"facets": render busy and ready facets
On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
>
> one more,
>
> what about changing the cursor, when statusIndicator is busy ?
>
> -M
>
> On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > I think
> >
> > no facet => icon is rendered;
> > otherwise, no icon is rendered.
> >
> > -M
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > Hmm not as simple as I though. Before pushing a patch let decide on
> the
> > > behavior for every use case:
> > >
> > > Both facets are specified and rendered --> Don't render any icon
> > > Both facets are specified but only one is rendered --> ?
> > > Both facets are specified but neither are rendered --> ?
> > > Only one facet is specified and rendered --> Don't render any icon or
> > > render the icon of the missing facet?
> > > Only one facet is specified but not rendered --> ?
> > > No facet is specified --> Render both icons
> > >
> > > ~ Simon
> > >
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > Or put tr:icon in the facet. Yeah, that sound good too.
> > > >
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > that sounds like the best solution.
> > > > >
> > > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > > for an attribute at all.
> > > > > >
> > > > > > Anyone that desperately needs both the facet and the icon
> > > > > > can render two statusIndicators.
> > > > > >
> > > > > > -- Adam
> > > > > >
> > > > > >
> > > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > > Speaking of which, I forgot to add skin documentation. I'll
> do
> > > that right
> > > > > > > > away.
> > > > > > > >
> > > > > > > > I would also like to add a new attribute to skip the icon
> > > rendering. If it
> > > > > > > > hasn't been of backward compatibility, I would have simply
> removed
> > > them
> > > > > > >
> > > > > > > I added a demo usage of the facet's, I was thinking, that it
> > > shouldn't
> > > > > > > render the "default" icon,
> > > > > > > glad you pointed it out now.
> > > > > > >
> > > > > > > > since it's easily doable with a combination of facet and
> tr:icon,
> > > but since
> > > > > > > > we had a release with the statusIndicator already, that's
> out of
> > > question.
> > > > > > > > So, what I need now is a decent attribute name. What do you
> think
> > > of
> > > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > > >
> > > > > > > I tend to like renderFacetsOnly, because that what you added
> where
> > > facets.
> > > > > > >
> > > > > > > Perhaps, we can change that soon, that when facet's are
> specified,
> > > we
> > > > > > > don't render the "default" icon.
> > > > > > >
> > > > > > > -Matthias
> > > > > > >
> > > > > > > >
> > > > > > > > ~ Simon
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > > mail: matzew-at-apache-dot-org
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Matthias Wessendorf <ma...@apache.org>.
one more,
what about changing the cursor, when statusIndicator is busy ?
-M
On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> I think
>
> no facet => icon is rendered;
> otherwise, no icon is rendered.
>
> -M
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Hmm not as simple as I though. Before pushing a patch let decide on the
> > behavior for every use case:
> >
> > Both facets are specified and rendered --> Don't render any icon
> > Both facets are specified but only one is rendered --> ?
> > Both facets are specified but neither are rendered --> ?
> > Only one facet is specified and rendered --> Don't render any icon or
> > render the icon of the missing facet?
> > Only one facet is specified but not rendered --> ?
> > No facet is specified --> Render both icons
> >
> > ~ Simon
> >
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > Or put tr:icon in the facet. Yeah, that sound good too.
> > >
> > >
> > >
> > > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > that sounds like the best solution.
> > > >
> > > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > IMO, if we have a facet, we don't render the icon. No need
> > > > > for an attribute at all.
> > > > >
> > > > > Anyone that desperately needs both the facet and the icon
> > > > > can render two statusIndicators.
> > > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> > that right
> > > > > > > away.
> > > > > > >
> > > > > > > I would also like to add a new attribute to skip the icon
> > rendering. If it
> > > > > > > hasn't been of backward compatibility, I would have simply removed
> > them
> > > > > >
> > > > > > I added a demo usage of the facet's, I was thinking, that it
> > shouldn't
> > > > > > render the "default" icon,
> > > > > > glad you pointed it out now.
> > > > > >
> > > > > > > since it's easily doable with a combination of facet and tr:icon,
> > but since
> > > > > > > we had a release with the statusIndicator already, that's out of
> > question.
> > > > > > > So, what I need now is a decent attribute name. What do you think
> > of
> > > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > > >
> > > > > > I tend to like renderFacetsOnly, because that what you added where
> > facets.
> > > > > >
> > > > > > Perhaps, we can change that soon, that when facet's are specified,
> > we
> > > > > > don't render the "default" icon.
> > > > > >
> > > > > > -Matthias
> > > > > >
> > > > > > >
> > > > > > > ~ Simon
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> >
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Matthias Wessendorf <ma...@apache.org>.
I think
no facet => icon is rendered;
otherwise, no icon is rendered.
-M
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> Hmm not as simple as I though. Before pushing a patch let decide on the
> behavior for every use case:
>
> Both facets are specified and rendered --> Don't render any icon
> Both facets are specified but only one is rendered --> ?
> Both facets are specified but neither are rendered --> ?
> Only one facet is specified and rendered --> Don't render any icon or
> render the icon of the missing facet?
> Only one facet is specified but not rendered --> ?
> No facet is specified --> Render both icons
>
> ~ Simon
>
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Or put tr:icon in the facet. Yeah, that sound good too.
> >
> >
> >
> > On 9/18/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > that sounds like the best solution.
> > >
> > > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > > IMO, if we have a facet, we don't render the icon. No need
> > > > for an attribute at all.
> > > >
> > > > Anyone that desperately needs both the facet and the icon
> > > > can render two statusIndicators.
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > Hi,
> > > > >
> > > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > > Speaking of which, I forgot to add skin documentation. I'll do
> that right
> > > > > > away.
> > > > > >
> > > > > > I would also like to add a new attribute to skip the icon
> rendering. If it
> > > > > > hasn't been of backward compatibility, I would have simply removed
> them
> > > > >
> > > > > I added a demo usage of the facet's, I was thinking, that it
> shouldn't
> > > > > render the "default" icon,
> > > > > glad you pointed it out now.
> > > > >
> > > > > > since it's easily doable with a combination of facet and tr:icon,
> but since
> > > > > > we had a release with the statusIndicator already, that's out of
> question.
> > > > > > So, what I need now is a decent attribute name. What do you think
> of
> > > > > > "renderIcon" or "renderFacetsOnly"?
> > > > >
> > > > > I tend to like renderFacetsOnly, because that what you added where
> facets.
> > > > >
> > > > > Perhaps, we can change that soon, that when facet's are specified,
> we
> > > > > don't render the "default" icon.
> > > > >
> > > > > -Matthias
> > > > >
> > > > > >
> > > > > > ~ Simon
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Hmm not as simple as I though. Before pushing a patch let decide on the
behavior for every use case:
Both facets are specified and rendered --> Don't render any icon
Both facets are specified but only one is rendered --> ?
Both facets are specified but neither are rendered --> ?
Only one facet is specified and rendered --> Don't render any icon or render
the icon of the missing facet?
Only one facet is specified but not rendered --> ?
No facet is specified --> Render both icons
~ Simon
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
>
> Or put tr:icon in the facet. Yeah, that sound good too.
>
> On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >
> > that sounds like the best solution.
> >
> > On 9/18/07, Adam Winer < awiner@gmail.com> wrote:
> > > IMO, if we have a facet, we don't render the icon. No need
> > > for an attribute at all.
> > >
> > > Anyone that desperately needs both the facet and the icon
> > > can render two statusIndicators.
> > >
> > > -- Adam
> > >
> > >
> > > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > Hi,
> > > >
> > > > On 9/18/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > > > Speaking of which, I forgot to add skin documentation. I'll do
> > that right
> > > > > away.
> > > > >
> > > > > I would also like to add a new attribute to skip the icon
> > rendering. If it
> > > > > hasn't been of backward compatibility, I would have simply removed
> > them
> > > >
> > > > I added a demo usage of the facet's, I was thinking, that it
> > shouldn't
> > > > render the "default" icon,
> > > > glad you pointed it out now.
> > > >
> > > > > since it's easily doable with a combination of facet and tr:icon,
> > but since
> > > > > we had a release with the statusIndicator already, that's out of
> > question.
> > > > > So, what I need now is a decent attribute name. What do you think
> > of
> > > > > "renderIcon" or "renderFacetsOnly"?
> > > >
> > > > I tend to like renderFacetsOnly, because that what you added where
> > facets.
> > > >
> > > > Perhaps, we can change that soon, that when facet's are specified,
> > we
> > > > don't render the "default" icon.
> > > >
> > > > -Matthias
> > > >
> > > > >
> > > > > ~ Simon
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Or put tr:icon in the facet. Yeah, that sound good too.
On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
>
> that sounds like the best solution.
>
> On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> > IMO, if we have a facet, we don't render the icon. No need
> > for an attribute at all.
> >
> > Anyone that desperately needs both the facet and the icon
> > can render two statusIndicators.
> >
> > -- Adam
> >
> >
> > On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > Hi,
> > >
> > > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > > Speaking of which, I forgot to add skin documentation. I'll do that
> right
> > > > away.
> > > >
> > > > I would also like to add a new attribute to skip the icon rendering.
> If it
> > > > hasn't been of backward compatibility, I would have simply removed
> them
> > >
> > > I added a demo usage of the facet's, I was thinking, that it shouldn't
> > > render the "default" icon,
> > > glad you pointed it out now.
> > >
> > > > since it's easily doable with a combination of facet and tr:icon,
> but since
> > > > we had a release with the statusIndicator already, that's out of
> question.
> > > > So, what I need now is a decent attribute name. What do you think of
> > > > "renderIcon" or "renderFacetsOnly"?
> > >
> > > I tend to like renderFacetsOnly, because that what you added where
> facets.
> > >
> > > Perhaps, we can change that soon, that when facet's are specified, we
> > > don't render the "default" icon.
> > >
> > > -Matthias
> > >
> > > >
> > > > ~ Simon
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > mail: matzew-at-apache-dot-org
> > >
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Matthias Wessendorf <ma...@apache.org>.
that sounds like the best solution.
On 9/18/07, Adam Winer <aw...@gmail.com> wrote:
> IMO, if we have a facet, we don't render the icon. No need
> for an attribute at all.
>
> Anyone that desperately needs both the facet and the icon
> can render two statusIndicators.
>
> -- Adam
>
>
> On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > Hi,
> >
> > On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > > Speaking of which, I forgot to add skin documentation. I'll do that right
> > > away.
> > >
> > > I would also like to add a new attribute to skip the icon rendering. If it
> > > hasn't been of backward compatibility, I would have simply removed them
> >
> > I added a demo usage of the facet's, I was thinking, that it shouldn't
> > render the "default" icon,
> > glad you pointed it out now.
> >
> > > since it's easily doable with a combination of facet and tr:icon, but since
> > > we had a release with the statusIndicator already, that's out of question.
> > > So, what I need now is a decent attribute name. What do you think of
> > > "renderIcon" or "renderFacetsOnly"?
> >
> > I tend to like renderFacetsOnly, because that what you added where facets.
> >
> > Perhaps, we can change that soon, that when facet's are specified, we
> > don't render the "default" icon.
> >
> > -Matthias
> >
> > >
> > > ~ Simon
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Adam Winer <aw...@gmail.com>.
IMO, if we have a facet, we don't render the icon. No need
for an attribute at all.
Anyone that desperately needs both the facet and the icon
can render two statusIndicators.
-- Adam
On 9/18/07, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi,
>
> On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> > Speaking of which, I forgot to add skin documentation. I'll do that right
> > away.
> >
> > I would also like to add a new attribute to skip the icon rendering. If it
> > hasn't been of backward compatibility, I would have simply removed them
>
> I added a demo usage of the facet's, I was thinking, that it shouldn't
> render the "default" icon,
> glad you pointed it out now.
>
> > since it's easily doable with a combination of facet and tr:icon, but since
> > we had a release with the statusIndicator already, that's out of question.
> > So, what I need now is a decent attribute name. What do you think of
> > "renderIcon" or "renderFacetsOnly"?
>
> I tend to like renderFacetsOnly, because that what you added where facets.
>
> Perhaps, we can change that soon, that when facet's are specified, we
> don't render the "default" icon.
>
> -Matthias
>
> >
> > ~ Simon
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi,
On 9/18/07, Simon Lessard <si...@gmail.com> wrote:
> Speaking of which, I forgot to add skin documentation. I'll do that right
> away.
>
> I would also like to add a new attribute to skip the icon rendering. If it
> hasn't been of backward compatibility, I would have simply removed them
I added a demo usage of the facet's, I was thinking, that it shouldn't
render the "default" icon,
glad you pointed it out now.
> since it's easily doable with a combination of facet and tr:icon, but since
> we had a release with the statusIndicator already, that's out of question.
> So, what I need now is a decent attribute name. What do you think of
> "renderIcon" or "renderFacetsOnly"?
I tend to like renderFacetsOnly, because that what you added where facets.
Perhaps, we can change that soon, that when facet's are specified, we
don't render the "default" icon.
-Matthias
>
> ~ Simon
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org
Re: svn commit: r576576 [1/3] - in /myfaces/trinidad/trunk/trinidad: trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ trinida
Posted by Simon Lessard <si...@gmail.com>.
Speaking of which, I forgot to add skin documentation. I'll do that right
away.
I would also like to add a new attribute to skip the icon rendering. If it
hasn't been of backward compatibility, I would have simply removed them
since it's easily doable with a combination of facet and tr:icon, but since
we had a release with the statusIndicator already, that's out of question.
So, what I need now is a decent attribute name. What do you think of
"renderIcon" or "renderFacetsOnly"?
~ Simon