You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/24 23:15:15 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10423: style: shinier menus
rusackas opened a new pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Moving the menus toward SIP-34. Design details are a bit up for grabs... I'll continue to steer with @steejay. Will open up from draft when https://github.com/apache/incubator-superset/pull/10401 is merged, so this doesn't cause headaches between the two menus.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#discussion_r462673892
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -56,32 +56,52 @@ export interface MenuProps {
}
const StyledHeader = styled.header`
+ & > nav {
+ border: none;
+ }
.navbar-brand {
display: flex;
flex-direction: column;
justify-content: center;
}
+ .nav > li > a {
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+
.navbar-nav > li > a {
+ border-bottom: none;
+ &:focus {
+ border-bottom: none;
+ }
&:after {
content: '';
position: absolute;
bottom: -3px;
- left: 0;
- width: 100%;
+ left: 50%;
+ width: 0;
height: 3px;
background-color: ${({ theme }) => theme.colors.primary.base};
opacity: 0;
- transition: opacity ${({ theme }) => theme.transitionTiming * 2}s;
+ transform: translateX(-50%);
+ transition: all ${({ theme }) => theme.transitionTiming}s !important;
Review comment:
yikes... why do we need an `!important` here?
##########
File path: superset-frontend/src/components/NavDropdown/index.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import styled from '@superset-ui/style';
+import { NavDropdown as RBNavDropdown } from 'react-bootstrap';
+
+const NavDropdown = styled(RBNavDropdown)`
+ & > a.dropdown-toggle {
+ padding-right: ${({ theme }) => theme.gridUnit * 6}px !important;
+ }
+ & > a {
+ transition: background ${({ theme }) => theme.transitionTiming}s;
+ }
+ &.open > a {
+ background: ${({ theme }) => theme.colors.primary.light4} !important;
Review comment:
and same important comment here
##########
File path: superset-frontend/src/components/NavDropdown/index.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import styled from '@superset-ui/style';
+import { NavDropdown as RBNavDropdown } from 'react-bootstrap';
Review comment:
Can we name this `BootstrapNavDropdown`? Or `ReactBootstrapNavDropdown`. I agree the latter is a bit verbose, but `RB` was tough for me to grok at first
##########
File path: superset-frontend/src/components/NavDropdown/index.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import styled from '@superset-ui/style';
+import { NavDropdown as RBNavDropdown } from 'react-bootstrap';
+
+const NavDropdown = styled(RBNavDropdown)`
+ & > a.dropdown-toggle {
+ padding-right: ${({ theme }) => theme.gridUnit * 6}px !important;
Review comment:
again, a bit odd we need the `!important`
##########
File path: superset-frontend/src/components/Menu/MenuObject.tsx
##########
@@ -44,17 +45,12 @@ export default function MenuObject({
if (url) {
return (
<NavItem eventKey={index} href={url}>
- <i className={`fa ${icon}`} /> {label}
+ {label}
</NavItem>
);
}
- const navTitle = (
- <>
- <i className={`fa ${icon}`} />
- {label}
- </>
- );
+ const navTitle = <>{label}</>;
Review comment:
this can simply be `const navTitle = label;`? Or we can remove `navTitle` entirely and use `label` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/09dfbab7ed7cdb518109fa3fb093ce20d52fa8af&el=desc) will **decrease** coverage by `6.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 70.25% 64.15% -6.11%
==========================================
Files 605 544 -61
Lines 32425 30546 -1879
Branches 3295 2885 -410
==========================================
- Hits 22781 19597 -3184
- Misses 9535 10771 +1236
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.89% <ø> (+0.37%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `69.76% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [superset-frontend/src/views/datasetList/Button.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0J1dHRvbi50c3g=) | `6.66% <0.00%> (-93.34%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [221 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [09dfbab...a9812f9](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#discussion_r463129625
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -56,32 +56,52 @@ export interface MenuProps {
}
const StyledHeader = styled.header`
+ & > nav {
+ border: none;
+ }
.navbar-brand {
display: flex;
flex-direction: column;
justify-content: center;
}
+ .nav > li > a {
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+
.navbar-nav > li > a {
+ border-bottom: none;
+ &:focus {
+ border-bottom: none;
+ }
&:after {
content: '';
position: absolute;
bottom: -3px;
- left: 0;
- width: 100%;
+ left: 50%;
+ width: 0;
height: 3px;
background-color: ${({ theme }) => theme.colors.primary.base};
opacity: 0;
- transition: opacity ${({ theme }) => theme.transitionTiming * 2}s;
+ transform: translateX(-50%);
+ transition: all ${({ theme }) => theme.transitionTiming}s !important;
Review comment:
I think it's worth seeing how messy it looks either way. It might be better to show the full selector stack regardless, since then it's more obvious to developers that this is fragile logic. `!important` can hide a bunch of nuance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/09dfbab7ed7cdb518109fa3fb093ce20d52fa8af&el=desc) will **decrease** coverage by `4.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 70.25% 65.39% -4.86%
==========================================
Files 605 606 +1
Lines 32425 32436 +11
Branches 3295 3296 +1
==========================================
- Hits 22781 21213 -1568
- Misses 9535 11038 +1503
- Partials 109 185 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.33% <100.00%> (+0.06%)` | :arrow_up: |
| #python | `69.67% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/UserMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS5qc3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `90.00% <100.00%> (+0.52%)` | :arrow_up: |
| [...perset-frontend/src/components/Menu/MenuObject.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LmpzeA==) | `100.00% <100.00%> (ø)` | |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [09dfbab...62f8fce](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **increase** coverage by `4.04%`.
> The diff coverage is `96.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
+ Coverage 60.17% 64.22% +4.04%
==========================================
Files 784 785 +1
Lines 36954 36977 +23
Branches 3529 3530 +1
==========================================
+ Hits 22238 23749 +1511
+ Misses 14529 13116 -1413
+ Partials 187 112 -75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.08% <100.00%> (?)` | |
| #javascript | `60.90% <96.15%> (+0.06%)` | :arrow_up: |
| #python | `59.74% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/UserMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS50c3g=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `86.66% <66.66%> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `92.85% <100.00%> (+0.54%)` | :arrow_up: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
| ... and [146 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...fb75931](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **increase** coverage by `4.14%`.
> The diff coverage is `96.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
+ Coverage 60.17% 64.32% +4.14%
==========================================
Files 784 785 +1
Lines 36954 36977 +23
Branches 3529 3530 +1
==========================================
+ Hits 22238 23784 +1546
+ Misses 14529 13084 -1445
+ Partials 187 109 -78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.58% <100.00%> (?)` | |
| #javascript | `60.90% <96.15%> (+0.06%)` | :arrow_up: |
| #python | `59.74% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/UserMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS50c3g=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `86.66% <66.66%> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `92.85% <100.00%> (+0.54%)` | :arrow_up: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
| ... and [148 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...fb75931](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `96.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
+ Coverage 60.17% 60.19% +0.01%
==========================================
Files 784 785 +1
Lines 36954 36977 +23
Branches 3529 3530 +1
==========================================
+ Hits 22238 22258 +20
- Misses 14529 14532 +3
Partials 187 187
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `60.91% <96.42%> (+0.06%)` | :arrow_up: |
| #python | `59.76% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/UserMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS50c3g=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `86.66% <66.66%> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `93.10% <100.00%> (+0.79%)` | :arrow_up: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.65% <0.00%> (-0.68%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...1d64335](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `96.96%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 60.17% 60.01% -0.17%
==========================================
Files 784 785 +1
Lines 36954 36980 +26
Branches 3529 3530 +1
==========================================
- Hits 22238 22193 -45
- Misses 14529 14600 +71
Partials 187 187
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `60.91% <96.96%> (+0.07%)` | :arrow_up: |
| #python | `59.47% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `86.66% <66.66%> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `93.33% <100.00%> (+1.02%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/UserMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.91% <0.00%> (-11.41%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...826563c](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#discussion_r462759118
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -56,32 +56,52 @@ export interface MenuProps {
}
const StyledHeader = styled.header`
+ & > nav {
+ border: none;
+ }
.navbar-brand {
display: flex;
flex-direction: column;
justify-content: center;
}
+ .nav > li > a {
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+
.navbar-nav > li > a {
+ border-bottom: none;
+ &:focus {
+ border-bottom: none;
+ }
&:after {
content: '';
position: absolute;
bottom: -3px;
- left: 0;
- width: 100%;
+ left: 50%;
+ width: 0;
height: 3px;
background-color: ${({ theme }) => theme.colors.primary.base};
opacity: 0;
- transition: opacity ${({ theme }) => theme.transitionTiming * 2}s;
+ transform: translateX(-50%);
+ transition: all ${({ theme }) => theme.transitionTiming}s !important;
Review comment:
Yeahhhhhhh, I have a hatred for `!important` too. This was just because it's overriding some deeeep selector stuff from Bootstrap. I can add the full selector stack instead, I suppose. Will look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-679745760
Addresses aspects of #8976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 60.17% 59.47% -0.71%
==========================================
Files 784 360 -424
Lines 36954 23178 -13776
Branches 3529 0 -3529
==========================================
- Hits 22238 13785 -8453
+ Misses 14529 9393 -5136
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.47% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.91% <0.00%> (-11.41%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.38% <0.00%> (-1.12%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.45% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.25%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| ... and [417 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...826563c](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdfb7cdfd2c0898376801acad17cd3231ca8e6db?el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 60.17% 59.34% -0.84%
==========================================
Files 784 360 -424
Lines 36954 23167 -13787
Branches 3529 0 -3529
==========================================
- Hits 22238 13749 -8489
+ Misses 14529 9418 -5111
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.34% <ø> (-0.44%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.91% <0.00%> (-11.41%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.18% <0.00%> (-2.78%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.27% <0.00%> (-2.23%)` | :arrow_down: |
| ... and [429 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [fdfb7cd...fb75931](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-679737217
Got the two lil' menus on the right to conform, for good measure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-679740600
Addressed PR comments and made lots of touchups. @mistercrunch / @etr2460 if you wouldn't mind giving it another glance, that'd make me feel better before merging. @riahk / @nytai might want to take a glance too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10423: style: Fancier menus, more SIP-34-ish
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10423:
URL: https://github.com/apache/incubator-superset/pull/10423#issuecomment-663934273
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=h1) Report
> Merging [#10423](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/09dfbab7ed7cdb518109fa3fb093ce20d52fa8af&el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 70.25% 65.42% -4.84%
==========================================
Files 605 606 +1
Lines 32425 32436 +11
Branches 3295 3296 +1
==========================================
- Hits 22781 21220 -1561
- Misses 9535 11031 +1496
- Partials 109 185 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.33% <100.00%> (+0.06%)` | :arrow_up: |
| #python | `69.71% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/UserMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9Vc2VyTWVudS5qc3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `90.00% <100.00%> (+0.52%)` | :arrow_up: |
| [...perset-frontend/src/components/Menu/MenuObject.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LmpzeA==) | `100.00% <100.00%> (ø)` | |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/10423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=footer). Last update [09dfbab...62f8fce](https://codecov.io/gh/apache/incubator-superset/pull/10423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org