You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/10 15:34:58 UTC

[GitHub] [flink] RyanSkraba commented on a diff in pull request #19363: [FLINK-27059][tests][JUnit5 migration] flink-compress

RyanSkraba commented on code in PR #19363:
URL: https://github.com/apache/flink/pull/19363#discussion_r869393179


##########
flink-formats/flink-compress/src/test/java/org/apache/flink/formats/compress/CompressionFactoryITCase.java:
##########
@@ -43,27 +43,24 @@
 import java.util.List;
 import java.util.stream.Collectors;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 /**
  * Integration test case for writing bulk encoded files with the {@link StreamingFileSink} and
  * Hadoop Compression Codecs.
  */
-public class CompressionFactoryITCase extends AbstractTestBase {
+class CompressionFactoryITCase extends AbstractTestBase {

Review Comment:
   Hey, thanks -- I'll rebase on 1.16 and make this change to an `@ExtendsWith(MiniClusterResource)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org