You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/18 20:09:53 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #18932: Numpy Ops Large Tensor Tests

Zha0q1 commented on pull request #18932:
URL: https://github.com/apache/incubator-mxnet/pull/18932#issuecomment-675687761


   The purpose of the tests is to check for int indexing. If an op uses index_t for indexing then it will pass the test. I don't see how going from small to large tensor will break correctness because indexing is not any part of the algorithm. Value check might make more sense for linalg operators because some linalg ops depend on indexing type to calculate pivots. But for sin, cos, min, those ops will just go through each value in the tensor


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org