[GitHub] [ignite-3] zstan commented on a diff in pull request #964: IGNITE-14487: Table view bulk methods refactoring.

[GitBox <gi...@apache.org>]

zstan commented on code in PR #964:
URL: https://github.com/apache/ignite-3/pull/964#discussion_r934441345


##########
modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueBinaryViewImpl.java:
##########
@@ -475,8 +476,8 @@ private Tuple unmarshalValue(BinaryRow row) {
      * @param rows Binary rows.
      * @return Key-value pairs of tuples.
      */
-    public Map<Tuple, Tuple> unmarshalValue(Collection<BinaryRow> rows) {
-        Map<Tuple, Tuple> pairs = new HashMap<>();
+    private Map<Tuple, Tuple> unmarshalValue(Collection<BinaryRow> rows) {
+        Map<Tuple, Tuple> pairs = new HashMap<>(rows.size());

Review Comment:
   Seems we still obtain reallocations here, check [1]
   
   [1] https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java#L10140
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org