You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "nuno-faria (via GitHub)" <gi...@apache.org> on 2026/01/25 16:56:47 UTC
[PR] docs: Automatically update DataFusion version in docs [datafusion]
nuno-faria opened a new pull request, #20001:
URL: https://github.com/apache/datafusion/pull/20001
## Which issue does this PR close?
- N/A.
## Rationale for this change
I was looking at the download page (https://datafusion.apache.org/download.html) when I noticed the version there was not updated in a while. Likewise, there are other places in the docs where the version is not updated.
This PR changes the `update_datafusion_versions.py` script to automatically update those files, in addition to the Cargo files.
## What changes are included in this PR?
- Updated `update_datafusion_versions.py` to check some doc files.
- Updated the doc files to the current major version.
## Are these changes tested?
Yes, script runs correctly.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Automatically update DataFusion version in docs [datafusion]
Posted by "nuno-faria (via GitHub)" <gi...@apache.org>.
nuno-faria commented on code in PR #20001:
URL: https://github.com/apache/datafusion/pull/20001#discussion_r2726714979
##########
dev/update_datafusion_versions.py:
##########
@@ -116,7 +115,8 @@ def update_docs(path: str, new_version: str):
with open(path, 'r+') as fd:
content = fd.read()
fd.seek(0)
Review Comment:
Yes it will leave extra bytes at the end, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Automatically update DataFusion version in docs [datafusion]
Posted by "nuno-faria (via GitHub)" <gi...@apache.org>.
nuno-faria commented on code in PR #20001:
URL: https://github.com/apache/datafusion/pull/20001#discussion_r2725727265
##########
dev/update_datafusion_versions.py:
##########
@@ -48,7 +48,6 @@
'datafusion-benchmarks': 'benchmarks/Cargo.toml',
'datafusion-cli': 'datafusion-cli/Cargo.toml',
'datafusion-examples': 'datafusion-examples/Cargo.toml',
- 'datafusion-docs': 'docs/Cargo.toml',
Review Comment:
This file does not exist anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Automatically update DataFusion version in docs [datafusion]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #20001:
URL: https://github.com/apache/datafusion/pull/20001#discussion_r2725921280
##########
dev/update_datafusion_versions.py:
##########
@@ -116,7 +115,8 @@ def update_docs(path: str, new_version: str):
with open(path, 'r+') as fd:
content = fd.read()
fd.seek(0)
- content = re.sub(r'datafusion = "(.+)"', f'datafusion = "{new_version}"', content)
+ content = re.sub(r'datafusion = "(.+?)"', f'datafusion = "{new_version}"', content)
+ content = re.sub(r'datafusion = { version = "(.+?)"', f'datafusion = {{ version = "{new_version}"', content)
Review Comment:
In addition the regex won't match if there is no exactly one space before/after `=` and `{`, e.g. `datafusion = {version="..."}`. Maybe `\s*` should be used instead of spaces ?
##########
dev/update_datafusion_versions.py:
##########
@@ -116,7 +115,8 @@ def update_docs(path: str, new_version: str):
with open(path, 'r+') as fd:
content = fd.read()
fd.seek(0)
Review Comment:
Shouldn't this actually truncate the file ?
Currently it overwrites its content but if the new content is shorter than the previous one then the extra characters from the old one will still stay at the end.
##########
dev/update_datafusion_versions.py:
##########
@@ -116,7 +115,8 @@ def update_docs(path: str, new_version: str):
with open(path, 'r+') as fd:
content = fd.read()
fd.seek(0)
- content = re.sub(r'datafusion = "(.+)"', f'datafusion = "{new_version}"', content)
+ content = re.sub(r'datafusion = "(.+?)"', f'datafusion = "{new_version}"', content)
+ content = re.sub(r'datafusion = { version = "(.+?)"', f'datafusion = {{ version = "{new_version}"', content)
Review Comment:
```suggestion
content = re.sub(r'datafusion = \{ version = "(.+?)"', f'datafusion = {{ version = "{new_version}"', content)
```
`{` is a special character in regex and it should be escaped if used as a literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Automatically update DataFusion version in docs [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #20001:
URL: https://github.com/apache/datafusion/pull/20001#issuecomment-3815170631
Thanks @nuno-faria & @martin-g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Automatically update DataFusion version in docs [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #20001:
URL: https://github.com/apache/datafusion/pull/20001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org