[GitHub] [cloudstack] rafaelweingartner commented on pull request #4283: Removes unnecessary validations

[GitBox <gi...@apache.org>]

rafaelweingartner commented on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-696455059


   > @RodrigoDLopez this removes tags checking altogether? This will allow migrating volumes to storages which are not even suitable wrt tags?
   
   Exactly that. This was discussed and developed within a series of PRs I created some time ago, and it was broken while merging forward. Therefore, @RodrigoDLopez is fixing part of the broken code with this PR. These are the following PRs that were used to deliver this feature:
   * https://github.com/apache/cloudstack/pull/2425
   * https://github.com/apache/cloudstack/pull/2486
   * https://github.com/apache/cloudstack/pull/2607
   * https://github.com/apache/cloudstack/pull/2612
   * https://github.com/apache/cloudstack/pull/2761
   * https://github.com/apache/cloudstack/pull/2636
   
   The implementation was broken down into several different PRs to easy development and testing. Moreover, the feature was already discussed, approved, and merged a long time ago and there are already people using it. What @RodrigoDLopez is doing is just fixing this feature that was broken during a merge forward from 4.11 that was executed on 4.12.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org