[GitHub] [spark] grundprinzip commented on a diff in pull request #38607: [SPARK-40938][CONNECT][PYTHON][FOLLOW-UP] Fix SubqueryAlias without the child plan when constructing Connect proto in the Python client

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38607:
URL: https://github.com/apache/spark/pull/38607#discussion_r1020562864


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -712,6 +712,8 @@ def __init__(self, child: Optional["LogicalPlan"], alias: str) -> None:
 
     def plan(self, session: "RemoteSparkSession") -> proto.Relation:
         rel = proto.Relation()
+        if self._child is not None:
+            rel.subquery_alias.input.CopyFrom(self._child.plan(session))

Review Comment:
   The current e2e tests run about 16s on my laptop and the majority of the time is spend in starting spark. When we keep the restarts of Spark minimal, e2e tests should not be an issue when they make sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org