You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/20 11:35:39 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6661: Enable live volume migration for StorPool and small fixes

DaanHoogland commented on code in PR #6661:
URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1053218668


##########
test/integration/plugins/storpool/MigrateVolumeToStorPool.py:
##########
@@ -194,9 +194,12 @@ def setUpCloudStack(cls):
         securitygroup = SecurityGroup.list(cls.apiclient, account = cls.account.name, domainid= cls.account.domainid)[0]
         cls.helper.set_securityGroups(cls.apiclient, account = cls.account.name, domainid= cls.account.domainid, id = securitygroup.id)
 
+        cls.clusters = cls.helper.getClustersWithStorPool(cls.apiclient, cls.zone.id,)
+
         cls.vm = VirtualMachine.create(cls.apiclient,

Review Comment:
   @slavkap is there a reason you are not adding these VMs to cls._cleanup? it seems they would leave garbage in an environment if something goes wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org