You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Yifan Cai <yc...@gmail.com> on 2024/07/26 16:48:44 UTC

[DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Hi everyone,

CASSANDRA-19800 is currently in the state of ready to be committed. Before
that, I want to propose backporting it to 4.0, 4.1 and 5.0.

The ability to notify CQLSSTableWriter user when new sstables are produced
is especially useful for Cassandra Analytics and other consumers. The API
is more reliable than monitoring the file directory.

That being said, I am aware that the patch is an improvement and trunk
only. I want to ask for an exemption on backporting the patch for two
reasons. It is useful for Cassandra Analytics. The patch is low risk for
Cassandra server as it only touches CQLSSTableWriter, which is only used by
toolings.

- Yifan

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Dinesh Joshi <dj...@apache.org>.
On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mc...@apache.org> wrote:

> This also incentivises intentionally not introducing support for that api
> in older mainlines.  We KISS, if the user wants that ecosystem benefit they
> need to upgrade to at least mainline X.
>
> Once older mainlines have it then we have this problem.  An alternative to
> the risk of having to always update all the mainlines, is to let the
> ecosystem branch to provide support for the different mainlines as/when
> needed.  Both are painful.
>

In order to support upgrades where clusters may be running the current
major - 1 version, we need to support two versions of Cassandra in the
Analytics library or Sidecar (due to rolling upgrades). So it makes sense
to backport to the current major and the prior major release.

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
Hi Scott,

– What's this for? I'd appreciate a detailed explanation of what "Enhance
> CQLSSTableWriter to notify clients on sstable production" does and how it's
> meant to be used. Why is it needed for rolling upgrades? The phrasing of
> the ticket right now reads as nice-to-have rather than must-have. An
> earlier email described the value as "code quality and brings other
> benefits," but I'd expect the standard for feature backports to be higher.
>

The patch to the "CQLSSTableWriter" is to support sending notification to
clients (Cassandra Analytics) when a new sstable is produced. Cassandra
Analytics, on receiving the notifications, can send sstables more eagerly,
hence reclaiming local disk space sooner.
To clarify, the patch is *not* needed for rolling upgrade. I mentioned in
an earlier email that if not backporting, there will be a different
solution for the lower version. The value of backporting is to eliminate
the need to develop and maintain multiple solutions (in Cassandra
Analytics).

– What's not possible if this isn't backported? What experience suffers
> today for lack of it / what problem does it solve? And what is the
> alternative/fallback if others are not supportive of backport?
>

It has *no* impact on the Cassandra server. W/o backporting, it affects the
Cassandra Analytics only. The problem and the alternative are stated above.

And to the last question, the answer is that it is *not* required for
upgrade.

Thank you for putting the questions together. Others probably have the same
questions. Hopefully it clears your concerns.

I also agree that 4.1.x release should not be blocked by this patch.

- Yifan

On Wed, Jul 31, 2024 at 2:14 PM C. Scott Andreas <sc...@paradoxica.net>
wrote:

> There are a few things unclear to me in this thread and the ticket, and
> details in the Jira are slim.
>
> Yifan / others supportive of backporting this feature, could you help me
> answer these questions?
>
> – What's this for? I'd appreciate a detailed explanation of what "Enhance
> CQLSSTableWriter to notify clients on sstable production" does and how it's
> meant to be used. Why is it needed for rolling upgrades? The phrasing of
> the ticket right now reads as nice-to-have rather than must-have. An
> earlier email described the value as "code quality and brings other
> benefits," but I'd expect the standard for feature backports to be higher.
>
> – What's not possible if this isn't backported? What experience suffers
> today for lack of it / what problem does it solve? And what is the
> alternative/fallback if others are not supportive of backport?
>
> – If this is deemed required for upgrade, that means users of previous
> releases would have to first upgrade to the latest release on their current
> train before upgrading to the latest major version. This is not a pattern
> that has been required in the past, and we should not introduce such a
> requirement. Do you intend this to be the required path for 4.1.x upgrades
> to 5.x+?
>
> My general thoughts:
>
> – The patch is small and the feature is small so I don't have much concern
> with a backport; zero-ish vote.
> – It definitely shouldn't block release of the current 4.1.x vote thread
> that's in progress.
> – We shouldn't introduce upgrade paths that require users to upgrade to
> at-minimum-patchlevel versions of current releases before upgrading to
> future majors; I'm -1 on that.
>
> Thanks,
>
> – Scott
>
> On Jul 31, 2024, at 2:04 PM, Jon Haddad <jo...@jonhaddad.com> wrote:
>
>
> I'm kind of neutral on this, maybe -0.  It's a small enough patch, but
> it's of limited value, given that Cassandra Analytics doesn't work with
> vnodes. That's the overwhelming majority of deployments.  So I'm not really
> sure what we gain here.
>
> On Wed, Jul 31, 2024 at 1:58 PM Yifan Cai <yc...@gmail.com> wrote:
>
>> Hi PMC team,
>>
>> There are so far two +1 and one -1. Please vote if you want to. It is
>> open for another 12 hours.
>>
>> 4.1 is to be released. I would like to include the patch, if possible,
>> according to the vote result.
>>
>> I recognize that patches to stable releases can be risky. When talking
>> about the trade off, we need to evaluate the benefit holistically,
>> considering all the projects under the Cassandra umbrella.
>> We surely do not want to backport the user-facing Cassandra features and
>> potentially demotivating upgrade.
>> IMO, the internal changes should be treated differently, as long as the
>> public interface does not change. In this particular case, Cassandra
>> Analytics provides the same bulk write feature regardless of backporting
>> the patch or not. But having the patch backported improves the code quality
>> and brings other benefits. Hope it answers Mick's message.
>>
>> Maybe it is time we start to think about categorizing the interfaces in
>> Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It
>> is not a suitable topic for this thread and requires a separate discussion.
>>
>> - Yifan
>>
>> On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mc...@apache.org> wrote:
>>
>>> reply below.
>>>
>>>  We're moving into a world where we will likely more frequently modify
>>>> the mainline branch with new functionality to integrate with ecosystem
>>>> changes (sidecar, analytics, drivers?). It's probably at least worth a
>>>> conversation as to whether our current policy (improvements and new
>>>> features main branch only) is optimal across everything equally or if there
>>>> should be nuance for ecosystem integrations.
>>>>
>>>
>>>
>>> This also incentivises intentionally not introducing support for that
>>> api in older mainlines.  We KISS, if the user wants that ecosystem benefit
>>> they need to upgrade to at least mainline X.
>>>
>>> Once older mainlines have it then we have this problem.  An alternative
>>> to the risk of having to always update all the mainlines, is to let the
>>> ecosystem branch to provide support for the different mainlines as/when
>>> needed.  Both are painful.
>>>
>>
>
>
>
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
I've realized that, although a vote is called, I forgot to create the
voting thread. I apologize for the oversight.

It looks like there's been no further discussion on this topic, so I'll go
ahead and set up a dedicated voting thread for the backport proposal
shortly.

Please vote once it is up.

- Yifan

On Thu, Aug 1, 2024 at 5:14 AM Sam Tunnicliffe <sa...@beobal.com> wrote:

> Sorry to derail the discussion but just on a point of order, there is
> actually precedent for requiring a minimum patch level before a major
> upgrade. For instance, from NEWS.txt:
>
> Upgrade to 3.0 is supported from Cassandra 2.1 versions greater or equal
> to 2.1.9, or Cassandra 2.2 versions greater or equal to 2.2.2.
>
> This approach has also been mentioned [1][2] as a means to introduce a
> property or setting to disable schema changes and the like before a major
> upgrade, though in this case it would be optional not required.
>
> [1]
> https://issues.apache.org/jira/browse/CASSANDRA-19556?focusedCommentId=17848544&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17848544
> [2]
> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-21%3A+Transactional+Cluster+Metadata#CEP21:TransactionalClusterMetadata-MigrationPlan
>
> On 31 Jul 2024, at 22:13, C. Scott Andreas <sc...@paradoxica.net> wrote:
>
> There are a few things unclear to me in this thread and the ticket, and
> details in the Jira are slim.
>
> Yifan / others supportive of backporting this feature, could you help me
> answer these questions?
>
> – What's this for? I'd appreciate a detailed explanation of what "Enhance
> CQLSSTableWriter to notify clients on sstable production" does and how it's
> meant to be used. Why is it needed for rolling upgrades? The phrasing of
> the ticket right now reads as nice-to-have rather than must-have. An
> earlier email described the value as "code quality and brings other
> benefits," but I'd expect the standard for feature backports to be higher.
>
> – What's not possible if this isn't backported? What experience suffers
> today for lack of it / what problem does it solve? And what is the
> alternative/fallback if others are not supportive of backport?
>
> – If this is deemed required for upgrade, that means users of previous
> releases would have to first upgrade to the latest release on their current
> train before upgrading to the latest major version. This is not a pattern
> that has been required in the past, and we should not introduce such a
> requirement. Do you intend this to be the required path for 4.1.x upgrades
> to 5.x+?
>
> My general thoughts:
>
> – The patch is small and the feature is small so I don't have much concern
> with a backport; zero-ish vote.
> – It definitely shouldn't block release of the current 4.1.x vote thread
> that's in progress.
> – We shouldn't introduce upgrade paths that require users to upgrade to
> at-minimum-patchlevel versions of current releases before upgrading to
> future majors; I'm -1 on that.
>
> Thanks,
>
> – Scott
>
> On Jul 31, 2024, at 2:04 PM, Jon Haddad <jo...@jonhaddad.com> wrote:
>
>
> I'm kind of neutral on this, maybe -0.  It's a small enough patch, but
> it's of limited value, given that Cassandra Analytics doesn't work with
> vnodes. That's the overwhelming majority of deployments.  So I'm not really
> sure what we gain here.
>
> On Wed, Jul 31, 2024 at 1:58 PM Yifan Cai <yc...@gmail.com> wrote:
>
>> Hi PMC team,
>>
>> There are so far two +1 and one -1. Please vote if you want to. It is
>> open for another 12 hours.
>>
>> 4.1 is to be released. I would like to include the patch, if possible,
>> according to the vote result.
>>
>> I recognize that patches to stable releases can be risky. When talking
>> about the trade off, we need to evaluate the benefit holistically,
>> considering all the projects under the Cassandra umbrella.
>> We surely do not want to backport the user-facing Cassandra features and
>> potentially demotivating upgrade.
>> IMO, the internal changes should be treated differently, as long as the
>> public interface does not change. In this particular case, Cassandra
>> Analytics provides the same bulk write feature regardless of backporting
>> the patch or not. But having the patch backported improves the code quality
>> and brings other benefits. Hope it answers Mick's message.
>>
>> Maybe it is time we start to think about categorizing the interfaces in
>> Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It
>> is not a suitable topic for this thread and requires a separate discussion.
>>
>> - Yifan
>>
>> On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mc...@apache.org> wrote:
>>
>>> reply below.
>>>
>>>  We're moving into a world where we will likely more frequently modify
>>>> the mainline branch with new functionality to integrate with ecosystem
>>>> changes (sidecar, analytics, drivers?). It's probably at least worth a
>>>> conversation as to whether our current policy (improvements and new
>>>> features main branch only) is optimal across everything equally or if there
>>>> should be nuance for ecosystem integrations.
>>>>
>>>
>>>
>>> This also incentivises intentionally not introducing support for that
>>> api in older mainlines.  We KISS, if the user wants that ecosystem benefit
>>> they need to upgrade to at least mainline X.
>>>
>>> Once older mainlines have it then we have this problem.  An alternative
>>> to the risk of having to always update all the mainlines, is to let the
>>> ecosystem branch to provide support for the different mainlines as/when
>>> needed.  Both are painful.
>>>
>>
>
>
>
>
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Sam Tunnicliffe <sa...@beobal.com>.
Sorry to derail the discussion but just on a point of order, there is actually precedent for requiring a minimum patch level before a major upgrade. For instance, from NEWS.txt:  

	Upgrade to 3.0 is supported from Cassandra 2.1 versions greater or equal to 2.1.9, or Cassandra 2.2 versions greater or equal to 2.2.2.

This approach has also been mentioned [1][2] as a means to introduce a property or setting to disable schema changes and the like before a major upgrade, though in this case it would be optional not required.

[1] https://issues.apache.org/jira/browse/CASSANDRA-19556?focusedCommentId=17848544&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17848544
[2] https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-21%3A+Transactional+Cluster+Metadata#CEP21:TransactionalClusterMetadata-MigrationPlan

> On 31 Jul 2024, at 22:13, C. Scott Andreas <sc...@paradoxica.net> wrote:
> 
> There are a few things unclear to me in this thread and the ticket, and details in the Jira are slim.
> 
> Yifan / others supportive of backporting this feature, could you help me answer these questions?
> 
> – What's this for? I'd appreciate a detailed explanation of what "Enhance CQLSSTableWriter to notify clients on sstable production" does and how it's meant to be used. Why is it needed for rolling upgrades? The phrasing of the ticket right now reads as nice-to-have rather than must-have. An earlier email described the value as "code quality and brings other benefits," but I'd expect the standard for feature backports to be higher.
> 
> – What's not possible if this isn't backported? What experience suffers today for lack of it / what problem does it solve? And what is the alternative/fallback if others are not supportive of backport?
> 
> – If this is deemed required for upgrade, that means users of previous releases would have to first upgrade to the latest release on their current train before upgrading to the latest major version. This is not a pattern that has been required in the past, and we should not introduce such a requirement. Do you intend this to be the required path for 4.1.x upgrades to 5.x+?
> 
> My general thoughts:
> 
> – The patch is small and the feature is small so I don't have much concern with a backport; zero-ish vote.
> – It definitely shouldn't block release of the current 4.1.x vote thread that's in progress.
> – We shouldn't introduce upgrade paths that require users to upgrade to at-minimum-patchlevel versions of current releases before upgrading to future majors; I'm -1 on that.
> 
> Thanks,
> 
> – Scott
> 
>> On Jul 31, 2024, at 2:04 PM, Jon Haddad <jo...@jonhaddad.com> wrote:
>> 
>> 
>> I'm kind of neutral on this, maybe -0.  It's a small enough patch, but it's of limited value, given that Cassandra Analytics doesn't work with vnodes. That's the overwhelming majority of deployments.  So I'm not really sure what we gain here.
>> 
>> On Wed, Jul 31, 2024 at 1:58 PM Yifan Cai <yc25code@gmail.com <ma...@gmail.com>> wrote:
>>> Hi PMC team, 
>>> 
>>> There are so far two +1 and one -1. Please vote if you want to. It is open for another 12 hours. 
>>> 
>>> 4.1 is to be released. I would like to include the patch, if possible, according to the vote result. 
>>> 
>>> I recognize that patches to stable releases can be risky. When talking about the trade off, we need to evaluate the benefit holistically, considering all the projects under the Cassandra umbrella. 
>>> We surely do not want to backport the user-facing Cassandra features and potentially demotivating upgrade. 
>>> IMO, the internal changes should be treated differently, as long as the public interface does not change. In this particular case, Cassandra Analytics provides the same bulk write feature regardless of backporting the patch or not. But having the patch backported improves the code quality and brings other benefits. Hope it answers Mick's message. 
>>> 
>>> Maybe it is time we start to think about categorizing the interfaces in Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It is not a suitable topic for this thread and requires a separate discussion. 
>>> 
>>> - Yifan
>>> 
>>> On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mck@apache.org <ma...@apache.org>> wrote:
>>>> reply below.
>>>> 
>>>>>  We're moving into a world where we will likely more frequently modify the mainline branch with new functionality to integrate with ecosystem changes (sidecar, analytics, drivers?). It's probably at least worth a conversation as to whether our current policy (improvements and new features main branch only) is optimal across everything equally or if there should be nuance for ecosystem integrations.
>>>> 
>>>> 
>>>> 
>>>> This also incentivises intentionally not introducing support for that api in older mainlines.  We KISS, if the user wants that ecosystem benefit they need to upgrade to at least mainline X.  
>>>> 
>>>> Once older mainlines have it then we have this problem.  An alternative to the risk of having to always update all the mainlines, is to let the ecosystem branch to provide support for the different mainlines as/when needed.  Both are painful.
> 
> 
> 
> 


Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by "C. Scott Andreas" <sc...@paradoxica.net>.
There are a few things unclear to me in this thread and the ticket, and details in the Jira are slim. Yifan / others supportive of backporting this feature, could you help me answer these questions? – What's this for? I'd appreciate a detailed explanation of what "Enhance CQLSSTableWriter to notify clients on sstable production" does and how it's meant to be used. Why is it needed for rolling upgrades? The phrasing of the ticket right now reads as nice-to-have rather than must-have. An earlier email described the value as "code quality and brings other benefits," but I'd expect the standard for feature backports to be higher. – What's not possible if this isn't backported? What experience suffers today for lack of it / what problem does it solve? And what is the alternative/fallback if others are not supportive of backport? – If this is deemed required for upgrade, that means users of previous releases would have to first upgrade to the latest release on their current train before upgrading to the latest major version. This is not a pattern that has been required in the past, and we should not introduce such a requirement. Do you intend this to be the required path for 4.1.x upgrades to 5.x+? My general thoughts: – The patch is small and the feature is small so I don't have much concern with a backport; zero-ish vote. – It definitely shouldn't block release of the current 4.1.x vote thread that's in progress. – We shouldn't introduce upgrade paths that require users to upgrade to at-minimum-patchlevel versions of current releases before upgrading to future majors; I'm -1 on that. Thanks, – Scott On Jul 31, 2024, at 2:04 PM, Jon Haddad <jo...@jonhaddad.com> wrote: I'm kind of neutral on this, maybe -0. It's a small enough patch, but it's of limited value, given that Cassandra Analytics doesn't work with vnodes. That's the overwhelming majority of deployments. So I'm not really sure what we gain here. On Wed, Jul 31, 2024 at 1:58 PM Yifan Cai < yc25code@gmail.com > wrote: Hi PMC team, There are so far two +1 and one -1. Please vote if you want to. It is open for another 12 hours. 4.1 is to be released. I would like to include the patch, if possible, according to the vote result. I recognize that patches to stable releases can be risky. When talking about the trade off, we need to evaluate the benefit holistically, considering all the projects under the Cassandra umbrella. We surely do not want to backport the user-facing Cassandra features and potentially demotivating upgrade. IMO, the internal changes should be treated differently, as long as the public interface does not change. In this particular case, Cassandra Analytics provides the same bulk write feature regardless of backporting the patch or not. But having the patch backported improves the code quality and brings other benefits. Hope it answers Mick's message. Maybe it is time we start to think about categorizing the interfaces in Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It is not a suitable topic for this thread and requires a separate discussion. - Yifan On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever < mck@apache.org > wrote: reply below. We're moving into a world where we will likely more frequently modify the mainline branch with new functionality to integrate with ecosystem changes (sidecar, analytics, drivers?). It's probably at least worth a conversation as to whether our current policy (improvements and new features main branch only) is optimal across everything equally or if there should be nuance for ecosystem integrations. This also incentivises intentionally not introducing support for that api in older mainlines. We KISS, if the user wants that ecosystem benefit they need to upgrade to at least mainline X. Once older mainlines have it then we have this problem. An alternative to the risk of having to always update all the mainlines, is to let the ecosystem branch to provide support for the different mainlines as/when needed. Both are painful.

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Jon Haddad <jo...@jonhaddad.com>.
I'm kind of neutral on this, maybe -0.  It's a small enough patch, but it's
of limited value, given that Cassandra Analytics doesn't work with vnodes.
That's the overwhelming majority of deployments.  So I'm not really sure
what we gain here.

On Wed, Jul 31, 2024 at 1:58 PM Yifan Cai <yc...@gmail.com> wrote:

> Hi PMC team,
>
> There are so far two +1 and one -1. Please vote if you want to. It is open
> for another 12 hours.
>
> 4.1 is to be released. I would like to include the patch, if possible,
> according to the vote result.
>
> I recognize that patches to stable releases can be risky. When talking
> about the trade off, we need to evaluate the benefit holistically,
> considering all the projects under the Cassandra umbrella.
> We surely do not want to backport the user-facing Cassandra features and
> potentially demotivating upgrade.
> IMO, the internal changes should be treated differently, as long as the
> public interface does not change. In this particular case, Cassandra
> Analytics provides the same bulk write feature regardless of backporting
> the patch or not. But having the patch backported improves the code quality
> and brings other benefits. Hope it answers Mick's message.
>
> Maybe it is time we start to think about categorizing the interfaces in
> Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It
> is not a suitable topic for this thread and requires a separate discussion.
>
> - Yifan
>
> On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mc...@apache.org> wrote:
>
>> reply below.
>>
>>  We're moving into a world where we will likely more frequently modify
>>> the mainline branch with new functionality to integrate with ecosystem
>>> changes (sidecar, analytics, drivers?). It's probably at least worth a
>>> conversation as to whether our current policy (improvements and new
>>> features main branch only) is optimal across everything equally or if there
>>> should be nuance for ecosystem integrations.
>>>
>>
>>
>> This also incentivises intentionally not introducing support for that api
>> in older mainlines.  We KISS, if the user wants that ecosystem benefit they
>> need to upgrade to at least mainline X.
>>
>> Once older mainlines have it then we have this problem.  An alternative
>> to the risk of having to always update all the mainlines, is to let the
>> ecosystem branch to provide support for the different mainlines as/when
>> needed.  Both are painful.
>>
>>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
Hi PMC team,

There are so far two +1 and one -1. Please vote if you want to. It is open
for another 12 hours.

4.1 is to be released. I would like to include the patch, if possible,
according to the vote result.

I recognize that patches to stable releases can be risky. When talking
about the trade off, we need to evaluate the benefit holistically,
considering all the projects under the Cassandra umbrella.
We surely do not want to backport the user-facing Cassandra features and
potentially demotivating upgrade.
IMO, the internal changes should be treated differently, as long as the
public interface does not change. In this particular case, Cassandra
Analytics provides the same bulk write feature regardless of backporting
the patch or not. But having the patch backported improves the code quality
and brings other benefits. Hope it answers Mick's message.

Maybe it is time we start to think about categorizing the interfaces in
Cassandra into 1) public API, 2) internal API, and 3) evolving API, etc. It
is not a suitable topic for this thread and requires a separate discussion.

- Yifan

On Tue, Jul 30, 2024 at 11:47 AM Mick Semb Wever <mc...@apache.org> wrote:

> reply below.
>
>  We're moving into a world where we will likely more frequently modify
>> the mainline branch with new functionality to integrate with ecosystem
>> changes (sidecar, analytics, drivers?). It's probably at least worth a
>> conversation as to whether our current policy (improvements and new
>> features main branch only) is optimal across everything equally or if there
>> should be nuance for ecosystem integrations.
>>
>
>
> This also incentivises intentionally not introducing support for that api
> in older mainlines.  We KISS, if the user wants that ecosystem benefit they
> need to upgrade to at least mainline X.
>
> Once older mainlines have it then we have this problem.  An alternative to
> the risk of having to always update all the mainlines, is to let the
> ecosystem branch to provide support for the different mainlines as/when
> needed.  Both are painful.
>
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Mick Semb Wever <mc...@apache.org>.
reply below.

 We're moving into a world where we will likely more frequently modify the
> mainline branch with new functionality to integrate with ecosystem changes
> (sidecar, analytics, drivers?). It's probably at least worth a conversation
> as to whether our current policy (improvements and new features main branch
> only) is optimal across everything equally or if there should be nuance for
> ecosystem integrations.
>


This also incentivises intentionally not introducing support for that api
in older mainlines.  We KISS, if the user wants that ecosystem benefit they
need to upgrade to at least mainline X.

Once older mainlines have it then we have this problem.  An alternative to
the risk of having to always update all the mainlines, is to let the
ecosystem branch to provide support for the different mainlines as/when
needed.  Both are painful.

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Dinesh Joshi <dj...@apache.org>.
Any change we bring to stable releases, even though it is non-user facing
change, brings in the possibility of introducing bugs and / or unintended
side effects. Therefore it is important to carefully consider the trade
offs when we make changes to older releases. We also have a precedent to
make changes to older releases for testing.

In this particular case Yifan's patch is touching a fairly isolated class
and presents a low risk. The benefit here is that the analytics sub-project
would avoid additional work arounds for Cassandra 4 & 4.1. I am fine with
granting an exception for backporting to 4.1 and 4.0 in this case.

thanks,

Dinesh

On Tue, Jul 30, 2024 at 9:52 AM Yifan Cai <yc...@gmail.com> wrote:

> Here is my 2 cents. Maybe we need to differentiate the user-facing
> improvements and ecosystem-internal improvements, or have a discussion
> about it.
> I guess when the current policy of "improvements and new features on trunk
> only" was made, it was to target the user-facing improvements. The internal
> changes are not exposed to cassandra users directly.
> As Josh pointed out, with more projects (sidecar and analytics have
> dependency on cassandra public interface) in the ecosystem, we are more
> likely to encounter the scenarios where we want to modify the mainline
> branches for integration purposes.
>
> The downside of preventing the integration updates to the older branches
> is having different solutions per Cassandra version in the other projects
> under the Cassandra umbrella. It is a maintenance pain and potentially
> causes errors. It is my original motivation of backporting the patch to the
> other branches.
>
> - Yifan
>
> On Tue, Jul 30, 2024 at 6:04 AM Josh McKenzie <jm...@apache.org>
> wrote:
>
>> Some thoughts:
>>
>>    1. Most of our PMC votes are majority-based, not binding -1. So Jeff
>>    being -1 doesn't mean the whole PMC being -1. So don't take his -1 as being
>>    a show stopper or indicative of everyone on the PMC (and don't take me
>>    saying this as the converse ;))
>>    2. I expect we have a lot of debt when it comes to our ecosystem
>>    integrations on older branches. Bringing those projects into the ASF
>>    umbrella and into the project ecosystem is at odds with a hard policy of
>>    "we don't add improvements or new features to old branches",
>>    *specifically* in cases like this where the desire is to get uniform
>>    support for ecosystem projects across all supported branches of C*
>>    3. We're moving into a world where we will likely more frequently
>>    modify the mainline branch with new functionality to integrate with
>>    ecosystem changes (sidecar, analytics, drivers?). It's probably at least
>>    worth a conversation as to whether our current policy (improvements and new
>>    features main branch only) is optimal across everything equally or if there
>>    should be nuance for ecosystem integrations.
>>    4. To Jeff's point: everyone is always going to have some minor
>>    improvement they'd like to back-port to older branches.
>>
>> I haven't thought deeply enough about this specific situation to have a
>> well formed opinion, but figured calling out the above things is worth
>> doing. This probably won't be the last time we look at our supported
>> branches and have some pain we'd like to address based on the inconsistent
>> ecosystem support and API piece across them.
>>
>> On Mon, Jul 29, 2024, at 1:32 PM, Yifan Cai wrote:
>>
>> It sounds like we are all good with backporting to 5.0.
>>
>> Thank you all for the feedback.
>>
>> - Yifan
>>
>> On Fri, Jul 26, 2024 at 12:21 PM Jeff Jirsa <jj...@gmail.com> wrote:
>>
>>
>>
>>
>> On Jul 26, 2024, at 11:09 AM, Yifan Cai <yc...@gmail.com> wrote:
>>
>> 
>> Thanks Jeff for restating the policy.
>>
>> According to the release lifecycle doc
>>
>>
>>    - Missing features from newer generation releases are back-ported on
>>    per - PMC vote basis.
>>
>> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>>
>> We do not have a policy to prevent new features strictly for the branches
>> in maintenance state.
>>
>> IMO, the patch qualifies as the missing feature. (As said, it is useful
>> for Cassandra Analytics, and it is good to have the same bridge
>> implementation amongst different cassandra versions)
>>
>> Therefore, I would like to call for a vote.
>>
>>
>> Sure
>>
>> I’m -1 on 4.0 and 4.1
>>
>> - Jeff
>>
>>
>> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa <jj...@gmail.com> wrote:
>>
>> Everyone has a low risk change they want to backport to every branch, 4.0
>> and 4.1 in particular are way past the point we should be adding features
>>
>> The policy exists and it’s a pure feature not a regression
>>
>>
>>
>>
>>
>> > On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
>> >
>> > Given how low risk this is, I don't see an issue with backporting it
>> > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
>> > though, not 5.0.0)
>> >
>> > Kind Regards,
>> > Brandon
>> >
>> >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
>> >>
>> >> Hi everyone,
>> >>
>> >> CASSANDRA-19800 is currently in the state of ready to be committed.
>> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
>> >>
>> >> The ability to notify CQLSSTableWriter user when new sstables are
>> produced is especially useful for Cassandra Analytics and other consumers.
>> The API is more reliable than monitoring the file directory.
>> >>
>> >> That being said, I am aware that the patch is an improvement and trunk
>> only. I want to ask for an exemption on backporting the patch for two
>> reasons. It is useful for Cassandra Analytics. The patch is low risk for
>> Cassandra server as it only touches CQLSSTableWriter, which is only used by
>> toolings.
>> >>
>> >> - Yifan
>>
>>
>>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
Here is my 2 cents. Maybe we need to differentiate the user-facing
improvements and ecosystem-internal improvements, or have a discussion
about it.
I guess when the current policy of "improvements and new features on trunk
only" was made, it was to target the user-facing improvements. The internal
changes are not exposed to cassandra users directly.
As Josh pointed out, with more projects (sidecar and analytics have
dependency on cassandra public interface) in the ecosystem, we are more
likely to encounter the scenarios where we want to modify the mainline
branches for integration purposes.

The downside of preventing the integration updates to the older branches is
having different solutions per Cassandra version in the other projects
under the Cassandra umbrella. It is a maintenance pain and potentially
causes errors. It is my original motivation of backporting the patch to the
other branches.

- Yifan

On Tue, Jul 30, 2024 at 6:04 AM Josh McKenzie <jm...@apache.org> wrote:

> Some thoughts:
>
>    1. Most of our PMC votes are majority-based, not binding -1. So Jeff
>    being -1 doesn't mean the whole PMC being -1. So don't take his -1 as being
>    a show stopper or indicative of everyone on the PMC (and don't take me
>    saying this as the converse ;))
>    2. I expect we have a lot of debt when it comes to our ecosystem
>    integrations on older branches. Bringing those projects into the ASF
>    umbrella and into the project ecosystem is at odds with a hard policy of
>    "we don't add improvements or new features to old branches",
>    *specifically* in cases like this where the desire is to get uniform
>    support for ecosystem projects across all supported branches of C*
>    3. We're moving into a world where we will likely more frequently
>    modify the mainline branch with new functionality to integrate with
>    ecosystem changes (sidecar, analytics, drivers?). It's probably at least
>    worth a conversation as to whether our current policy (improvements and new
>    features main branch only) is optimal across everything equally or if there
>    should be nuance for ecosystem integrations.
>    4. To Jeff's point: everyone is always going to have some minor
>    improvement they'd like to back-port to older branches.
>
> I haven't thought deeply enough about this specific situation to have a
> well formed opinion, but figured calling out the above things is worth
> doing. This probably won't be the last time we look at our supported
> branches and have some pain we'd like to address based on the inconsistent
> ecosystem support and API piece across them.
>
> On Mon, Jul 29, 2024, at 1:32 PM, Yifan Cai wrote:
>
> It sounds like we are all good with backporting to 5.0.
>
> Thank you all for the feedback.
>
> - Yifan
>
> On Fri, Jul 26, 2024 at 12:21 PM Jeff Jirsa <jj...@gmail.com> wrote:
>
>
>
>
> On Jul 26, 2024, at 11:09 AM, Yifan Cai <yc...@gmail.com> wrote:
>
> 
> Thanks Jeff for restating the policy.
>
> According to the release lifecycle doc
>
>
>    - Missing features from newer generation releases are back-ported on
>    per - PMC vote basis.
>
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> We do not have a policy to prevent new features strictly for the branches
> in maintenance state.
>
> IMO, the patch qualifies as the missing feature. (As said, it is useful
> for Cassandra Analytics, and it is good to have the same bridge
> implementation amongst different cassandra versions)
>
> Therefore, I would like to call for a vote.
>
>
> Sure
>
> I’m -1 on 4.0 and 4.1
>
> - Jeff
>
>
> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa <jj...@gmail.com> wrote:
>
> Everyone has a low risk change they want to backport to every branch, 4.0
> and 4.1 in particular are way past the point we should be adding features
>
> The policy exists and it’s a pure feature not a regression
>
>
>
>
>
> > On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
> >
> > Given how low risk this is, I don't see an issue with backporting it
> > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
> > though, not 5.0.0)
> >
> > Kind Regards,
> > Brandon
> >
> >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
> >>
> >> Hi everyone,
> >>
> >> CASSANDRA-19800 is currently in the state of ready to be committed.
> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
> >>
> >> The ability to notify CQLSSTableWriter user when new sstables are
> produced is especially useful for Cassandra Analytics and other consumers.
> The API is more reliable than monitoring the file directory.
> >>
> >> That being said, I am aware that the patch is an improvement and trunk
> only. I want to ask for an exemption on backporting the patch for two
> reasons. It is useful for Cassandra Analytics. The patch is low risk for
> Cassandra server as it only touches CQLSSTableWriter, which is only used by
> toolings.
> >>
> >> - Yifan
>
>
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Josh McKenzie <jm...@apache.org>.
Some thoughts:
 1. Most of our PMC votes are majority-based, not binding -1. So Jeff being -1 doesn't mean the whole PMC being -1. So don't take his -1 as being a show stopper or indicative of everyone on the PMC (and don't take me saying this as the converse ;))
 2. I expect we have a lot of debt when it comes to our ecosystem integrations on older branches. Bringing those projects into the ASF umbrella and into the project ecosystem is at odds with a hard policy of "we don't add improvements or new features to old branches", *specifically* in cases like this where the desire is to get uniform support for ecosystem projects across all supported branches of C*
 3. We're moving into a world where we will likely more frequently modify the mainline branch with new functionality to integrate with ecosystem changes (sidecar, analytics, drivers?). It's probably at least worth a conversation as to whether our current policy (improvements and new features main branch only) is optimal across everything equally or if there should be nuance for ecosystem integrations.
 4. To Jeff's point: everyone is always going to have some minor improvement they'd like to back-port to older branches.
I haven't thought deeply enough about this specific situation to have a well formed opinion, but figured calling out the above things is worth doing. This probably won't be the last time we look at our supported branches and have some pain we'd like to address based on the inconsistent ecosystem support and API piece across them.

On Mon, Jul 29, 2024, at 1:32 PM, Yifan Cai wrote:
> It sounds like we are all good with backporting to 5.0. 
> 
> Thank you all for the feedback.
> 
> - Yifan
> 
> On Fri, Jul 26, 2024 at 12:21 PM Jeff Jirsa <jj...@gmail.com> wrote:
>> 
>> 
>> 
>>> On Jul 26, 2024, at 11:09 AM, Yifan Cai <yc...@gmail.com> wrote:
>>> 
>>> Thanks Jeff for restating the policy.
>>> 
>>> According to the release lifecycle doc
>>>>  • Missing features from newer generation releases are back-ported on per - PMC vote basis.
>>> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle 
>>> 
>>> We do not have a policy to prevent new features strictly for the branches in maintenance state. 
>>> 
>>> IMO, the patch qualifies as the missing feature. (As said, it is useful for Cassandra Analytics, and it is good to have the same bridge implementation amongst different cassandra versions)
>>> 
>>> Therefore, I would like to call for a vote. 
>> 
>> Sure
>> 
>> I’m -1 on 4.0 and 4.1
>> 
>> - Jeff
>> 
>>> 
>>> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa <jj...@gmail.com> wrote:
>>>> Everyone has a low risk change they want to backport to every branch, 4.0 and 4.1 in particular are way past the point we should be adding features 
>>>> 
>>>> The policy exists and it’s a pure feature not a regression
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> > On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
>>>> > 
>>>> > Given how low risk this is, I don't see an issue with backporting it
>>>> > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
>>>> > though, not 5.0.0)
>>>> > 
>>>> > Kind Regards,
>>>> > Brandon
>>>> > 
>>>> >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
>>>> >> 
>>>> >> Hi everyone,
>>>> >> 
>>>> >> CASSANDRA-19800 is currently in the state of ready to be committed. Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
>>>> >> 
>>>> >> The ability to notify CQLSSTableWriter user when new sstables are produced is especially useful for Cassandra Analytics and other consumers. The API is more reliable than monitoring the file directory.
>>>> >> 
>>>> >> That being said, I am aware that the patch is an improvement and trunk only. I want to ask for an exemption on backporting the patch for two reasons. It is useful for Cassandra Analytics. The patch is low risk for Cassandra server as it only touches CQLSSTableWriter, which is only used by toolings.
>>>> >> 
>>>> >> - Yifan

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
It sounds like we are all good with backporting to 5.0.

Thank you all for the feedback.

- Yifan

On Fri, Jul 26, 2024 at 12:21 PM Jeff Jirsa <jj...@gmail.com> wrote:

>
>
> On Jul 26, 2024, at 11:09 AM, Yifan Cai <yc...@gmail.com> wrote:
>
> 
> Thanks Jeff for restating the policy.
>
> According to the release lifecycle doc
>
>>
>>    - Missing features from newer generation releases are back-ported on
>>    per - PMC vote basis.
>>
>> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> We do not have a policy to prevent new features strictly for the branches
> in maintenance state.
>
> IMO, the patch qualifies as the missing feature. (As said, it is useful
> for Cassandra Analytics, and it is good to have the same bridge
> implementation amongst different cassandra versions)
>
> Therefore, I would like to call for a vote.
>
>
> Sure
>
> I’m -1 on 4.0 and 4.1
>
> - Jeff
>
>
> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa <jj...@gmail.com> wrote:
>
>> Everyone has a low risk change they want to backport to every branch, 4.0
>> and 4.1 in particular are way past the point we should be adding features
>>
>> The policy exists and it’s a pure feature not a regression
>>
>>
>>
>>
>>
>> > On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
>> >
>> > Given how low risk this is, I don't see an issue with backporting it
>> > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
>> > though, not 5.0.0)
>> >
>> > Kind Regards,
>> > Brandon
>> >
>> >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
>> >>
>> >> Hi everyone,
>> >>
>> >> CASSANDRA-19800 is currently in the state of ready to be committed.
>> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
>> >>
>> >> The ability to notify CQLSSTableWriter user when new sstables are
>> produced is especially useful for Cassandra Analytics and other consumers.
>> The API is more reliable than monitoring the file directory.
>> >>
>> >> That being said, I am aware that the patch is an improvement and trunk
>> only. I want to ask for an exemption on backporting the patch for two
>> reasons. It is useful for Cassandra Analytics. The patch is low risk for
>> Cassandra server as it only touches CQLSSTableWriter, which is only used by
>> toolings.
>> >>
>> >> - Yifan
>>
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Jeff Jirsa <jj...@gmail.com>.
  

  

> On Jul 26, 2024, at 11:09 AM, Yifan Cai <yc...@gmail.com> wrote:  
>  
>

> 
>
> Thanks Jeff for restating the policy.
>
>  
>
>
> According to the release lifecycle doc
>

>>   * Missing features from newer generation releases are back-ported on per
- PMC vote basis.

>>

>
> <https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle>  
>
>
>  
>
>
> We do not have a policy to prevent new features strictly for the branches in
> maintenance state.
>
>  
>
>
> IMO, the patch qualifies as the missing feature. (As said, it is useful for
> Cassandra Analytics, and it is good to have the same bridge implementation
> amongst different cassandra versions)
>
>  
>
>
> Therefore, I would like to call for a vote.

  

Sure

  

I’m -1 on 4.0 and 4.1

  

\- Jeff

  

>  
>
>
> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa
> <[jjirsa@gmail.com](mailto:jjirsa@gmail.com)> wrote:  
>
>

>> Everyone has a low risk change they want to backport to every branch, 4.0
and 4.1 in particular are way past the point we should be adding features  
>  
>  The policy exists and it’s a pure feature not a regression  
>  
>  
>  
>  
>  
>  > On Jul 26, 2024, at 9:59 AM, Brandon Williams
> <[driftx@gmail.com](mailto:driftx@gmail.com)> wrote:  
>  >  
>  > Given how low risk this is, I don't see an issue with backporting it  
>  > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1  
>  > though, not 5.0.0)  
>  >  
>  > Kind Regards,  
>  > Brandon  
>  >  
>  >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai
> <[yc25code@gmail.com](mailto:yc25code@gmail.com)> wrote:  
>  >>  
>  >> Hi everyone,  
>  >>  
>  >> CASSANDRA-19800 is currently in the state of ready to be committed.
> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.  
>  >>  
>  >> The ability to notify CQLSSTableWriter user when new sstables are
> produced is especially useful for Cassandra Analytics and other consumers.
> The API is more reliable than monitoring the file directory.  
>  >>  
>  >> That being said, I am aware that the patch is an improvement and trunk
> only. I want to ask for an exemption on backporting the patch for two
> reasons. It is useful for Cassandra Analytics. The patch is low risk for
> Cassandra server as it only touches CQLSSTableWriter, which is only used by
> toolings.  
>  >>  
>  >> \- Yifan  
>


Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
Hi Jeremiah,

It is an interesting idea. As of now, I think it is too much of a risk (or
not feasible at all) to only use 5.0/trunk Cassandra-all dependency in
Cassandra Analytics, since it depends on other components in Cassandra.

- Yifan

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by "J. D. Jordan" <je...@gmail.com>.
I thought the server now has the ability to write out old sstable versions?
So you could use the CQLSSTableWriter from 5.0/trunk to write out sstables 4.0
can read?

  

> On Jul 26, 2024, at 1:07 PM, Yifan Cai <yc...@gmail.com> wrote:  
>  
>

>  Caution: The sender name (Yifan Cai) is different from their email address
> (yc25code@gmail.com), which may indicate an impersonation attempt. Verify
> the email's authenticity with the sender using your organization's trusted
> contact list before replying or taking further action.  
> ---  
> [ Secured by Check Point ](https://www.checkpoint.com/harmony/email-
> security/email-office?friew)  
>  
>
>
> Thanks Jeff for restating the policy.
>
>  
>
>
> According to the release lifecycle doc
>

>>   * Missing features from newer generation releases are back-ported on per
- PMC vote basis.

>>

>
> <https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle>  
>
>
>  
>
>
> We do not have a policy to prevent new features strictly for the branches in
> maintenance state.
>
>  
>
>
> IMO, the patch qualifies as the missing feature. (As said, it is useful for
> Cassandra Analytics, and it is good to have the same bridge implementation
> amongst different cassandra versions)
>
>  
>
>
> Therefore, I would like to call for a vote.
>
>  
>
>
> On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa
> <[jjirsa@gmail.com](mailto:jjirsa@gmail.com)> wrote:  
>
>

>> Everyone has a low risk change they want to backport to every branch, 4.0
and 4.1 in particular are way past the point we should be adding features  
>  
>  The policy exists and it’s a pure feature not a regression  
>  
>  
>  
>  
>  
>  > On Jul 26, 2024, at 9:59 AM, Brandon Williams
> <[driftx@gmail.com](mailto:driftx@gmail.com)> wrote:  
>  >  
>  > Given how low risk this is, I don't see an issue with backporting it  
>  > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1  
>  > though, not 5.0.0)  
>  >  
>  > Kind Regards,  
>  > Brandon  
>  >  
>  >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai
> <[yc25code@gmail.com](mailto:yc25code@gmail.com)> wrote:  
>  >>  
>  >> Hi everyone,  
>  >>  
>  >> CASSANDRA-19800 is currently in the state of ready to be committed.
> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.  
>  >>  
>  >> The ability to notify CQLSSTableWriter user when new sstables are
> produced is especially useful for Cassandra Analytics and other consumers.
> The API is more reliable than monitoring the file directory.  
>  >>  
>  >> That being said, I am aware that the patch is an improvement and trunk
> only. I want to ask for an exemption on backporting the patch for two
> reasons. It is useful for Cassandra Analytics. The patch is low risk for
> Cassandra server as it only touches CQLSSTableWriter, which is only used by
> toolings.  
>  >>  
>  >> \- Yifan  
>


Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Yifan Cai <yc...@gmail.com>.
Thanks Jeff for restating the policy.

According to the release lifecycle doc

>
>    - Missing features from newer generation releases are back-ported on
>    per - PMC vote basis.
>
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle

We do not have a policy to prevent new features strictly for the branches
in maintenance state.

IMO, the patch qualifies as the missing feature. (As said, it is useful for
Cassandra Analytics, and it is good to have the same bridge implementation
amongst different cassandra versions)

Therefore, I would like to call for a vote.

On Fri, Jul 26, 2024 at 10:25 AM Jeff Jirsa <jj...@gmail.com> wrote:

> Everyone has a low risk change they want to backport to every branch, 4.0
> and 4.1 in particular are way past the point we should be adding features
>
> The policy exists and it’s a pure feature not a regression
>
>
>
>
>
> > On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
> >
> > Given how low risk this is, I don't see an issue with backporting it
> > and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
> > though, not 5.0.0)
> >
> > Kind Regards,
> > Brandon
> >
> >> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
> >>
> >> Hi everyone,
> >>
> >> CASSANDRA-19800 is currently in the state of ready to be committed.
> Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
> >>
> >> The ability to notify CQLSSTableWriter user when new sstables are
> produced is especially useful for Cassandra Analytics and other consumers.
> The API is more reliable than monitoring the file directory.
> >>
> >> That being said, I am aware that the patch is an improvement and trunk
> only. I want to ask for an exemption on backporting the patch for two
> reasons. It is useful for Cassandra Analytics. The patch is low risk for
> Cassandra server as it only touches CQLSSTableWriter, which is only used by
> toolings.
> >>
> >> - Yifan
>

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Jeff Jirsa <jj...@gmail.com>.
Everyone has a low risk change they want to backport to every branch, 4.0 and 4.1 in particular are way past the point we should be adding features 

The policy exists and it’s a pure feature not a regression





> On Jul 26, 2024, at 9:59 AM, Brandon Williams <dr...@gmail.com> wrote:
> 
> Given how low risk this is, I don't see an issue with backporting it
> and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
> though, not 5.0.0)
> 
> Kind Regards,
> Brandon
> 
>> On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
>> 
>> Hi everyone,
>> 
>> CASSANDRA-19800 is currently in the state of ready to be committed. Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
>> 
>> The ability to notify CQLSSTableWriter user when new sstables are produced is especially useful for Cassandra Analytics and other consumers. The API is more reliable than monitoring the file directory.
>> 
>> That being said, I am aware that the patch is an improvement and trunk only. I want to ask for an exemption on backporting the patch for two reasons. It is useful for Cassandra Analytics. The patch is low risk for Cassandra server as it only touches CQLSSTableWriter, which is only used by toolings.
>> 
>> - Yifan

Re: [DISCUSS] Backport CASSANDRA-19800 to Cassandra-4.0, 4.1 and 5.0

Posted by Brandon Williams <dr...@gmail.com>.
Given how low risk this is, I don't see an issue with backporting it
and I'm sure the usefulness outweighs what risk there is. +1 (5.0.1
though, not 5.0.0)

Kind Regards,
Brandon

On Fri, Jul 26, 2024 at 11:52 AM Yifan Cai <yc...@gmail.com> wrote:
>
> Hi everyone,
>
> CASSANDRA-19800 is currently in the state of ready to be committed. Before that, I want to propose backporting it to 4.0, 4.1 and 5.0.
>
> The ability to notify CQLSSTableWriter user when new sstables are produced is especially useful for Cassandra Analytics and other consumers. The API is more reliable than monitoring the file directory.
>
> That being said, I am aware that the patch is an improvement and trunk only. I want to ask for an exemption on backporting the patch for two reasons. It is useful for Cassandra Analytics. The patch is low risk for Cassandra server as it only touches CQLSSTableWriter, which is only used by toolings.
>
> - Yifan