[GitHub] [spark] mridulm commented on pull request #30139: [SPARK-31069][CORE] Avoid repeat compute `chunksBeingTransferred` cause hight cpu cost in external shuffle service when `maxChunksBeingTransferred` use default value.

[GitBox <gi...@apache.org>]

mridulm commented on pull request #30139:
URL: https://github.com/apache/spark/pull/30139#issuecomment-726894485


   @AngersZhuuuu To clarify, the updated behavior of the PR is that by default we dont incur the cost of computing `chunksBeingTransferred` as default values disable `maxChunksBeingTransferred`. But if `maxChunksBeingTransferred` is configured, the performance characteristics is same as earlier.
   
   I am fine with the change, ideally we should fix the behavior even when `maxChunksBeingTransferred` is configured, but that can be a followup work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org