You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/05/03 10:10:42 UTC

[GitHub] [accumulo] Manno15 commented on a change in pull request #2044: Addition unit test to exclude from using reuseForks

Manno15 commented on a change in pull request #2044:
URL: https://github.com/apache/accumulo/pull/2044#discussion_r624993502



##########
File path: server/base/pom.xml
##########
@@ -128,6 +128,35 @@
         <directory>src/test/resources</directory>
       </testResource>
     </testResources>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-surefire-plugin</artifactId>
+          <configuration>
+            <!-- Tests that cannot run with reuseForks=true -->
+            <excludes>
+              <exclude>**/AuthenticationTokenSecretManagerTest.java</exclude>
+            </excludes>
+          </configuration>
+          <executions>
+            <execution>
+              <id>reuseForks-false-tests</id>
+              <goals>
+                <goal>test</goal>
+              </goals>
+              <configuration>
+                <reuseForks>false</reuseForks>
+                <excludes combine.self="override" />
+                <includes>
+                  <include>**/AuthenticationTokenSecretManagerTest.java</include>
+                </includes>
+              </configuration>
+            </execution>
+          </executions>
+        </plugin>
+      </plugins>
+    </pluginManagement>

Review comment:
       That's fair, I wasn't quite sure. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org