[GitHub] rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181338037
 
 

 ##########
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##########
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, String allocationUnits, Str
                 String allocationUnits = disk.getAttribute("ovf:capacityAllocationUnits");
                 od._diskId = disk.getAttribute("ovf:diskId");
                 od._fileRef = disk.getAttribute("ovf:fileRef");
-                od._populatedSize = Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : disk.getAttribute("ovf:populatedSize"));
+                od._populatedSize = NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   @nvazquez this can cause exception still -- this should be used with a default value like `0L` in case of error. For example like this -- `NumberUtils.toLong("string-param", 0L) `. Also no tests were ran /cc @DaanHoogland 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services