You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/18 03:02:58 UTC
[GitHub] [apisix-ingress-controller] shelltea opened a new issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
shelltea opened a new issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638
Add the CRD like `ApisixPluginConfig` to support a group of plugin configs, and `ApisixRoute` add a filed be associated with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973928489
> Feel free to paste your questions there :).
@neverCase If you need help, please feel free to ping us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973700793
@tao12345666333 @shelltea
Actually, I have time to fix this, but I need more help.
I'm willing to contribute my codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-900836800
Add this to v1.3 milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925501421
@neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924763045
ok, got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391
ok, i had created ApisixPluginConfig.yaml and add 3 structs `ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the v2alpha1/types.go.
But i had trouble in making up fields inside `ApisixPluginConfigSpec`, because i can't find any structs which could be linked to the `plugin` in types.go.
```sh
// +genclient
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:subresource:status
// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
// An ApisixPluginConfig is used to support a group of plugin configs
type ApisixPluginConfig struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus `json:"status,omitempty" yaml:"status,omitempty"`
}
// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// ApisixPluginConfigList contains a list of ApisixPluginConfig.
type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixPluginConfig `json:"items,omitempty" yaml:"items,omitempty"`
}
```
could u provide me more details about the plugins
@tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925514670
You can open a PR and set it as draf status. Related discussions can be held in the PR, which will be more convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781841
> #694 has been merged. 馃憤 You can do this job @neverCase
>
> * [ ] Add client implementation to interact with Apache APISIX.
ok, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391
ok, i had created ApisixPluginConfig.yaml and add 3 structs `ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the v2alpha1/types.go.
But i had trouble in making up fields inside `ApisixPluginConfigSpec`, because i can't find any structs could be linked to the `plugin` in types.go.
```sh
// +genclient
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:subresource:status
// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
// An ApisixPluginConfig is used to support a group of plugin configs
type ApisixPluginConfig struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus `json:"status,omitempty" yaml:"status,omitempty"`
}
// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// ApisixPluginConfigList contains a list of ApisixPluginConfig.
type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixPluginConfig `json:"items,omitempty" yaml:"items,omitempty"`
}
```
could u provide me more details about the plugins
@tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924711179
cc @Donghui0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-988588107
@neverCase Thanks for your work, if you have time, you can continue the development of follow-up tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase removed a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase removed a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547
> #694 has been merged. 馃憤 You can do this job @neverCase
>
> * [ ] Add client implementation to interact with Apache APISIX.
@tao12345666333
Does this task mean that i should implement the webhook and validation?
e.g. `github.com/apache/apisix-ingress-controller/pkg/api/validation"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975023739
馃憣 i will update today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925446318
> I had replied a mail on the apache mail list, but it seems something wrong.
> After sending, i can't find my reply on the mail list.
> @tao12345666333 @tokers
Yes, you need to subscribe the dev@apisix.apache.org before you send any mails.
**Of course, whether you are discussing in this issue or on the mailing list, it鈥檚 okay.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975193850
@neverCase I hope you complete the definition of CRD and data type first. eg. #689 or #694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fengshunli commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
fengshunli commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-927024565
@tao12345666333 init apisix crd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] shelltea commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
shelltea commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978756518
@tao12345666333 I am very interested, but I'm not familiar with go and Kubernetes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-977931641
#694 has been merged. 馃憤 You can do this job @neverCase
- [ ] Add client implementation to interact with Apache APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781461
> * chore: consumer data structures by tokers 路 Pull Request #470 路 apache/apisix-ingress-controller
ok, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005932964
Thanks! @neverCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547
> #694 has been merged. 馃憤 You can do this job @neverCase
>
> * [ ] Add client implementation to interact with Apache APISIX.
@tao12345666333
Does this task mean that i should implement the webhook and validation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase removed a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase removed a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781461
> * chore: consumer data structures by tokers 路 Pull Request #470 路 apache/apisix-ingress-controller
ok, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973683759
@shelltea you can check #694 and #689 If @neverCase has time to complete this feature, we can include it in 1.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925507993
> @neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself.
before pr, should i make up the field `validation` in the `ApisixPluginConfig.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924710123
Started a discussion on the mailing list https://lists.apache.org/thread.html/r6e989cb7087feff7ab48157d74cf47aab18c3a1cfd32474b0672e63f%40%3Cdev.apisix.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924849663
> ok, got it
Welcome to submit your plan to the mail list :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924855066
> > ok, got it
>
> Welcome to submit your plan to the mail list :).
OK, i will submit my plan later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-900836800
Add this to v1.3 milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] shelltea commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
shelltea commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973699291
@tao12345666333 Thanks!
@neverCase Hi, Do you have time to complete this feature recently? We really need this feature. 馃榾
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] shelltea commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
shelltea commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973682317
@tao12345666333 Hi, Can this feature be released in version 1.4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975187296
@neverCase You can refer to the following PR to split this work. So that others can also develop collaboratively.
* [chore: consumer data structures by tokers 路 Pull Request #470 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/470)
* [feat: apisixconsumer translator by tokers 路 Pull Request #474 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/474)
* [feat: consumer controller loop by tao12345666333 路 Pull Request #516 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/516)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975203249
> @neverCase I hope you complete the definition of CRD and data type first. eg. #689 or #694
Thanks, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547
> #694 has been merged. 馃憤 You can do this job @neverCase
>
> * [ ] Add client implementation to interact with Apache APISIX.
@tao12345666333
Does this task mean that i should implement the webhook and validation?
e.g. `github.com/apache/apisix-ingress-controller/pkg/api/validation"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005420014
> [ ] Add docs to describe it.
I think it's my job -,-.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924761923
Thanks! @neverCase If you need help, you can ping me at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925440805
> I had replied a mail on the apache mail list, but it seems something wrong.
> After sending, i can't find my reply on the mail list.
> @tao12345666333 @tokers
You have to subscribe the dev@apisix.apache.org before you send any mails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924882844
I had replied a mail on the apache mail list, but it seems something wrong.
After sending, i can't find my reply on the mail list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924888688
my plan
1. add ApisixPluginConfig in types.go and generated libraries (such as clientset)
2. add ApisixRoute as a group in config
3. add looper for watching specific resources by using clientset (like k8s.io/client-go) and convert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005397071
For this feature, there is one last task left.
- [ ] Add docs to describe it.
Who has time to help with this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975193336
> @neverCase You can refer to the following PR to split this work. So that others can also develop collaboratively.
>
> * [chore: consumer data structures by tokers 路 Pull Request #470 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/470)
> * [feat: apisixconsumer translator by tokers 路 Pull Request #474 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/474)
> * [feat: consumer controller loop by tao12345666333 路 Pull Request #516 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/516)
OK 馃憣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins ApisixRouteHTTPPluginConfig // https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/kube/apisix/apis/config/v2beta1/types.go#L129
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925487850
After discussing it with @tokers and @gxthrj . We finally reached an agreement.
We can set the `plugins` field and `pluginconfig` field in `ApisixRoute` to be mutually exclusive.
This means that the user can only configure one of the `plugins` or `pluginconfig` in `ApisixRoute`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-988590163
> @neverCase Thanks for your work, if you have time, you can continue the development of follow-up tasks.
ok, got it.
I will update it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973900404
> @tao12345666333 @shelltea Actually, I have time to fix this, but I need more help. I'm willing to contribute my codes.
Feel free to paste your questions there :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924755949
i'm a volunteer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins Plugins // it should be imported from https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/types/apisix/v1/types.go#L158
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1002621775
Hi folks,
The main part of the ApisixPluginConfig function has been implemented, thanks for your hard work @neverCase , great!
I鈥檓 about to initiate a vote for the release of a new version of v1.4. This feature will appear for the first time in v1.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924882844
I had replied a mail on the apache mail list, but it seems something wrong.
After sending, i can't find my reply on the mail list.
@tao12345666333 @tokers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925514670
You can open a PR and set it as draft status. Related discussions can be held in the PR, which will be more convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924757668
> i'm a volunteer
Great, assign to you. Look forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins []ApisixRouteHTTPPlugin // https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/kube/apisix/apis/config/v2beta1/types.go#L118
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925445772
> Add a CRD like `ApisixPluginConfig` to support a group of plugin configs, and `ApisixRoute` add a field be associated with it.
>
> If we want to implement this function, we can split the following tasks:
>
> * [ ] Add ApisixPluginConfig custom resource. Only need to modify YAML.
> * [ ] Add ApisixPluginConfig data structures.
> * [ ] Add client implementation to interact with Apache APISIX.
> * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX.
> * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure.
> * [ ] Add docs to describe it.
You can split this function into multiple small tasks to carry out, refer to these tasks I added in the description. @neverCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925442254
> my plan
>
> 1. add ApisixPluginConfig in types.go and generated libraries (such as clientset)
> 2. add ApisixRoute as a group in config
> 3. add looper for watching specific resources by using clientset (like k8s.io/client-go) and convert it
1. Refer to other types (see https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/apisix/apis/config/v2beta1/types.go#L30) so that the CRD definition can be generated with the OpenAPIV3Schema.
2. We need to talk about the mutual exclusivity between `pluginConfig` and `plugins` fields. @tao12345666333 @gxthrj @neverCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978006065
> * [ ] Add client implementation to interact with Apache APISIX.
> * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX.
> * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure.
> * [ ] Add docs to describe it.
@shelltea @fengshunli If you are interested, you can also choose one of the tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #638:
URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975167494
@tao12345666333
hi, should I implement the ApisixPluginConfig in the `TranslateContext`
```sh
// TranslateContext contains APISIX resources generated by the translator.
type TranslateContext struct {
Routes []*apisix.Route
StreamRoutes []*apisix.StreamRoute
Upstreams []*apisix.Upstream
upstreamMap map[string]struct{}
SSL []*apisix.Ssl
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org