You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/20 09:42:25 UTC
[GitHub] [pulsar] zplinuxlover opened a new pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
zplinuxlover opened a new pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775
when I run testcase `org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadPolicies`, there is an error,
I debug the code, I found that there is possibility that `offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis()`
is null. so I change the code.
from `offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis()
.equals(OffloadPolicies.DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS)`
to `offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis() == null && OffloadPolicies.DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS == null
|| offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis() != null
&& offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis().equals(OffloadPolicies.DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-619473059
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-620335886
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786155
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-620585230
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-619467005
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786237
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-616612592
@gaoran10 Please also help take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on pull request #6775:
URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786115
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org