[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #284: Add nodeSelector to cluster initialize pod

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284#discussion_r973653797


##########
charts/pulsar/templates/pulsar-cluster-initialize.yaml:
##########
@@ -114,5 +114,9 @@ spec:
       volumes:
       {{- include "pulsar.toolset.certs.volumes" . | nindent 6 }}
       restartPolicy: OnFailure
+      {{- if .Values.pulsar_metadata.nodeSelector }}
+      nodeSelector:
+{{ toYaml .Values.pulsar_metadata.nodeSelector | indent 6 }}

Review Comment:
   I am pretty sure this needs to be indented 8, not 6. Were you able to verify this change works?
   
   ```suggestion
   {{ toYaml .Values.pulsar_metadata.nodeSelector | indent 8 }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org