[GitHub] [airflow] eladkal commented on a change in pull request #20263: rewrite opsgenie alert hook with official python sdk, related issue #18641

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #20263:
URL: https://github.com/apache/airflow/pull/20263#discussion_r772522154



##########
File path: setup.py
##########
@@ -405,6 +405,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
 odbc = [
     'pyodbc',
 ]
+opsgenie_sdk = [

Review comment:
       do we need the `_sdk`?

##########
File path: UPDATING.md
##########
@@ -2089,6 +2089,10 @@ Remove unnecessary parameter ``open`` in PostgresHook function ``copy_expert`` f
 
 Change parameter name from ``visibleTo`` to ``visible_to`` in OpsgenieAlertOperator for pylint compatible
 
+`OpsgenieAlertHook` constructor does not take additional arguments or keyword arguments anymore.
+Changed the return type of `OpsgenieAlertHook.get_conn` to return a `opsgenie_sdk.AlertApi` object instead of a `requests.Session` object.
+Changed the return type of `OpsgenieAlertHook.execute` to return a `opsgenie_sdk.SuccessResponse` object instead of a `Any` type.
+

Review comment:
       This section is Updating of Airflow 2.0 - this is not relevant here.
   Users who switch to 2.0 has no action item as the provider we are now upgrading is not compatible with Airflow 2.
   
   These entries means that this PR is a breaking change (which we welcome!)
   @potiuk since you generate the change log automatically I wonder what is the best way to notify the users?
   Should we ask to move these records to 
   https://github.com/apache/airflow/blob/main/airflow/providers/opsgenie/CHANGELOG.rst
   with 3.0.0 ?
   Alternatively we can maybe put this information in the PR description or/and in the commit message and the change log would refer to it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org