You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/06/06 09:47:43 UTC
[GitHub] [camel] ppalaga opened a new pull request, #10266: Add Java snippets on CXF component page, normalize formating markup, …
ppalaga opened a new pull request, #10266:
URL: https://github.com/apache/camel/pull/10266
…re-indent examples
@ffang @llowinge could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga merged pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #10266:
URL: https://github.com/apache/camel/pull/10266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on a diff in pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #10266:
URL: https://github.com/apache/camel/pull/10266#discussion_r1219366794
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -1067,12 +1177,30 @@ http://cxf.apache.org/docs/jax-ws-configuration.html[JAX-WS
Configuration page].
[NOTE]
-====
+======
You can use cxf:properties to set the camel-cxf endpoint's dataFormat
and setDefaultBus properties from spring configuration file.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+from("direct:a")
Review Comment:
Copy and paste error, sorry! Thanks for catching it @llowinge!
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -749,11 +825,44 @@ is removed in `RAW` mode), you have to configure
`LoggingOutInterceptor` to be run during the `WRITE` phase. The
following is an example.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+import java.util.List;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.common.DataFormat;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.cxf.interceptor.LoggingOutInterceptor;
+import org.apache.cxf.phase.Phase;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Named;
+
+...
+
+@Produces
Review Comment:
I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10266:
URL: https://github.com/apache/camel/pull/10266#issuecomment-1578401722
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10266:
URL: https://github.com/apache/camel/pull/10266#issuecomment-1578519111
0d0f9456e7b9facff69e840b99e49eca9671f0a2 that I just force-pushed does not show up for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10266:
URL: https://github.com/apache/camel/pull/10266#issuecomment-1578313029
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on a diff in pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #10266:
URL: https://github.com/apache/camel/pull/10266#discussion_r1219447265
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -749,11 +825,44 @@ is removed in `RAW` mode), you have to configure
`LoggingOutInterceptor` to be run during the `WRITE` phase. The
following is an example.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+import java.util.List;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.common.DataFormat;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.cxf.interceptor.LoggingOutInterceptor;
+import org.apache.cxf.phase.Phase;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Named;
+
+...
+
+@Produces
Review Comment:
I labeled the snippets with Quarkus/Spring in 0d0f9456e7b9facff69e840b99e49eca9671f0a2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10266:
URL: https://github.com/apache/camel/pull/10266#issuecomment-1578635382
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] llowinge commented on a diff in pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on code in PR #10266:
URL: https://github.com/apache/camel/pull/10266#discussion_r1219356421
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -749,11 +825,44 @@ is removed in `RAW` mode), you have to configure
`LoggingOutInterceptor` to be run during the `WRITE` phase. The
following is an example.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+import java.util.List;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.common.DataFormat;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.cxf.interceptor.LoggingOutInterceptor;
+import org.apache.cxf.phase.Phase;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Named;
+
+...
+
+@Produces
Review Comment:
@ppalaga Are those annotations Quarkus specific ? Or it is also for Spring Boot ?
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -1067,12 +1177,30 @@ http://cxf.apache.org/docs/jax-ws-configuration.html[JAX-WS
Configuration page].
[NOTE]
-====
+======
You can use cxf:properties to set the camel-cxf endpoint's dataFormat
and setDefaultBus properties from spring configuration file.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+from("direct:a")
Review Comment:
@ppalaga What is this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] llowinge commented on a diff in pull request #10266: Add Java snippets on CXF component page, normalize formating markup, …
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on code in PR #10266:
URL: https://github.com/apache/camel/pull/10266#discussion_r1219438824
##########
components/camel-cxf/camel-cxf-soap/src/main/docs/cxf-component.adoc:
##########
@@ -749,11 +825,44 @@ is removed in `RAW` mode), you have to configure
`LoggingOutInterceptor` to be run during the `WRITE` phase. The
following is an example.
+[tabs]
+====
+Java::
++
+[source,java]
+----
+import java.util.List;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.common.DataFormat;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.cxf.interceptor.LoggingOutInterceptor;
+import org.apache.cxf.phase.Phase;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Named;
+
+...
+
+@Produces
Review Comment:
Not sure if we want to introduce Quarkus specific code into plain Camel. The same story as with Spring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org