You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2014/09/09 08:41:23 UTC
Build fails - serialization
DynamicalThresholdFilter does not implement equals(), so the AbstractSerializationTest.testSerializationRoundtrip fails.
Sent from my iPhone
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: Build fails - serialization
Posted by Remko Popma <re...@gmail.com>.
Ah! I overlooked an email, now I see it. Please ignore my previous message.
On Wednesday, September 10, 2014, Remko Popma <re...@gmail.com> wrote:
> No problem!
> I looked at the commit emails, but I couldn't see if an equals() method
> was added to DynamicThresholdFilter. Without that method, the default
> Object.equals will fail the assert because the serialized-deserialized
> filter is a different instance from the original filter. Does the test
> work? (I may have missed something...)
>
> Sent from my iPhone
>
> On 2014/09/09, at 22:06, Gary Gregory <garydgregory@gmail.com
> <javascript:_e(%7B%7D,'cvml','garydgregory@gmail.com');>> wrote:
>
> My bad, sorry :-( Fixed in git master.
>
> Gary
>
> On Tue, Sep 9, 2014 at 2:41 AM, Remko Popma <remko.popma@gmail.com
> <javascript:_e(%7B%7D,'cvml','remko.popma@gmail.com');>> wrote:
>
>> DynamicalThresholdFilter does not implement equals(), so the
>> AbstractSerializationTest.testSerializationRoundtrip fails.
>>
>> Sent from my iPhone
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> <javascript:_e(%7B%7D,'cvml','log4j-dev-unsubscribe@logging.apache.org');>
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>> <javascript:_e(%7B%7D,'cvml','log4j-dev-help@logging.apache.org');>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com
> <javascript:_e(%7B%7D,'cvml','garydgregory@gmail.com');> | ggregory@apache.org
> <javascript:_e(%7B%7D,'cvml','ggregory@apache.org');>
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
Re: Build fails - serialization
Posted by Remko Popma <re...@gmail.com>.
No problem!
I looked at the commit emails, but I couldn't see if an equals() method was added to DynamicThresholdFilter. Without that method, the default Object.equals will fail the assert because the serialized-deserialized filter is a different instance from the original filter. Does the test work? (I may have missed something...)
Sent from my iPhone
> On 2014/09/09, at 22:06, Gary Gregory <ga...@gmail.com> wrote:
>
> My bad, sorry :-( Fixed in git master.
>
> Gary
>
>> On Tue, Sep 9, 2014 at 2:41 AM, Remko Popma <re...@gmail.com> wrote:
>> DynamicalThresholdFilter does not implement equals(), so the AbstractSerializationTest.testSerializationRoundtrip fails.
>>
>> Sent from my iPhone
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Build fails - serialization
Posted by Gary Gregory <ga...@gmail.com>.
My bad, sorry :-( Fixed in git master.
Gary
On Tue, Sep 9, 2014 at 2:41 AM, Remko Popma <re...@gmail.com> wrote:
> DynamicalThresholdFilter does not implement equals(), so the
> AbstractSerializationTest.testSerializationRoundtrip fails.
>
> Sent from my iPhone
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory