You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Lance Norskog (JIRA)" <ji...@apache.org> on 2011/09/18 04:25:09 UTC

[jira] [Created] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
-----------------------------------------------------------------------------------------

                 Key: MAHOUT-812
                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
             Project: Mahout
          Issue Type: Improvement
            Reporter: Lance Norskog
            Priority: Minor
             Fix For: 0.6


ConfusionMatrix does not support Writable. This patch adds that feature.

Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.

Includes unit test for ConfusionMatrix (previously missing) and enhanced unit test for MatrixWritable.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Updated] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by Lance Norskog <go...@gmail.com>.
Oops, the hashcode is a trick. It lets me hang a breakpoint there, and is
clearly not real code so I can remove it later. Thought I hit all of the
formatting. Yes, round() does handle this problem nicely (duh).

Sure, this looks fine. As long as the unit tests run- I think they're
complete for positive code paths.

On Sun, Oct 2, 2011 at 12:40 AM, Sean Owen (Updated) (JIRA) <jira@apache.org
> wrote:

>
>     [
> https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Sean Owen updated MAHOUT-812:
> -----------------------------
>
>    Attachment: MAHOUT-812.patch
>
> OK, this is looking reasonable.
>
> Some of the formatting needs to be cleaned up -- some lines are not
> indented or indented with tabs, etc. What's up with calling hashCode() on an
> array and not using the result?
>
> MatrixWritable looks good, along with the rest of the test code.
>
> In ConfusionMatrix: why add 0.0001 to all elements? Is it so that the
> doubles are converted back to ints properly on the other side? I'd do a
> round then.
>
> Attached is my take on the patch.
>
> > Allow ConfusionMatrix to be Writable (via MatrixWritable)
> > ---------------------------------------------------------
> >
> >                 Key: MAHOUT-812
> >                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
> >             Project: Mahout
> >          Issue Type: Improvement
> >            Reporter: Lance Norskog
> >            Priority: Minor
> >             Fix For: 0.6
> >
> >         Attachments: MAHOUT-812.patch, MAHOUT-812.patch, MAHOUT-812.patch
> >
> >
> > ConfusionMatrix does not support Writable. This patch adds that feature.
> ConfusionMatrix is a subclass of MatrixWritable.
> > Since ConfusionMatrix is somewhat less than useful without the row/column
> labels, and MatrixWritable does not support writing bindings (it only saves
> numbers), this patch fixes both.
> > Includes unit test for ConfusionMatrix (previously missing) which
> includes exercise of MatrixWritable support for numbers and labels. (There
> is no independent unit test for MatrixWritable.)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


-- 
Lance Norskog
goksron@gmail.com

[jira] [Commented] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Sean Owen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115452#comment-13115452 ] 

Sean Owen commented on MAHOUT-812:
----------------------------------

In general, Matrix implementations are not Writable. MatrixWritable, however, is a container for a Matrix which is Writable. The idea is that MatrixWritable handle the serialization. This has a few nice properties, primarily that Matrix/Vector are not quite so coupled to Hadoop. Can MatrixWritable therefore be enhanced to write labels? That would be of general use beyond ConfusionMatrix.


                
> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by "Sean Owen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-812:
-----------------------------

    Attachment: MAHOUT-812.patch

OK, this is looking reasonable.

Some of the formatting needs to be cleaned up -- some lines are not indented or indented with tabs, etc. What's up with calling hashCode() on an array and not using the result?

MatrixWritable looks good, along with the rest of the test code.

In ConfusionMatrix: why add 0.0001 to all elements? Is it so that the doubles are converted back to ints properly on the other side? I'd do a round then.

Attached is my take on the patch.
                
> Allow ConfusionMatrix to be Writable (via MatrixWritable)
> ---------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119229#comment-13119229 ] 

Hudson commented on MAHOUT-812:
-------------------------------

Integrated in Mahout-Quality #1079 (See [https://builds.apache.org/job/Mahout-Quality/1079/])
    MAHOUT-812 help make confusion matrix writable

srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178324
Files : 
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/ConfusionMatrix.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/math/MatrixWritable.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/classifier/ConfusionMatrixTest.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/math/MatrixWritableTest.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java

                
> Allow ConfusionMatrix to be Writable (via MatrixWritable)
> ---------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-812:
---------------------------------

    Status: Patch Available  (was: Open)

> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Lance Norskog (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116204#comment-13116204 ] 

Lance Norskog commented on MAHOUT-812:
--------------------------------------

Yeah, it did not seem right to me either. What about: ConfusionMatrix has a delegate Matrix (Dense) and is disjoint from Writable-ness. You pull the delegate and Writable that.

Would an R-style dataframe work better than these Matrix & Vector formats? One common format for Vectors, Matrices, and possibly tensors?
                
> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-812:
---------------------------------

    Description: 
ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.

Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.

Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

  was:
ConfusionMatrix does not support Writable. This patch adds that feature.

Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.

Includes unit test for ConfusionMatrix (previously missing) and enhanced unit test for MatrixWritable.


> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by "Lance Norskog (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-812:
---------------------------------

    Summary: Allow ConfusionMatrix to be Writable (via MatrixWritable)  (was: Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels))
    
> Allow ConfusionMatrix to be Writable (via MatrixWritable)
> ---------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Lance Norskog (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-812:
---------------------------------

    Attachment: MAHOUT-812.patch

Rewritten as per comments. ConfusionMatrix is not Writable. MatrixWritable now handles labels.

Added unit test for Names with NamedVectors.
                
> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by "Sean Owen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-812:
-----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Allow ConfusionMatrix to be Writable (via MatrixWritable)
> ---------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Sean Owen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116211#comment-13116211 ] 

Sean Owen commented on MAHOUT-812:
----------------------------------

Yeah something like that -- though look at how MatrixWritable handles stuff now. You may not have to go to the trouble of making a delegate. It ought to interrogate the object as normal through its methods.
                
> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MAHOUT-812) Allow ConfusionMatrix to be Writable (via MatrixWritable)

Posted by "Sean Owen (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen reassigned MAHOUT-812:
--------------------------------

    Assignee: Sean Owen
    
> Allow ConfusionMatrix to be Writable (via MatrixWritable)
> ---------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch, MAHOUT-812.patch, MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-812:
---------------------------------

    Attachment: MAHOUT-812.patch

> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-812) Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)

Posted by "Ted Dunning (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115465#comment-13115465 ] 

Ted Dunning commented on MAHOUT-812:
------------------------------------

Sounds right to handle the labels.

                
> Enhance ConfusionMatrix to be a MatrixWritable (enhances MatrixWritable to pickle labels)
> -----------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-812
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-812
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: MAHOUT-812.patch
>
>
> ConfusionMatrix does not support Writable. This patch adds that feature. ConfusionMatrix is a subclass of MatrixWritable.
> Since ConfusionMatrix is somewhat less than useful without the row/column labels, and MatrixWritable does not support writing bindings (it only saves numbers), this patch fixes both.
> Includes unit test for ConfusionMatrix (previously missing) which includes exercise of MatrixWritable support for numbers and labels. (There is no independent unit test for MatrixWritable.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira