You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2021/08/12 23:58:28 UTC
[groovy] branch GROOVY_3_0_X updated: GROOVY-10189: File.withWriter
and Path.withWriter are inconsistent
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/GROOVY_3_0_X by this push:
new c2dc7b7 GROOVY-10189: File.withWriter and Path.withWriter are inconsistent
c2dc7b7 is described below
commit c2dc7b7329391dddab3ae99df0ec4e489c11e9f8
Author: Paul King <pa...@asert.com.au>
AuthorDate: Thu Aug 12 15:39:35 2021 +1000
GROOVY-10189: File.withWriter and Path.withWriter are inconsistent
(cherry picked from commit e322cbfa0fdb4e16032f00af77143cd9afafe368)
---
.../java/org/apache/groovy/nio/extensions/NioExtensions.java | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java b/subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java
index 733e540..51f8af7 100644
--- a/subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java
+++ b/subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java
@@ -1636,7 +1636,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.3.0
*/
- public static <T> T withWriter(Path self, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriter(Path self, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return withWriter(self, Charset.defaultCharset().name(), closure);
}
@@ -1652,7 +1652,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.3.0
*/
- public static <T> T withWriter(Path self, String charset, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriter(Path self, String charset, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return withWriter(self, charset, false, closure);
}
@@ -1672,7 +1672,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.5.0
*/
- public static <T> T withWriter(Path self, String charset, boolean writeBom, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriter(Path self, String charset, boolean writeBom, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return IOGroovyMethods.withWriter(newWriter(self, charset, false, writeBom), closure);
}
@@ -1689,7 +1689,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.3.0
*/
- public static <T> T withWriterAppend(Path self, String charset, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriterAppend(Path self, String charset, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return withWriterAppend(self, charset, false, closure);
}
@@ -1709,7 +1709,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.5.0
*/
- public static <T> T withWriterAppend(Path self, String charset, boolean writeBom, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriterAppend(Path self, String charset, boolean writeBom, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return IOGroovyMethods.withWriter(newWriter(self, charset, true, writeBom), closure);
}
@@ -1724,7 +1724,7 @@ public class NioExtensions extends DefaultGroovyMethodsSupport {
* @throws java.io.IOException if an IOException occurs.
* @since 2.3.0
*/
- public static <T> T withWriterAppend(Path self, @ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> closure) throws IOException {
+ public static <T> T withWriterAppend(Path self, @ClosureParams(value = SimpleType.class, options = "java.io.BufferedWriter") Closure<T> closure) throws IOException {
return withWriterAppend(self, Charset.defaultCharset().name(), closure);
}