[GitHub] [iceberg] rymurr commented on a change in pull request #1843: Support for file paths in SparkCatalogs via HadoopTables

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #1843:
URL: https://github.com/apache/iceberg/pull/1843#discussion_r534171540



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -165,6 +179,7 @@ public StagedTable stageCreate(Identifier ident, StructType schema, Transform[]
                                  Map<String, String> properties) throws TableAlreadyExistsException {
     Schema icebergSchema = SparkSchemaUtil.convert(schema);
     try {
+      // can't stage a hadoop table

Review comment:
       > I'd prefer to create a builder that can construct the transactions for path tables. We could add it to HadoopTables.
   
   Agreed. Added in most recent update




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org