[GitHub] [ozone] sadanand48 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.

[GitBox <gi...@apache.org>]

sadanand48 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891940950


##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
         },
         controller: function ($http) {
             var ctrl = this;
+
+            $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+                .then(function (result){
+                    ctrl.role = result.data.beans[0]

Review Comment:
   Do we need this in here? As far as I understand we are only using `ctrl.overview` only in the html file



##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -113,5 +113,12 @@
         require: {
             overview: "^overview"
         },
+        controller: function ($http) {
+            var ctrl = this;
+            $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")

Review Comment:
   Do we need to specify the localhost here ? I mean the fully qualified path?



##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -74,6 +74,20 @@ <h2>Status</h2>
     </tbody>
 </table>
 
+<h2>Meta-Data Volume Information</h2>
+<table class="table table-bordered table-striped" class="col-md-6">
+    <tbody>
+    <tr>
+        <td>Ratis Directory</td>
+        <td>{{$ctrl.overview.jmx.ScmRatisLogDirectory}}</td>

Review Comment:
   Now that the method name is getRatisLogDirectory , I think you need to change it here as well , same for rocksdb dir



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org