You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/05/15 23:32:45 UTC
[kudu-CR] docs: update the steps to update directories
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15928
Change subject: docs: update the steps to update directories
......................................................................
docs: update the steps to update directories
The `kudu fs update_dirs` tool is no longer required to update the set
of data directories.
Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
---
M docs/administration.adoc
1 file changed, 39 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15928/1
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: update the steps to update directories
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1183
PS1, Line 1183: If on a Kudu version that mandates the usage of `kudu fs update_dirs`, once a
I know you just mentioned the version above, but it could be worth being explicit here.
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 03:37:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update the steps to update directories
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15928
to look at the new patch set (#2).
Change subject: docs: update the steps to update directories
......................................................................
docs: update the steps to update directories
The `kudu fs update_dirs` tool is no longer required to update the set
of data directories.
Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
---
M docs/administration.adoc
1 file changed, 40 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15928/2
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: update the steps to update directories
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
docs: update the steps to update directories
The `kudu fs update_dirs` tool is no longer required to update the set
of data directories.
Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Reviewed-on: http://gerrit.cloudera.org:8080/15928
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/administration.adoc
1 file changed, 40 insertions(+), 25 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: update the steps to update directories
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1184
PS1, Line 1184: ectory configuratio
> If you look at the rendered version, it is a list of steps. Even the point
Ah, I see. Thanks.
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1208
PS1, Line 1208:
: . Run the tool with the desired direc
> I'll remove this, since the maintenance window will need to extend for howe
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 May 2020 14:27:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update the steps to update directories
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 May 2020 15:56:23 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update the steps to update directories
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1176
PS1, Line 1176: Be sure to use
nit: too many 'sure' :) Maybe, simply
Use `ksck` to ensure ...
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1184
PS1, Line 1184: the following steps
Not sure I see the advertised steps below. I see below goes the list of NOTES, and then comes one bullet point about the requirement to keep tablet server shutdown when running the tool.
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1208
PS1, Line 1208: The tool itself runs quickly, so this offline
: window should be brief, and as such
Not a part of this exact patch, but I'm not sure how much useful information this provides to the users. For example, how long 'brief' is in this case (seconds, minutes, hours)? Does it depend on the amount of data under the data directories? Maybe, drop this piece of mention what tools does to provide the idea how brief the maintenance window could be.
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224: values
value ?
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224: sever
server ?
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224: flags
nit: flag ?
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 18:14:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update the steps to update directories
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 1:
A staged version can be found here: https://github.com/andrwng/kudu/blob/docs-1.12/docs/administration.adoc#change_dir_config
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 23:37:56 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update the steps to update directories
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories
......................................................................
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1176
PS1, Line 1176: Use `ksck` to
> nit: too many 'sure' :) Maybe, simply
Done
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1183
PS1, Line 1183: If on a Kudu version below 1.12, once a server is started, users must go
> I know you just mentioned the version above, but it could be worth being ex
Done
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1184
PS1, Line 1184: ectory configuratio
> Not sure I see the advertised steps below. I see below goes the list of NO
If you look at the rendered version, it is a list of steps. Even the point about the shut down the tablet server is a step to "establish a maintenance window".
I'll restructure the sentence so it's more clearly a step.
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1208
PS1, Line 1208:
: . Run the tool with the desired direc
> Not a part of this exact patch, but I'm not sure how much useful informatio
I'll remove this, since the maintenance window will need to extend for however long startup takes.
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224:
> nit: flag ?
Done
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224:
> server ?
Done
http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224
PS1, Line 1224:
> value ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 23:08:06 +0000
Gerrit-HasComments: Yes