You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@velocity.apache.org by mailmur <ma...@yahoo.com> on 2005/06/27 21:50:39 UTC
Loaders and Hashtable+Vector legacy use?
File:
org\apache\velocity\runtime\resource\loader\FileResourceLoader.java
This class uses Vector and Hashtable instances to
store cached paths values. Should this and other
classes be converted to use ArrayList and HashMap
instances?
I think ArrayList+Hashmap give better runtime performance.
__________________________________
Yahoo! Mail
Stay connected, organized, and protected. Take the tour:
http://tour.mail.yahoo.com/mailtour.html
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by Will Glass-Husain <wg...@forio.com>.
ok, thanks. Seems reasonable. (suggestion for next time: stick it in a
separate patch and bugzilla issue).
anyone else have an opinion on MANIFEST.MF?
WILL
----- Original Message -----
From: "mailmur" <ma...@yahoo.com>
To: "Velocity Users List" <ve...@jakarta.apache.org>
Sent: Tuesday, July 05, 2005 7:28 AM
Subject: Re: Loaders and Hashtable+Vector legacy use?
> build.xml changes:
> manifest.mf file: It is like windows
> secondaryClick/Version tabsheet information where we
> can see version info etc.
>
> See my webpage zipfile, where you should find
> src/META-INF/MANIFEST.MF file. I believe diff did not
> include it (just realized).
>
> So to summarize:
> * meaninfull src/META-INF/MANIFEST.MF file added (take
> from zip)
> * updated build.xml to include manifest file when
> jarring a project
>
> Go ahead and test it in your working copy. Then open
> Velocity-xxx.jar file to Winzip or something and see
> manifest.mf file. I really hope Velocity started to
> use a meaninfull manifest.mf file.
>
>
> --- Will Glass-Husain <wg...@forio.com> wrote:
>> At first glance this looks good. I'll commit this
>> in the next day or two.
>>
>> What are the changes to the build file? Did you
>> mean to include those? (no
>> need to reattach the diff, I'll just ignore them).
>>
>> WILL
>
>
>
>
> ____________________________________________________
> Yahoo! Sports
> Rekindle the Rivalries. Sign up for Fantasy Football
> http://football.fantasysports.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by mailmur <ma...@yahoo.com>.
build.xml changes:
manifest.mf file: It is like windows
secondaryClick/Version tabsheet information where we
can see version info etc.
See my webpage zipfile, where you should find
src/META-INF/MANIFEST.MF file. I believe diff did not
include it (just realized).
So to summarize:
* meaninfull src/META-INF/MANIFEST.MF file added (take
from zip)
* updated build.xml to include manifest file when
jarring a project
Go ahead and test it in your working copy. Then open
Velocity-xxx.jar file to Winzip or something and see
manifest.mf file. I really hope Velocity started to
use a meaninfull manifest.mf file.
--- Will Glass-Husain <wg...@forio.com> wrote:
> At first glance this looks good. I'll commit this
> in the next day or two.
>
> What are the changes to the build file? Did you
> mean to include those? (no
> need to reattach the diff, I'll just ignore them).
>
> WILL
____________________________________________________
Yahoo! Sports
Rekindle the Rivalries. Sign up for Fantasy Football
http://football.fantasysports.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by Will Glass-Husain <wg...@forio.com>.
At first glance this looks good. I'll commit this in the next day or two.
What are the changes to the build file? Did you mean to include those? (no
need to reattach the diff, I'll just ignore them).
WILL
----- Original Message -----
From: "mailmur" <ma...@yahoo.com>
To: "Velocity Users List" <ve...@jakarta.apache.org>
Sent: Monday, July 04, 2005 11:05 PM
Subject: Re: Loaders and Hashtable+Vector legacy use?
> Well, that was easy after all. I went to the root of
> velocity SVN dump folder and run "svn diff >
> patch.txt". I used svn-win32-1.2.0 client package.
>
> About commit:
> I believe I don't have a commit access so no need to
> worry about modified files in my working copy folder.
> If you guys accept this patch I probably get changes
> later in a update command.
>
> --- Will Glass-Husain <wg...@forio.com> wrote:
>
>> Hi Mailmur,
>>
>> Thanks again for doing this. Do you have the
>> command line "svn" client
>> installed? You should be able to cd to the root
>> Velocity directory, then
>> type at the command line
>>
>> svn diff > patch.txt
>>
>> to run a diff and save it in the file "patch.txt".
>> It does a comparison
>> between all files (recursive) in that directory and
>> the copy in source
>> control. This assumes you've downloaded the source
>> with svn in the first
>> place.
>>
>> (Other diff programs will require two copies. But
>> the svn with the diff
>> action only requires the modified copy on your
>> computer).
>>
>> WILL
>>
>> ----- Original Message -----
>> From: "mailmur" <ma...@yahoo.com>
>> To: "Velocity Users List"
>> <ve...@jakarta.apache.org>
>> Sent: Monday, July 04, 2005 10:02 PM
>> Subject: Re: Loaders and Hashtable+Vector legacy
>> use?
>>
>>
>> > The following changes where made
>> > ================================
>> > * added src/java/META-INF/MANIFEST.MF file
>> > _all_ java packages should have a _meaninfull_
>> > manifest file. This is a sort of win exefile's
>> > VersionInfo tabsheet and is really a good quality
>> of
>> > service.
>> >
>> > * modified build/build.xml file
>> > create jars with given manifest.mf file
>> > - added src/java/meta-inf to prepare copyfile set
>> > - added compile-copy-metainf target and use it in
>> > various jarXXX targets
>> >
>> > * modified resourceloaders
>> >
>> runtime/resource/loader/ClasspathResourceLoader.java
>> > runtime/resource/loader/FileResourceLoader.java
>> > runtime/resource/loader/JarResourceLoader.java
>> > - removed unnecessary synchronized blocks to slow
>> > things down
>> > - converted legacy Vector and hashtable classes to
>> > ArrayList and HashMap, this is another performance
>> > optimization. No need to use legacy classes
>> anymore.
>> > They are _implicitly_ synchronized so slow this
>> down
>> > if we don't need any synchronization.
>> >
>> > Note: many part of internal velocity engine still
>> use
>> > legacy classes, but we have to live with it at the
>> > moment.
>> >
>> > - - -
>> > I could not make a diff files, probably am missing
>> a
>> > diff tool or am just a n000b. I tried to google
>> but
>> > could not find anything I should install.
>> >
>> > Environment: Win2k,EclipseIDE,RapidSVN client
>> >
>> > Until then, I have posted a link to my webpage and
>> a
>> > zipfile where is all files modified.
>> >
>>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=35558
>> >
>> > svn diff > patch.txt is not clearly a full
>> command.
>> > RapidSVN menu has a diff option, I tried
>> preferences
>> > to point it to "svn.exe diff" tool but did not
>> work.
>> > Then I have VisDiff.exe in WinCVS client, but it
>> just
>> > displayed a graphical comparision.
>> >
>> > Oh why always its so complicated to make even
>> simple
>> > point-and-click tasks :-(
>> >
>> > thx
>> > --- Will Glass-Husain <wg...@forio.com> wrote:
>> >> Sounds good so far. I use the "svn" command line
>> >> client, the "TortoiseSVN" client for use in
>> Windows,
>> > and the Subclipse integrated with Eclipse.
>> >
>> >> (4) Make a diff file in "unified" format with
>> this
>> >> command: svn diff > patch.txt
>> >
>> > __________________________________________________
>> > Do You Yahoo!?
>> > Tired of spam? Yahoo! Mail has the best spam
>> protection around
>> > http://mail.yahoo.com
>> >
>> >
>>
> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail:
>> velocity-user-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail:
>> velocity-user-help@jakarta.apache.org
>> >
>>
>>
>>
> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> velocity-user-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail:
>> velocity-user-help@jakarta.apache.org
>>
>>
>
>
>
>
> ____________________________________________________
> Yahoo! Sports
> Rekindle the Rivalries. Sign up for Fantasy Football
> http://football.fantasysports.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by mailmur <ma...@yahoo.com>.
Well, that was easy after all. I went to the root of
velocity SVN dump folder and run "svn diff >
patch.txt". I used svn-win32-1.2.0 client package.
About commit:
I believe I don't have a commit access so no need to
worry about modified files in my working copy folder.
If you guys accept this patch I probably get changes
later in a update command.
--- Will Glass-Husain <wg...@forio.com> wrote:
> Hi Mailmur,
>
> Thanks again for doing this. Do you have the
> command line "svn" client
> installed? You should be able to cd to the root
> Velocity directory, then
> type at the command line
>
> svn diff > patch.txt
>
> to run a diff and save it in the file "patch.txt".
> It does a comparison
> between all files (recursive) in that directory and
> the copy in source
> control. This assumes you've downloaded the source
> with svn in the first
> place.
>
> (Other diff programs will require two copies. But
> the svn with the diff
> action only requires the modified copy on your
> computer).
>
> WILL
>
> ----- Original Message -----
> From: "mailmur" <ma...@yahoo.com>
> To: "Velocity Users List"
> <ve...@jakarta.apache.org>
> Sent: Monday, July 04, 2005 10:02 PM
> Subject: Re: Loaders and Hashtable+Vector legacy
> use?
>
>
> > The following changes where made
> > ================================
> > * added src/java/META-INF/MANIFEST.MF file
> > _all_ java packages should have a _meaninfull_
> > manifest file. This is a sort of win exefile's
> > VersionInfo tabsheet and is really a good quality
> of
> > service.
> >
> > * modified build/build.xml file
> > create jars with given manifest.mf file
> > - added src/java/meta-inf to prepare copyfile set
> > - added compile-copy-metainf target and use it in
> > various jarXXX targets
> >
> > * modified resourceloaders
> >
> runtime/resource/loader/ClasspathResourceLoader.java
> > runtime/resource/loader/FileResourceLoader.java
> > runtime/resource/loader/JarResourceLoader.java
> > - removed unnecessary synchronized blocks to slow
> > things down
> > - converted legacy Vector and hashtable classes to
> > ArrayList and HashMap, this is another performance
> > optimization. No need to use legacy classes
> anymore.
> > They are _implicitly_ synchronized so slow this
> down
> > if we don't need any synchronization.
> >
> > Note: many part of internal velocity engine still
> use
> > legacy classes, but we have to live with it at the
> > moment.
> >
> > - - -
> > I could not make a diff files, probably am missing
> a
> > diff tool or am just a n000b. I tried to google
> but
> > could not find anything I should install.
> >
> > Environment: Win2k,EclipseIDE,RapidSVN client
> >
> > Until then, I have posted a link to my webpage and
> a
> > zipfile where is all files modified.
> >
>
http://issues.apache.org/bugzilla/show_bug.cgi?id=35558
> >
> > svn diff > patch.txt is not clearly a full
> command.
> > RapidSVN menu has a diff option, I tried
> preferences
> > to point it to "svn.exe diff" tool but did not
> work.
> > Then I have VisDiff.exe in WinCVS client, but it
> just
> > displayed a graphical comparision.
> >
> > Oh why always its so complicated to make even
> simple
> > point-and-click tasks :-(
> >
> > thx
> > --- Will Glass-Husain <wg...@forio.com> wrote:
> >> Sounds good so far. I use the "svn" command line
> >> client, the "TortoiseSVN" client for use in
> Windows,
> > and the Subclipse integrated with Eclipse.
> >
> >> (4) Make a diff file in "unified" format with
> this
> >> command: svn diff > patch.txt
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Tired of spam? Yahoo! Mail has the best spam
> protection around
> > http://mail.yahoo.com
> >
> >
>
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> velocity-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail:
> velocity-user-help@jakarta.apache.org
> >
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> velocity-user-help@jakarta.apache.org
>
>
____________________________________________________
Yahoo! Sports
Rekindle the Rivalries. Sign up for Fantasy Football
http://football.fantasysports.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by Will Glass-Husain <wg...@forio.com>.
Hi Mailmur,
Thanks again for doing this. Do you have the command line "svn" client
installed? You should be able to cd to the root Velocity directory, then
type at the command line
svn diff > patch.txt
to run a diff and save it in the file "patch.txt". It does a comparison
between all files (recursive) in that directory and the copy in source
control. This assumes you've downloaded the source with svn in the first
place.
(Other diff programs will require two copies. But the svn with the diff
action only requires the modified copy on your computer).
WILL
----- Original Message -----
From: "mailmur" <ma...@yahoo.com>
To: "Velocity Users List" <ve...@jakarta.apache.org>
Sent: Monday, July 04, 2005 10:02 PM
Subject: Re: Loaders and Hashtable+Vector legacy use?
> The following changes where made
> ================================
> * added src/java/META-INF/MANIFEST.MF file
> _all_ java packages should have a _meaninfull_
> manifest file. This is a sort of win exefile's
> VersionInfo tabsheet and is really a good quality of
> service.
>
> * modified build/build.xml file
> create jars with given manifest.mf file
> - added src/java/meta-inf to prepare copyfile set
> - added compile-copy-metainf target and use it in
> various jarXXX targets
>
> * modified resourceloaders
> runtime/resource/loader/ClasspathResourceLoader.java
> runtime/resource/loader/FileResourceLoader.java
> runtime/resource/loader/JarResourceLoader.java
> - removed unnecessary synchronized blocks to slow
> things down
> - converted legacy Vector and hashtable classes to
> ArrayList and HashMap, this is another performance
> optimization. No need to use legacy classes anymore.
> They are _implicitly_ synchronized so slow this down
> if we don't need any synchronization.
>
> Note: many part of internal velocity engine still use
> legacy classes, but we have to live with it at the
> moment.
>
> - - -
> I could not make a diff files, probably am missing a
> diff tool or am just a n000b. I tried to google but
> could not find anything I should install.
>
> Environment: Win2k,EclipseIDE,RapidSVN client
>
> Until then, I have posted a link to my webpage and a
> zipfile where is all files modified.
> http://issues.apache.org/bugzilla/show_bug.cgi?id=35558
>
> svn diff > patch.txt is not clearly a full command.
> RapidSVN menu has a diff option, I tried preferences
> to point it to "svn.exe diff" tool but did not work.
> Then I have VisDiff.exe in WinCVS client, but it just
> displayed a graphical comparision.
>
> Oh why always its so complicated to make even simple
> point-and-click tasks :-(
>
> thx
> --- Will Glass-Husain <wg...@forio.com> wrote:
>> Sounds good so far. I use the "svn" command line
>> client, the "TortoiseSVN" client for use in Windows,
> and the Subclipse integrated with Eclipse.
>
>> (4) Make a diff file in "unified" format with this
>> command: svn diff > patch.txt
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam? Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by mailmur <ma...@yahoo.com>.
The following changes where made
================================
* added src/java/META-INF/MANIFEST.MF file
_all_ java packages should have a _meaninfull_
manifest file. This is a sort of win exefile's
VersionInfo tabsheet and is really a good quality of
service.
* modified build/build.xml file
create jars with given manifest.mf file
- added src/java/meta-inf to prepare copyfile set
- added compile-copy-metainf target and use it in
various jarXXX targets
* modified resourceloaders
runtime/resource/loader/ClasspathResourceLoader.java
runtime/resource/loader/FileResourceLoader.java
runtime/resource/loader/JarResourceLoader.java
- removed unnecessary synchronized blocks to slow
things down
- converted legacy Vector and hashtable classes to
ArrayList and HashMap, this is another performance
optimization. No need to use legacy classes anymore.
They are _implicitly_ synchronized so slow this down
if we don't need any synchronization.
Note: many part of internal velocity engine still use
legacy classes, but we have to live with it at the
moment.
- - -
I could not make a diff files, probably am missing a
diff tool or am just a n000b. I tried to google but
could not find anything I should install.
Environment: Win2k,EclipseIDE,RapidSVN client
Until then, I have posted a link to my webpage and a
zipfile where is all files modified.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35558
svn diff > patch.txt is not clearly a full command.
RapidSVN menu has a diff option, I tried preferences
to point it to "svn.exe diff" tool but did not work.
Then I have VisDiff.exe in WinCVS client, but it just
displayed a graphical comparision.
Oh why always its so complicated to make even simple
point-and-click tasks :-(
thx
--- Will Glass-Husain <wg...@forio.com> wrote:
> Sounds good so far. I use the "svn" command line
> client, the "TortoiseSVN" client for use in Windows,
and the Subclipse integrated with Eclipse.
> (4) Make a diff file in "unified" format with this
> command: svn diff > patch.txt
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by Will Glass-Husain <wg...@forio.com>.
Sounds good so far. I use the "svn" command line client, the "TortoiseSVN"
client for use in Windows, and the Subclipse integrated with Eclipse.
Here's what you need to do. It's really not too hard.
(1) download latest source code (sounds like you've done this)
(2) change the code and compile it with "ant jar"
(3) check that all tests pass with "ant test". If you're adding new
functionality (not true here) you'll want to make new tests.
(4) ake a diff file in "unified" format with this command:
svn diff > patch.txt
(6) Attach it to the bugzilla report.
Let me know if you've any other questions. Also, you might take a quick
glance at the code standards.
http://wiki.apache.org/jakarta-velocity/CodeStandards
Thanks for doing this!
Best,
WILL
----- Original Message -----
From: "mailmur" <ma...@yahoo.com>
To: "Velocity Users List" <ve...@jakarta.apache.org>
Sent: Wednesday, June 29, 2005 11:04 PM
Subject: Re: Loaders and Hashtable+Vector legacy use?
> Posted a bug report: #35558
> I can see this to be fixed. First I must install
> subversion client, take a dump from repository and
> finally study what "creating a patch" means. I've
> never used sv or created any patch files.
>
> ..ok..first step done:
> * installed RapidSVN client, took some time to browse
> subversion site and understand all bits. They have
> just too many clients to choose from. Or atleast most
> of them are not worth to try...as I discovered too
> many times.
> * took sources from
> "http://svn.apache.org/repos/asf/jakarta/velocity/core/trunk/"
> address. I think this a src dump I should you as a
> starting point.
>
> Steps to be done:
> * fix code to use Map, List interfaces (use concrete
> HashMap and ArrayList constructors)
> * run ant tests
> * create a patch, what program and how?
> * copy patch, where copy to?
>
> Last two steps are still unknown to me.
>
> --- Will Glass-Husain <wg...@forio.com> wrote:
>>>Thanks for catching this. Better yet, good modern
> practice would also be to declare the variables as
> List and Map.
> If you'd care to issue a bug report at
> http://issues.apache.org (use BugZilla until we switch
> to JIRA) this can get tracked. If you're feeling
> ambitious, download svn, get the source and create a
> patch. If "ant test" passes I'll commit it straight
> away.
>
>> ----- Original Message -----
>> From: "mailmur" <ma...@yahoo.com>
> org\apache\velocity\runtime\resource\loader\FileResourceLoader.java
>> >
>> > This class uses Vector and Hashtable instances to
>> > store cached paths values. Should this and other
>> > classes be converted to use ArrayList and HashMap
>> > instances?
>
>
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Mail - You care about security. So do we.
> http://promotions.yahoo.com/new_mail
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by mailmur <ma...@yahoo.com>.
Posted a bug report: #35558
I can see this to be fixed. First I must install
subversion client, take a dump from repository and
finally study what "creating a patch" means. I've
never used sv or created any patch files.
..ok..first step done:
* installed RapidSVN client, took some time to browse
subversion site and understand all bits. They have
just too many clients to choose from. Or atleast most
of them are not worth to try...as I discovered too
many times.
* took sources from
"http://svn.apache.org/repos/asf/jakarta/velocity/core/trunk/"
address. I think this a src dump I should you as a
starting point.
Steps to be done:
* fix code to use Map, List interfaces (use concrete
HashMap and ArrayList constructors)
* run ant tests
* create a patch, what program and how?
* copy patch, where copy to?
Last two steps are still unknown to me.
--- Will Glass-Husain <wg...@forio.com> wrote:
>>Thanks for catching this. Better yet, good modern
practice would also be to declare the variables as
List and Map.
If you'd care to issue a bug report at
http://issues.apache.org (use BugZilla until we switch
to JIRA) this can get tracked. If you're feeling
ambitious, download svn, get the source and create a
patch. If "ant test" passes I'll commit it straight
away.
> ----- Original Message -----
> From: "mailmur" <ma...@yahoo.com>
org\apache\velocity\runtime\resource\loader\FileResourceLoader.java
> >
> > This class uses Vector and Hashtable instances to
> > store cached paths values. Should this and other
> > classes be converted to use ArrayList and HashMap
> > instances?
__________________________________
Do you Yahoo!?
Yahoo! Mail - You care about security. So do we.
http://promotions.yahoo.com/new_mail
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org
Re: Loaders and Hashtable+Vector legacy use?
Posted by Will Glass-Husain <wg...@forio.com>.
Thanks for catching this. Better yet, good modern practice would also be to
declare the variables as List and Map.
If you'd care to issue a bug report at http://issues.apache.org (use
BugZilla until we switch to JIRA) this can get tracked. If you're feeling
ambitious, download svn, get the source and create a patch. If "ant test"
passes I'll commit it straight away.
Best, WILL
----- Original Message -----
From: "mailmur" <ma...@yahoo.com>
To: "Velocity Users List" <ve...@jakarta.apache.org>
Sent: Monday, June 27, 2005 12:50 PM
Subject: Loaders and Hashtable+Vector legacy use?
> File:
> org\apache\velocity\runtime\resource\loader\FileResourceLoader.java
>
> This class uses Vector and Hashtable instances to
> store cached paths values. Should this and other
> classes be converted to use ArrayList and HashMap
> instances?
>
> I think ArrayList+Hashmap give better runtime performance.
>
>
>
> __________________________________
> Yahoo! Mail
> Stay connected, organized, and protected. Take the tour:
> http://tour.mail.yahoo.com/mailtour.html
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org