You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by uncleGen <gi...@git.apache.org> on 2017/02/24 06:41:41 UTC

[GitHub] spark pull request #17052: [SPARK-19690][SS] Join a streaming DataFrame with...

GitHub user uncleGen opened a pull request:

    https://github.com/apache/spark/pull/17052

    [SPARK-19690][SS] Join a streaming DataFrame with a batch DataFrame which has an aggregation may not work

    ## What changes were proposed in this pull request?
    
    `StatefulAggregationStrategy` should check logicplan is streaming or not
    
    Test code:
    
    ```
    case class Record(key: Int, value: String)
    val df = spark.createDataFrame((1 to 100).map(i => Record(i, s"value_$i"))).groupBy("value").count
    val lines = spark.readStream.format("socket").option("host", "localhost").option("port", "9999").load 
    val words = lines.as[String].flatMap(_.split(" ")) 
    val result = words.join(df, "value")
    ```
    
    before pr:
    
    ```
    == Physical Plan ==
    *Project [value#13, count#19L]
    +- *BroadcastHashJoin [value#13], [value#1], Inner, BuildRight
       :- *Filter isnotnull(value#13)
       :  +- *SerializeFromObject [staticinvoke(class org.apache.spark.unsafe.types.UTF8String, StringType, fromString, input[0, java.lang.String, true], true) AS value#13]
       :     +- MapPartitions <function1>, obj#12: java.lang.String
       :        +- DeserializeToObject value#5.toString, obj#11: java.lang.String
       :           +- StreamingRelation textSocket, [value#5]
       +- BroadcastExchange HashedRelationBroadcastMode(List(input[0, string, true]))
          +- *HashAggregate(keys=[value#1], functions=[count(1)])
             +- StateStoreSave [value#1], OperatorStateId(<unknown>,0,0), Append, 0
                +- *HashAggregate(keys=[value#1], functions=[merge_count(1)])
                   +- StateStoreRestore [value#1], OperatorStateId(<unknown>,0,0)
                      +- *HashAggregate(keys=[value#1], functions=[merge_count(1)])
                         +- Exchange hashpartitioning(value#1, 200)
                            +- *HashAggregate(keys=[value#1], functions=[partial_count(1)])
                               +- *Project [value#1]
                                  +- *Filter isnotnull(value#1)
                                     +- LocalTableScan [key#0, value#1]
    ```
    
    after pr:
    
    ```
    == Physical Plan ==
    *Project [value#13, count#19L]
    +- *BroadcastHashJoin [value#13], [value#1], Inner, BuildRight
       :- *Filter isnotnull(value#13)
       :  +- *SerializeFromObject [staticinvoke(class org.apache.spark.unsafe.types.UTF8String, StringType, fromString, input[0, java.lang.String, true], true) AS value#13]
       :     +- MapPartitions <function1>, obj#12: java.lang.String
       :        +- DeserializeToObject value#5.toString, obj#11: java.lang.String
       :           +- StreamingRelation textSocket, [value#5]
       +- BroadcastExchange HashedRelationBroadcastMode(List(input[0, string, true]))
          +- *HashAggregate(keys=[value#1], functions=[count(1)])
             +- Exchange hashpartitioning(value#1, 200)
                +- *HashAggregate(keys=[value#1], functions=[partial_count(1)])
                   +- *Project [value#1]
                      +- *Filter isnotnull(value#1)
                         +- LocalTableScan [key#0, value#1]
    ```
    
    ## How was this patch tested?
    
    add new unit test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uncleGen/spark SPARK-19690

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17052
    
----
commit e45b06e2495e09c6d7e7a50ee509044b526bf8d0
Author: uncleGen <hu...@gmail.com>
Date:   2017-02-22T10:18:31Z

    Join a streaming DataFrame with a batch DataFrame which has an aggregation may not work

commit 9eb57b7294f2636e370be86cf975509917fdd861
Author: uncleGen <hu...@gmail.com>
Date:   2017-02-24T06:38:41Z

    code clean

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by uncleGen <gi...@git.apache.org>.

Github user uncleGen commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #73559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73559/testReport)** for PR 17052 at commit [`59f4272`](https://github.com/apache/spark/commit/59f4272ee97b77bc1aaedb7daf63acf1b417d58e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #78895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78895/testReport)** for PR 17052 at commit [`a1f9327`](https://github.com/apache/spark/commit/a1f93277087fc217edf3532b41f3bab07a636d55).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #74852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74852/testReport)** for PR 17052 at commit [`a1f9327`](https://github.com/apache/spark/commit/a1f93277087fc217edf3532b41f3bab07a636d55).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #73412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73412/testReport)** for PR 17052 at commit [`9c15fcb`](https://github.com/apache/spark/commit/9c15fcb75533608c0ddb1e75dc12456e815d5f5f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #73507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73507/testReport)** for PR 17052 at commit [`38e3a14`](https://github.com/apache/spark/commit/38e3a14b609373f2fae21fcd70a14669cfc96aa1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    **[Test build #74844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74844/testReport)** for PR 17052 at commit [`a1f9327`](https://github.com/apache/spark/commit/a1f93277087fc217edf3532b41f3bab07a636d55).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by uncleGen <gi...@git.apache.org>.

Github user uncleGen commented on the issue:

    https://github.com/apache/spark/pull/17052
  
     retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

Posted by uncleGen <gi...@git.apache.org>.

Github user uncleGen commented on the issue:

    https://github.com/apache/spark/pull/17052
  
    cc @zsxwing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org