You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/07/17 07:38:28 UTC
[GitHub] tajo pull request: TAJO-914: join queries with constant values can...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/78
TAJO-914: join queries with constant values can cause schema mismatch in logical plan
This is a temporal solution, but it effectively fixes the critical problem.
Its essential solution would be TAJO-895. Please see the detail at https://issues.apache.org/jira/browse/TAJO-914.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 3f47df51d1868e59f2de2c6b29d5d38b2b5cb5f6
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-07-07T04:39:05Z
TAJO-913: Add some missed tests for constant value group-by keys.
commit 627967b2077dbd68a5401110b42ea04b4fddfeac
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-07-07T06:37:25Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-913
commit 9ef919dd12407865e0e83599893ac06cdb90b51a
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-07-08T03:17:55Z
TAJO-914: join queries with constant values can cause schema mismatch in logical plan.
commit f016b57abd7ad265949c3bbb98d08fe8335738db
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-07-17T05:35:47Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-914
Conflicts:
tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithConstantKeys2.sql
tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys2.result
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-914: join queries with constant values can...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-914: join queries with constant values can...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/78#issuecomment-49841162
I've just rebased it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-914: join queries with constant values can...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/78#issuecomment-49844639
+1
Thanks your contribution.
It looks good overall, and 'mvn clean install' finished successfully.
Push it. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-914: join queries with constant values can...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/78#issuecomment-49824866
You need to rebase the patch against master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---